rename files dirs

rename files dirs

[Frans Meulenbroeks]

Currently lots of our patches reside in a directory called files.
Somewhere in the past koen explained me that that is not really proper
(and I agree with them).
files should only be used in case a dir has multiple recipes (say X.bb
and Y.bb) which both use the same patch
If there is only a single recipe with multiple versions (e.g.X_0.bb
and X_1.bb) then common patches should go into a dir X.
And if the patches are for a specific version they should go in X-0, X-1 etc.

When I'm bored again on a rainy sunday afternoon or so, I can spent
some time on moving things.
Are people comfortable with that?
Also what would be the preferred way to store the patches for a recipe
with only one version (Z_3.bb)
Should this preferably be in Z or in Z-3 ?

Your opinion is apprecated

Frans

(ps: in my enthousiasm I already listed this as a task in
http://wiki.openembedded.org/index.php/OpenEmbeddedJanitors
If people are unhappy with the idea, I'll remove it from it again).

Re: rename files dirs

[Martin Jansa]

On Mon, Aug 16, 2010 at 10:00:42PM +0200, Frans Meulenbroeks wrote:
> Currently lots of our patches reside in a directory called files.
> Somewhere in the past koen explained me that that is not really proper
> (and I agree with them).
> files should only be used in case a dir has multiple recipes (say X.bb
> and Y.bb) which both use the same patch
> If there is only a single recipe with multiple versions (e.g.X_0.bb
> and X_1.bb) then common patches should go into a dir X.
> And if the patches are for a specific version they should go in X-0, X-1 etc.
> 
> When I'm bored again on a rainy sunday afternoon or so, I can spent
> some time on moving things.
> Are people comfortable with that?
> Also what would be the preferred way to store the patches for a recipe
> with only one version (Z_3.bb)
> Should this preferably be in Z or in Z-3 ?

If it's something where you expect the need to update the patch for Z_4
then I would say Z-3, but if it's some tweak (ie to allow crossbuilding)
and the same patch applied to Z_[12345] then Z is right dir (if Z_6
needs updated patch it will be named the same but in Z-6).
> 
> Your opinion is apprecated

I did exactly the same while cleaning xorg-* dirs. So I agree.

Regards,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: rename files dirs

[Dr. Michael Lauer]

> Currently lots of our patches reside in a directory called files.
> Somewhere in the past koen explained me that that is not really proper
> (and I agree with them).

I disagree with that. In fact I'd rather suggest the other way, which
is: Put them all into files/ unless you have a compelling reason not to,
i.e. the moment one patch does not apply any longer to all versions of
the recipes; then it should be moved to PN-PV directory.

Cheers,

:M:

Re: rename files dirs

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17-08-10 10:39, Dr. Michael Lauer wrote:
>> Currently lots of our patches reside in a directory called files.
>> Somewhere in the past koen explained me that that is not really proper
>> (and I agree with them).
> 
> I disagree with that. In fact I'd rather suggest the other way, which
> is: Put them all into files/ unless you have a compelling reason not to,
> i.e. the moment one patch does not apply any longer to all versions of
> the recipes; then it should be moved to PN-PV directory.

What's wrong with putting those patches in PN/ instead of files/? Having
them in files/ significantly threatens all efforts to clean up the
recipes/ structure :(
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMak6cMkyGM64RGpERAi7ZAKC3znJEhz9R+E+ogbSIk+CFNhscJwCeNzU5
bj8CdsrE7eEOUc9QyPoJ2JE=
=R/wu
-----END PGP SIGNATURE-----

Re: rename files dirs

[Dr. Michael Lauer]

Am 17.08.2010 um 10:55 schrieb Koen Kooi:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 17-08-10 10:39, Dr. Michael Lauer wrote:
>>> Currently lots of our patches reside in a directory called files.
>>> Somewhere in the past koen explained me that that is not really proper
>>> (and I agree with them).
>> 
>> I disagree with that. In fact I'd rather suggest the other way, which
>> is: Put them all into files/ unless you have a compelling reason not to,
>> i.e. the moment one patch does not apply any longer to all versions of
>> the recipes; then it should be moved to PN-PV directory.
> 
> What's wrong with putting those patches in PN/ instead of files/? Having
> them in files/ significantly threatens all efforts to clean up the
> recipes/ structure :(

I didn't say it's wrong, but rather that the workflow I presented
feels more natural to me. I can live with putting them all in PN.

Cheers,

:M: