All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Jan Kara <jack@suse.cz>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rik van Riel <riel@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Li Shaohua <shaohua.li@intel.com>
Subject: Re: [RFC PATCH 0/3] Do not wait the full timeout on congestion_wait when there is no congestion
Date: Fri, 27 Aug 2010 10:38:25 +0100	[thread overview]
Message-ID: <20100827093825.GF19556@csn.ul.ie> (raw)
In-Reply-To: <20100827012147.GC7353@localhost>

On Fri, Aug 27, 2010 at 09:21:47AM +0800, Wu Fengguang wrote:
> Minchan,
> 
> It's much cleaner to keep the unchanged congestion_wait() and add a
> congestion_wait_check() for converting problematic wait sites. The
> too_many_isolated() wait is merely a protective mechanism, I won't
> bother to improve it at the cost of more code.
> 

This is what I've done. I dropped the patch again and am using
wait_iff_congested(). I left the too_many_isolated() callers as
congestion_wait().

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Jan Kara <jack@suse.cz>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rik van Riel <riel@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Li Shaohua <shaohua.li@intel.com>
Subject: Re: [RFC PATCH 0/3] Do not wait the full timeout on congestion_wait when there is no congestion
Date: Fri, 27 Aug 2010 10:38:25 +0100	[thread overview]
Message-ID: <20100827093825.GF19556@csn.ul.ie> (raw)
In-Reply-To: <20100827012147.GC7353@localhost>

On Fri, Aug 27, 2010 at 09:21:47AM +0800, Wu Fengguang wrote:
> Minchan,
> 
> It's much cleaner to keep the unchanged congestion_wait() and add a
> congestion_wait_check() for converting problematic wait sites. The
> too_many_isolated() wait is merely a protective mechanism, I won't
> bother to improve it at the cost of more code.
> 

This is what I've done. I dropped the patch again and am using
wait_iff_congested(). I left the too_many_isolated() callers as
congestion_wait().

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-08-27  9:38 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26 15:14 [RFC PATCH 0/3] Do not wait the full timeout on congestion_wait when there is no congestion Mel Gorman
2010-08-26 15:14 ` Mel Gorman
2010-08-26 15:14 ` [PATCH 1/3] writeback: Account for time spent congestion_waited Mel Gorman
2010-08-26 15:14   ` Mel Gorman
2010-08-26 17:23   ` Minchan Kim
2010-08-26 17:23     ` Minchan Kim
2010-08-26 18:10   ` Johannes Weiner
2010-08-26 18:10     ` Johannes Weiner
2010-08-26 15:14 ` [PATCH 2/3] writeback: Record if the congestion was unnecessary Mel Gorman
2010-08-26 15:14   ` Mel Gorman
2010-08-26 17:35   ` Minchan Kim
2010-08-26 17:35     ` Minchan Kim
2010-08-26 17:41     ` Mel Gorman
2010-08-26 17:41       ` Mel Gorman
2010-08-26 18:29   ` Johannes Weiner
2010-08-26 18:29     ` Johannes Weiner
2010-08-26 20:31     ` Mel Gorman
2010-08-26 20:31       ` Mel Gorman
2010-08-27  2:12       ` Shaohua Li
2010-08-27  2:12         ` Shaohua Li
2010-08-27  9:20         ` Mel Gorman
2010-08-27  9:20           ` Mel Gorman
2010-08-27  8:16       ` Johannes Weiner
2010-08-27  8:16         ` Johannes Weiner
2010-08-27  9:24         ` Mel Gorman
2010-08-27  9:24           ` Mel Gorman
2010-08-30 13:19           ` Johannes Weiner
2010-08-31 15:02             ` Mel Gorman
2010-08-31 15:02               ` Mel Gorman
2010-09-02 15:49               ` Johannes Weiner
2010-09-02 15:49                 ` Johannes Weiner
2010-09-02 18:28                 ` Mel Gorman
2010-09-02 18:28                   ` Mel Gorman
2010-08-29 16:03     ` Minchan Kim
2010-08-29 16:03       ` Minchan Kim
2010-08-26 15:14 ` [PATCH 3/3] writeback: Do not congestion sleep when there are no congested BDIs Mel Gorman
2010-08-26 15:14   ` Mel Gorman
2010-08-26 17:38   ` Minchan Kim
2010-08-26 17:38     ` Minchan Kim
2010-08-26 17:42     ` Mel Gorman
2010-08-26 17:42       ` Mel Gorman
2010-08-26 18:17       ` Johannes Weiner
2010-08-26 18:17         ` Johannes Weiner
2010-08-26 20:23         ` Mel Gorman
2010-08-26 20:23           ` Mel Gorman
2010-08-27  1:11           ` Wu Fengguang
2010-08-27  1:11             ` Wu Fengguang
2010-08-27  9:34             ` Mel Gorman
2010-08-27  9:34               ` Mel Gorman
2010-08-27  1:42         ` Wu Fengguang
2010-08-27  1:42           ` Wu Fengguang
2010-08-27  9:37           ` Mel Gorman
2010-08-27  9:37             ` Mel Gorman
2010-08-27  5:13   ` Dave Chinner
2010-08-27  5:13     ` Dave Chinner
2010-08-27  9:33     ` Mel Gorman
2010-08-27  9:33       ` Mel Gorman
2010-08-26 17:20 ` [RFC PATCH 0/3] Do not wait the full timeout on congestion_wait when there is no congestion Minchan Kim
2010-08-26 17:20   ` Minchan Kim
2010-08-26 17:31   ` Mel Gorman
2010-08-26 17:31     ` Mel Gorman
2010-08-26 17:50     ` Minchan Kim
2010-08-26 17:50       ` Minchan Kim
2010-08-27  1:21   ` Wu Fengguang
2010-08-27  1:21     ` Wu Fengguang
2010-08-27  1:41     ` Minchan Kim
2010-08-27  1:41       ` Minchan Kim
2010-08-27  1:50       ` Wu Fengguang
2010-08-27  1:50         ` Wu Fengguang
2010-08-27  2:02         ` Minchan Kim
2010-08-27  2:02           ` Minchan Kim
2010-08-27  4:34           ` Wu Fengguang
2010-08-27  4:34             ` Wu Fengguang
2010-08-27  9:38     ` Mel Gorman [this message]
2010-08-27  9:38       ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100827093825.GF19556@csn.ul.ie \
    --to=mel@csn.ul.ie \
    --cc=akpm@linux-foundation.org \
    --cc=ehrhardt@linux.vnet.ibm.com \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=riel@redhat.com \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.