All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Richard Zhu <r65037@freescale.com>
Subject: Re: [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data
Date: Tue, 21 Sep 2010 17:01:55 +0400	[thread overview]
Message-ID: <20100921130155.GA30150@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1285072210-10207-2-git-send-email-w.sang@pengutronix.de>

On Tue, Sep 21, 2010 at 02:30:07PM +0200, Wolfram Sang wrote:
> We need to carry some information per host, e.g. the clock. Add a
> structure for it and initialize it in the generic part.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
[...]
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index 900f329..c393289 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -13,6 +13,11 @@
>  
>  #include <linux/sdhci-pltfm.h>
>  
> +struct sdhci_pltfm_host {
> +	struct clk *clk;

Forward decl for struct clk is needed.

> +	u32 scratchpad; /* to handle quirks across io-accessor calls */

#include <linux/types.h> is needed for u32.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

WARNING: multiple messages have this Message-ID (diff)
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data
Date: Tue, 21 Sep 2010 17:01:55 +0400	[thread overview]
Message-ID: <20100921130155.GA30150@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1285072210-10207-2-git-send-email-w.sang@pengutronix.de>

On Tue, Sep 21, 2010 at 02:30:07PM +0200, Wolfram Sang wrote:
> We need to carry some information per host, e.g. the clock. Add a
> structure for it and initialize it in the generic part.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
[...]
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index 900f329..c393289 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -13,6 +13,11 @@
>  
>  #include <linux/sdhci-pltfm.h>
>  
> +struct sdhci_pltfm_host {
> +	struct clk *clk;

Forward decl for struct clk is needed.

> +	u32 scratchpad; /* to handle quirks across io-accessor calls */

#include <linux/types.h> is needed for u32.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2

  reply	other threads:[~2010-09-21 13:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 12:30 [PATCH 0/4] Adding support for esdhc on mx35/51 Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 12:30 ` [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 13:01   ` Anton Vorontsov [this message]
2010-09-21 13:01     ` Anton Vorontsov
2010-09-26  9:02   ` zhangfei gao
2010-09-26  9:02     ` zhangfei gao
2010-09-26  9:37     ` Anton Vorontsov
2010-09-26  9:37       ` Anton Vorontsov
2010-09-21 12:30 ` [PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 12:58   ` Anton Vorontsov
2010-09-21 12:58     ` Anton Vorontsov
2010-09-22  1:20   ` Ben Dooks
2010-09-22  1:20     ` Ben Dooks
2010-09-22  9:14     ` Wolfram Sang
2010-09-22  9:14       ` Wolfram Sang
2010-09-21 12:30 ` [PATCH 3/4] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 12:58   ` Anton Vorontsov
2010-09-21 12:58     ` Anton Vorontsov
2010-09-21 12:30 ` [PATCH 4/4] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 12:59   ` Anton Vorontsov
2010-09-21 12:59     ` Anton Vorontsov
2010-09-24  2:40 ` [PATCH 0/4] Adding support for esdhc on mx35/51 Zhu Richard-R65037
2010-09-24  2:40   ` Zhu Richard-R65037
2010-09-24  6:43   ` Wolfram Sang
2010-09-24  6:43     ` Wolfram Sang
2010-09-24  7:08     ` Zhu Richard-R65037
2010-09-24  7:08       ` Zhu Richard-R65037
2010-09-24  8:57       ` Wolfram Sang
2010-09-24  8:57         ` Wolfram Sang
2010-09-24  9:40         ` Zhu Richard-R65037
2010-09-24  9:40           ` Zhu Richard-R65037
2010-09-24 10:58           ` Wolfram Sang
2010-09-24 10:58             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100921130155.GA30150@oksana.dev.rtsoft.ru \
    --to=cbouatmailru@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=r65037@freescale.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.