All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben@trinity.fluff.org>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Anton Vorontsov <cbouatmailru@gmail.com>,
	Richard Zhu <r65037@freescale.com>
Subject: Re: [PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir
Date: Wed, 22 Sep 2010 02:20:11 +0100	[thread overview]
Message-ID: <20100922012011.GE27885@trinity.fluff.org> (raw)
In-Reply-To: <1285072210-10207-3-git-send-email-w.sang@pengutronix.de>

On Tue, Sep 21, 2010 at 02:30:08PM +0200, Wolfram Sang wrote:
> Make use of the mmc-directory.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mmc/host/sdhci-cns3xxx.c |    2 +-
>  drivers/mmc/host/sdhci-pltfm.c   |    2 +-
>  drivers/mmc/host/sdhci-pltfm.h   |    2 +-
>  include/linux/mmc/sdhci-pltfm.h  |   35 +++++++++++++++++++++++++++++++++++
>  include/linux/sdhci-pltfm.h      |   35 -----------------------------------

hmm, you lost rename detection... best enable it to make these diffs clearer.

>  5 files changed, 38 insertions(+), 38 deletions(-)
>  create mode 100644 include/linux/mmc/sdhci-pltfm.h
>  delete mode 100644 include/linux/sdhci-pltfm.h
> 
> diff --git a/drivers/mmc/host/sdhci-cns3xxx.c b/drivers/mmc/host/sdhci-cns3xxx.c
> index b7050b3..9ebd1d7 100644
> --- a/drivers/mmc/host/sdhci-cns3xxx.c
> +++ b/drivers/mmc/host/sdhci-cns3xxx.c
> @@ -15,7 +15,7 @@
>  #include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/mmc/host.h>
> -#include <linux/sdhci-pltfm.h>
> +#include <linux/mmc/sdhci-pltfm.h>
>  #include <mach/cns3xxx.h>
>  #include "sdhci.h"
>  #include "sdhci-pltfm.h"
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index bf522a1..ff0271c 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -30,7 +30,7 @@
>  #include <linux/mmc/host.h>
>  
>  #include <linux/io.h>
> -#include <linux/sdhci-pltfm.h>
> +#include <linux/mmc/sdhci-pltfm.h>
>  
>  #include "sdhci.h"
>  #include "sdhci-pltfm.h"
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index c393289..2b43ed5 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -11,7 +11,7 @@
>  #ifndef _DRIVERS_MMC_SDHCI_PLTFM_H
>  #define _DRIVERS_MMC_SDHCI_PLTFM_H
>  
> -#include <linux/sdhci-pltfm.h>
> +#include <linux/mmc/sdhci-pltfm.h>
>  
>  struct sdhci_pltfm_host {
>  	struct clk *clk;
> diff --git a/include/linux/mmc/sdhci-pltfm.h b/include/linux/mmc/sdhci-pltfm.h
> new file mode 100644
> index 0000000..0239bd7
> --- /dev/null
> +++ b/include/linux/mmc/sdhci-pltfm.h
> @@ -0,0 +1,35 @@
> +/*
> + * Platform data declarations for the sdhci-pltfm driver.
> + *
> + * Copyright (c) 2010 MontaVista Software, LLC.
> + *
> + * Author: Anton Vorontsov <avorontsov@ru.mvista.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or (at
> + * your option) any later version.
> + */
> +
> +#ifndef _SDHCI_PLTFM_H
> +#define _SDHCI_PLTFM_H
> +
> +struct sdhci_ops;
> +struct sdhci_host;
> +
> +/**
> + * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks
> + * @ops: optional pointer to the platform-provided SDHCI ops
> + * @quirks: optional SDHCI quirks
> + * @init: optional hook that is called during device probe, before the
> + *        driver tries to access any SDHCI registers
> + * @exit: optional hook that is called during device removal
> + */
> +struct sdhci_pltfm_data {
> +	struct sdhci_ops *ops;
> +	unsigned int quirks;
> +	int (*init)(struct sdhci_host *host);
> +	void (*exit)(struct sdhci_host *host);
> +};
> +
> +#endif /* _SDHCI_PLTFM_H */
> diff --git a/include/linux/sdhci-pltfm.h b/include/linux/sdhci-pltfm.h
> deleted file mode 100644
> index 0239bd7..0000000
> --- a/include/linux/sdhci-pltfm.h
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -/*
> - * Platform data declarations for the sdhci-pltfm driver.
> - *
> - * Copyright (c) 2010 MontaVista Software, LLC.
> - *
> - * Author: Anton Vorontsov <avorontsov@ru.mvista.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or (at
> - * your option) any later version.
> - */
> -
> -#ifndef _SDHCI_PLTFM_H
> -#define _SDHCI_PLTFM_H
> -
> -struct sdhci_ops;
> -struct sdhci_host;
> -
> -/**
> - * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks
> - * @ops: optional pointer to the platform-provided SDHCI ops
> - * @quirks: optional SDHCI quirks
> - * @init: optional hook that is called during device probe, before the
> - *        driver tries to access any SDHCI registers
> - * @exit: optional hook that is called during device removal
> - */
> -struct sdhci_pltfm_data {
> -	struct sdhci_ops *ops;
> -	unsigned int quirks;
> -	int (*init)(struct sdhci_host *host);
> -	void (*exit)(struct sdhci_host *host);
> -};
> -
> -#endif /* _SDHCI_PLTFM_H */
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.


WARNING: multiple messages have this Message-ID (diff)
From: ben@trinity.fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir
Date: Wed, 22 Sep 2010 02:20:11 +0100	[thread overview]
Message-ID: <20100922012011.GE27885@trinity.fluff.org> (raw)
In-Reply-To: <1285072210-10207-3-git-send-email-w.sang@pengutronix.de>

On Tue, Sep 21, 2010 at 02:30:08PM +0200, Wolfram Sang wrote:
> Make use of the mmc-directory.
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mmc/host/sdhci-cns3xxx.c |    2 +-
>  drivers/mmc/host/sdhci-pltfm.c   |    2 +-
>  drivers/mmc/host/sdhci-pltfm.h   |    2 +-
>  include/linux/mmc/sdhci-pltfm.h  |   35 +++++++++++++++++++++++++++++++++++
>  include/linux/sdhci-pltfm.h      |   35 -----------------------------------

hmm, you lost rename detection... best enable it to make these diffs clearer.

>  5 files changed, 38 insertions(+), 38 deletions(-)
>  create mode 100644 include/linux/mmc/sdhci-pltfm.h
>  delete mode 100644 include/linux/sdhci-pltfm.h
> 
> diff --git a/drivers/mmc/host/sdhci-cns3xxx.c b/drivers/mmc/host/sdhci-cns3xxx.c
> index b7050b3..9ebd1d7 100644
> --- a/drivers/mmc/host/sdhci-cns3xxx.c
> +++ b/drivers/mmc/host/sdhci-cns3xxx.c
> @@ -15,7 +15,7 @@
>  #include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/mmc/host.h>
> -#include <linux/sdhci-pltfm.h>
> +#include <linux/mmc/sdhci-pltfm.h>
>  #include <mach/cns3xxx.h>
>  #include "sdhci.h"
>  #include "sdhci-pltfm.h"
> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
> index bf522a1..ff0271c 100644
> --- a/drivers/mmc/host/sdhci-pltfm.c
> +++ b/drivers/mmc/host/sdhci-pltfm.c
> @@ -30,7 +30,7 @@
>  #include <linux/mmc/host.h>
>  
>  #include <linux/io.h>
> -#include <linux/sdhci-pltfm.h>
> +#include <linux/mmc/sdhci-pltfm.h>
>  
>  #include "sdhci.h"
>  #include "sdhci-pltfm.h"
> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
> index c393289..2b43ed5 100644
> --- a/drivers/mmc/host/sdhci-pltfm.h
> +++ b/drivers/mmc/host/sdhci-pltfm.h
> @@ -11,7 +11,7 @@
>  #ifndef _DRIVERS_MMC_SDHCI_PLTFM_H
>  #define _DRIVERS_MMC_SDHCI_PLTFM_H
>  
> -#include <linux/sdhci-pltfm.h>
> +#include <linux/mmc/sdhci-pltfm.h>
>  
>  struct sdhci_pltfm_host {
>  	struct clk *clk;
> diff --git a/include/linux/mmc/sdhci-pltfm.h b/include/linux/mmc/sdhci-pltfm.h
> new file mode 100644
> index 0000000..0239bd7
> --- /dev/null
> +++ b/include/linux/mmc/sdhci-pltfm.h
> @@ -0,0 +1,35 @@
> +/*
> + * Platform data declarations for the sdhci-pltfm driver.
> + *
> + * Copyright (c) 2010 MontaVista Software, LLC.
> + *
> + * Author: Anton Vorontsov <avorontsov@ru.mvista.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or (at
> + * your option) any later version.
> + */
> +
> +#ifndef _SDHCI_PLTFM_H
> +#define _SDHCI_PLTFM_H
> +
> +struct sdhci_ops;
> +struct sdhci_host;
> +
> +/**
> + * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks
> + * @ops: optional pointer to the platform-provided SDHCI ops
> + * @quirks: optional SDHCI quirks
> + * @init: optional hook that is called during device probe, before the
> + *        driver tries to access any SDHCI registers
> + * @exit: optional hook that is called during device removal
> + */
> +struct sdhci_pltfm_data {
> +	struct sdhci_ops *ops;
> +	unsigned int quirks;
> +	int (*init)(struct sdhci_host *host);
> +	void (*exit)(struct sdhci_host *host);
> +};
> +
> +#endif /* _SDHCI_PLTFM_H */
> diff --git a/include/linux/sdhci-pltfm.h b/include/linux/sdhci-pltfm.h
> deleted file mode 100644
> index 0239bd7..0000000
> --- a/include/linux/sdhci-pltfm.h
> +++ /dev/null
> @@ -1,35 +0,0 @@
> -/*
> - * Platform data declarations for the sdhci-pltfm driver.
> - *
> - * Copyright (c) 2010 MontaVista Software, LLC.
> - *
> - * Author: Anton Vorontsov <avorontsov@ru.mvista.com>
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or (at
> - * your option) any later version.
> - */
> -
> -#ifndef _SDHCI_PLTFM_H
> -#define _SDHCI_PLTFM_H
> -
> -struct sdhci_ops;
> -struct sdhci_host;
> -
> -/**
> - * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks
> - * @ops: optional pointer to the platform-provided SDHCI ops
> - * @quirks: optional SDHCI quirks
> - * @init: optional hook that is called during device probe, before the
> - *        driver tries to access any SDHCI registers
> - * @exit: optional hook that is called during device removal
> - */
> -struct sdhci_pltfm_data {
> -	struct sdhci_ops *ops;
> -	unsigned int quirks;
> -	int (*init)(struct sdhci_host *host);
> -	void (*exit)(struct sdhci_host *host);
> -};
> -
> -#endif /* _SDHCI_PLTFM_H */
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  parent reply	other threads:[~2010-09-22  1:20 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 12:30 [PATCH 0/4] Adding support for esdhc on mx35/51 Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 12:30 ` [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 13:01   ` Anton Vorontsov
2010-09-21 13:01     ` Anton Vorontsov
2010-09-26  9:02   ` zhangfei gao
2010-09-26  9:02     ` zhangfei gao
2010-09-26  9:37     ` Anton Vorontsov
2010-09-26  9:37       ` Anton Vorontsov
2010-09-21 12:30 ` [PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 12:58   ` Anton Vorontsov
2010-09-21 12:58     ` Anton Vorontsov
2010-09-22  1:20   ` Ben Dooks [this message]
2010-09-22  1:20     ` Ben Dooks
2010-09-22  9:14     ` Wolfram Sang
2010-09-22  9:14       ` Wolfram Sang
2010-09-21 12:30 ` [PATCH 3/4] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 12:58   ` Anton Vorontsov
2010-09-21 12:58     ` Anton Vorontsov
2010-09-21 12:30 ` [PATCH 4/4] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-21 12:30   ` Wolfram Sang
2010-09-21 12:59   ` Anton Vorontsov
2010-09-21 12:59     ` Anton Vorontsov
2010-09-24  2:40 ` [PATCH 0/4] Adding support for esdhc on mx35/51 Zhu Richard-R65037
2010-09-24  2:40   ` Zhu Richard-R65037
2010-09-24  6:43   ` Wolfram Sang
2010-09-24  6:43     ` Wolfram Sang
2010-09-24  7:08     ` Zhu Richard-R65037
2010-09-24  7:08       ` Zhu Richard-R65037
2010-09-24  8:57       ` Wolfram Sang
2010-09-24  8:57         ` Wolfram Sang
2010-09-24  9:40         ` Zhu Richard-R65037
2010-09-24  9:40           ` Zhu Richard-R65037
2010-09-24 10:58           ` Wolfram Sang
2010-09-24 10:58             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922012011.GE27885@trinity.fluff.org \
    --to=ben@trinity.fluff.org \
    --cc=cbouatmailru@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=r65037@freescale.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.