From: Anton Vorontsov <cbouatmailru@gmail.com>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Richard Zhu <r65037@freescale.com>
Subject: Re: [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data
Date: Sun, 26 Sep 2010 13:37:37 +0400 [thread overview]
Message-ID: <20100926093737.GA24005@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTimcscR56u=-iT9v5V+Tsg2KNOqiuQ2DKojJ++6c@mail.gmail.com>
Hello,
On Sun, Sep 26, 2010 at 05:02:29AM -0400, zhangfei gao wrote:
> On Tue, Sep 21, 2010 at 8:30 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > @@ -13,6 +13,11 @@
> >
> > #include <linux/sdhci-pltfm.h>
> >
> > +struct sdhci_pltfm_host {
> > + struct clk *clk;
> > + u32 scratchpad; /* to handle quirks across io-accessor calls */
> > +};
> > +
> How about move private data to child driver, and one call back
> function alloc_host, then child driver could alloc private data,
> including clk.
IMHO, this sounds like a bit of overdesign/overcomplication.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
WARNING: multiple messages have this Message-ID (diff)
From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data
Date: Sun, 26 Sep 2010 13:37:37 +0400 [thread overview]
Message-ID: <20100926093737.GA24005@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <AANLkTimcscR56u=-iT9v5V+Tsg2KNOqiuQ2DKojJ++6c@mail.gmail.com>
Hello,
On Sun, Sep 26, 2010 at 05:02:29AM -0400, zhangfei gao wrote:
> On Tue, Sep 21, 2010 at 8:30 AM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> > +++ b/drivers/mmc/host/sdhci-pltfm.h
> > @@ -13,6 +13,11 @@
> >
> > ?#include <linux/sdhci-pltfm.h>
> >
> > +struct sdhci_pltfm_host {
> > + ? ? ? struct clk *clk;
> > + ? ? ? u32 scratchpad; /* to handle quirks across io-accessor calls */
> > +};
> > +
> How about move private data to child driver, and one call back
> function alloc_host, then child driver could alloc private data,
> including clk.
IMHO, this sounds like a bit of overdesign/overcomplication.
--
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2010-09-26 9:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 12:30 [PATCH 0/4] Adding support for esdhc on mx35/51 Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 12:30 ` [PATCH 1/4] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 13:01 ` Anton Vorontsov
2010-09-21 13:01 ` Anton Vorontsov
2010-09-26 9:02 ` zhangfei gao
2010-09-26 9:02 ` zhangfei gao
2010-09-26 9:37 ` Anton Vorontsov [this message]
2010-09-26 9:37 ` Anton Vorontsov
2010-09-21 12:30 ` [PATCH 2/4] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 12:58 ` Anton Vorontsov
2010-09-21 12:58 ` Anton Vorontsov
2010-09-22 1:20 ` Ben Dooks
2010-09-22 1:20 ` Ben Dooks
2010-09-22 9:14 ` Wolfram Sang
2010-09-22 9:14 ` Wolfram Sang
2010-09-21 12:30 ` [PATCH 3/4] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 12:58 ` Anton Vorontsov
2010-09-21 12:58 ` Anton Vorontsov
2010-09-21 12:30 ` [PATCH 4/4] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-21 12:30 ` Wolfram Sang
2010-09-21 12:59 ` Anton Vorontsov
2010-09-21 12:59 ` Anton Vorontsov
2010-09-24 2:40 ` [PATCH 0/4] Adding support for esdhc on mx35/51 Zhu Richard-R65037
2010-09-24 2:40 ` Zhu Richard-R65037
2010-09-24 6:43 ` Wolfram Sang
2010-09-24 6:43 ` Wolfram Sang
2010-09-24 7:08 ` Zhu Richard-R65037
2010-09-24 7:08 ` Zhu Richard-R65037
2010-09-24 8:57 ` Wolfram Sang
2010-09-24 8:57 ` Wolfram Sang
2010-09-24 9:40 ` Zhu Richard-R65037
2010-09-24 9:40 ` Zhu Richard-R65037
2010-09-24 10:58 ` Wolfram Sang
2010-09-24 10:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926093737.GA24005@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=r65037@freescale.com \
--cc=w.sang@pengutronix.de \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.