From: Matt Fleming <matt@console-pimps.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>,
Paul Mundt <lethal@linux-sh.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend
Date: Tue, 28 Sep 2010 09:33:56 +0100 [thread overview]
Message-ID: <20100928083355.GA4037@console-pimps.org> (raw)
In-Reply-To: <20100927224551.GX13563@erda.amd.com>
On Tue, Sep 28, 2010 at 12:45:51AM +0200, Robert Richter wrote:
> On 27.09.10 18:26:27, Matt Fleming wrote:
> >
> > I don't see why we should pollute the perf namespace with a function
> > that is only being used inside the SH oprofile code? There would be
> > exactly one use of this function and I doubt the perf guys will want
> > this function exposed. In it's current state, it really is no use to any
> > architecture other than SH.
> >
> > We can always add a generic perf_pmu_name() function later if needed,
> > but it's definitely not needed at the moment.
>
> Ok, so then let's implement sh_pmu_name() in
> arch/sh/oprofile/common.c, we import asm/perf_event.h to get access to
> struct sh_pmu. This could be implemented as a static function then and
> we also get rid of this interface thing.
That seems OK to me s'long as Paul (the author of the perf events code
for SH) doesn't have a problem with us exposing the struct sh_pmu *
outside of arch/sh/kernel/perf_event.c
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@console-pimps.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Will Deacon <will.deacon@arm.com>,
Paul Mundt <lethal@linux-sh.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend
Date: Tue, 28 Sep 2010 08:33:56 +0000 [thread overview]
Message-ID: <20100928083355.GA4037@console-pimps.org> (raw)
In-Reply-To: <20100927224551.GX13563@erda.amd.com>
On Tue, Sep 28, 2010 at 12:45:51AM +0200, Robert Richter wrote:
> On 27.09.10 18:26:27, Matt Fleming wrote:
> >
> > I don't see why we should pollute the perf namespace with a function
> > that is only being used inside the SH oprofile code? There would be
> > exactly one use of this function and I doubt the perf guys will want
> > this function exposed. In it's current state, it really is no use to any
> > architecture other than SH.
> >
> > We can always add a generic perf_pmu_name() function later if needed,
> > but it's definitely not needed at the moment.
>
> Ok, so then let's implement sh_pmu_name() in
> arch/sh/oprofile/common.c, we import asm/perf_event.h to get access to
> struct sh_pmu. This could be implemented as a static function then and
> we also get rid of this interface thing.
That seems OK to me s'long as Paul (the author of the perf events code
for SH) doesn't have a problem with us exposing the struct sh_pmu *
outside of arch/sh/kernel/perf_event.c
WARNING: multiple messages have this Message-ID (diff)
From: matt@console-pimps.org (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend
Date: Tue, 28 Sep 2010 09:33:56 +0100 [thread overview]
Message-ID: <20100928083355.GA4037@console-pimps.org> (raw)
In-Reply-To: <20100927224551.GX13563@erda.amd.com>
On Tue, Sep 28, 2010 at 12:45:51AM +0200, Robert Richter wrote:
> On 27.09.10 18:26:27, Matt Fleming wrote:
> >
> > I don't see why we should pollute the perf namespace with a function
> > that is only being used inside the SH oprofile code? There would be
> > exactly one use of this function and I doubt the perf guys will want
> > this function exposed. In it's current state, it really is no use to any
> > architecture other than SH.
> >
> > We can always add a generic perf_pmu_name() function later if needed,
> > but it's definitely not needed at the moment.
>
> Ok, so then let's implement sh_pmu_name() in
> arch/sh/oprofile/common.c, we import asm/perf_event.h to get access to
> struct sh_pmu. This could be implemented as a static function then and
> we also get rid of this interface thing.
That seems OK to me s'long as Paul (the author of the perf events code
for SH) doesn't have a problem with us exposing the struct sh_pmu *
outside of arch/sh/kernel/perf_event.c
next prev parent reply other threads:[~2010-09-28 8:33 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 6:07 [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` [PATCH 1/6] perf: Add helper function to return number of counters Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 12:32 ` Robert Richter
2010-09-16 12:32 ` Robert Richter
2010-09-16 12:32 ` [PATCH 1/6] perf: Add helper function to return number of Robert Richter
2010-09-13 6:07 ` [PATCH 2/6] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 12:46 ` Robert Richter
2010-09-16 12:46 ` Robert Richter
2010-09-16 12:46 ` Robert Richter
2010-09-13 6:07 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate init/exit functions Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 12:55 ` Robert Richter
2010-09-16 12:55 ` Robert Richter
2010-09-16 12:55 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate Robert Richter
2010-09-13 6:07 ` [PATCH 4/6] oprofile: Abstract the perf-events backend Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 13:15 ` Robert Richter
2010-09-16 13:15 ` Robert Richter
2010-09-16 13:15 ` Robert Richter
2010-09-13 6:07 ` [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 8:39 ` Will Deacon
2010-09-13 8:39 ` Will Deacon
2010-09-13 8:39 ` Will Deacon
2010-09-16 13:34 ` Robert Richter
2010-09-16 13:34 ` Robert Richter
2010-09-16 13:34 ` Robert Richter
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 6:07 ` [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 14:32 ` Robert Richter
2010-09-16 14:32 ` Robert Richter
2010-09-16 14:32 ` Robert Richter
2010-09-27 20:01 ` Matt Fleming
2010-09-27 20:01 ` Matt Fleming
2010-09-27 20:01 ` Matt Fleming
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:45 ` Robert Richter
2010-09-27 22:45 ` Robert Richter
2010-09-27 22:45 ` Robert Richter
2010-09-27 22:45 ` Robert Richter
2010-09-28 8:33 ` Matt Fleming [this message]
2010-09-28 8:33 ` Matt Fleming
2010-09-28 8:33 ` Matt Fleming
2010-09-30 1:04 ` Paul Mundt
2010-09-30 1:04 ` Paul Mundt
2010-09-30 1:04 ` Paul Mundt
2010-09-30 8:14 ` Will Deacon
2010-09-30 8:14 ` Will Deacon
2010-09-30 8:14 ` Will Deacon
2010-09-13 7:13 ` [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Marc Titinger
2010-09-13 7:13 ` Marc Titinger
2010-09-13 7:50 ` Matt Fleming
2010-09-13 7:50 ` Matt Fleming
2010-09-13 7:50 ` Matt Fleming
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 11:04 ` Matt Fleming
2010-09-13 11:04 ` Matt Fleming
2010-09-13 11:04 ` Matt Fleming
2010-09-13 10:08 ` Will Deacon
2010-09-13 10:08 ` Will Deacon
2010-09-13 10:08 ` Will Deacon
2010-09-13 11:18 ` Matt Fleming
2010-09-13 11:18 ` Matt Fleming
2010-09-13 11:18 ` Matt Fleming
2010-09-16 14:48 ` Robert Richter
2010-09-16 14:48 ` Robert Richter
2010-09-16 14:48 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928083355.GA4037@console-pimps.org \
--to=matt@console-pimps.org \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.