From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: Robert Richter <robert.richter@amd.com>,
linux-arch@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Will Deacon <will.deacon@arm.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mundt <lethal@linux-sh.org>, Ingo Molnar <mingo@elte.hu>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS
Date: Mon, 13 Sep 2010 13:22:42 +0400 [thread overview]
Message-ID: <4C8DED62.3080208@ru.mvista.com> (raw)
In-Reply-To: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org>
Hello.
On 13-09-2010 10:07, Matt Fleming wrote:
> Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS
> is set. If this symbol is not set, oprofile initialisation will fail at
> runtime. Instead of allowing the oprofile code to build but fail at
> runtime it seems less confusing to not allow the code to be built unless
> hardware performance counter support is available.
> Signed-off-by: Matt Fleming<matt@console-pimps.org>
> ---
> arch/arm/Kconfig | 2 +-
> arch/arm/oprofile/common.c | 9 ---------
> 2 files changed, 1 insertions(+), 10 deletions(-)
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a7ed21f..d29075c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -14,7 +14,7 @@ config ARM
> select RTC_LIB
> select SYS_SUPPORTS_APM_EMULATION
> select GENERIC_ATOMIC64 if (!CPU_32v6K)
> - select HAVE_OPROFILE if (HAVE_PERF_EVENTS)
> + select HAVE_OPROFILE if (HW_PERF_EVENTS)
Could remove useless parens while at it...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS
Date: Mon, 13 Sep 2010 09:22:42 +0000 [thread overview]
Message-ID: <4C8DED62.3080208@ru.mvista.com> (raw)
In-Reply-To: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org>
Hello.
On 13-09-2010 10:07, Matt Fleming wrote:
> Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS
> is set. If this symbol is not set, oprofile initialisation will fail at
> runtime. Instead of allowing the oprofile code to build but fail at
> runtime it seems less confusing to not allow the code to be built unless
> hardware performance counter support is available.
> Signed-off-by: Matt Fleming<matt@console-pimps.org>
> ---
> arch/arm/Kconfig | 2 +-
> arch/arm/oprofile/common.c | 9 ---------
> 2 files changed, 1 insertions(+), 10 deletions(-)
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a7ed21f..d29075c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -14,7 +14,7 @@ config ARM
> select RTC_LIB
> select SYS_SUPPORTS_APM_EMULATION
> select GENERIC_ATOMIC64 if (!CPU_32v6K)
> - select HAVE_OPROFILE if (HAVE_PERF_EVENTS)
> + select HAVE_OPROFILE if (HW_PERF_EVENTS)
Could remove useless parens while at it...
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS
Date: Mon, 13 Sep 2010 13:22:42 +0400 [thread overview]
Message-ID: <4C8DED62.3080208@ru.mvista.com> (raw)
In-Reply-To: <831bc9523fe04ce899bc78230990033fbe009431.1284357372.git.matt@console-pimps.org>
Hello.
On 13-09-2010 10:07, Matt Fleming wrote:
> Currently, oprofile support is only functional if CONFIG_HW_PERF_EVENTS
> is set. If this symbol is not set, oprofile initialisation will fail at
> runtime. Instead of allowing the oprofile code to build but fail at
> runtime it seems less confusing to not allow the code to be built unless
> hardware performance counter support is available.
> Signed-off-by: Matt Fleming<matt@console-pimps.org>
> ---
> arch/arm/Kconfig | 2 +-
> arch/arm/oprofile/common.c | 9 ---------
> 2 files changed, 1 insertions(+), 10 deletions(-)
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a7ed21f..d29075c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -14,7 +14,7 @@ config ARM
> select RTC_LIB
> select SYS_SUPPORTS_APM_EMULATION
> select GENERIC_ATOMIC64 if (!CPU_32v6K)
> - select HAVE_OPROFILE if (HAVE_PERF_EVENTS)
> + select HAVE_OPROFILE if (HW_PERF_EVENTS)
Could remove useless parens while at it...
WBR, Sergei
next prev parent reply other threads:[~2010-09-13 9:24 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 6:07 [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` [PATCH 1/6] perf: Add helper function to return number of counters Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 12:32 ` Robert Richter
2010-09-16 12:32 ` Robert Richter
2010-09-16 12:32 ` [PATCH 1/6] perf: Add helper function to return number of Robert Richter
2010-09-13 6:07 ` [PATCH 2/6] ARM: oprofile: Rename op_arm to oprofile_perf Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 12:46 ` Robert Richter
2010-09-16 12:46 ` Robert Richter
2010-09-16 12:46 ` Robert Richter
2010-09-13 6:07 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate init/exit functions Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 12:55 ` Robert Richter
2010-09-16 12:55 ` Robert Richter
2010-09-16 12:55 ` [PATCH 3/6] ARM: oprofile: Move non-ARM code into separate Robert Richter
2010-09-13 6:07 ` [PATCH 4/6] oprofile: Abstract the perf-events backend Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 13:15 ` Robert Richter
2010-09-16 13:15 ` Robert Richter
2010-09-16 13:15 ` Robert Richter
2010-09-13 6:07 ` [PATCH 5/6] ARM: Make oprofile depend on CONFIG_HW_PERF_EVENTS Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 8:39 ` Will Deacon
2010-09-13 8:39 ` Will Deacon
2010-09-13 8:39 ` Will Deacon
2010-09-16 13:34 ` Robert Richter
2010-09-16 13:34 ` Robert Richter
2010-09-16 13:34 ` Robert Richter
2010-09-13 9:22 ` Sergei Shtylyov [this message]
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 9:22 ` Sergei Shtylyov
2010-09-13 6:07 ` [PATCH 6/6] sh: oprofile: Use perf-events oprofile backend Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-13 6:07 ` Matt Fleming
2010-09-16 14:32 ` Robert Richter
2010-09-16 14:32 ` Robert Richter
2010-09-16 14:32 ` Robert Richter
2010-09-27 20:01 ` Matt Fleming
2010-09-27 20:01 ` Matt Fleming
2010-09-27 20:01 ` Matt Fleming
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:07 ` Robert Richter
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:26 ` Matt Fleming
2010-09-27 22:45 ` Robert Richter
2010-09-27 22:45 ` Robert Richter
2010-09-27 22:45 ` Robert Richter
2010-09-27 22:45 ` Robert Richter
2010-09-28 8:33 ` Matt Fleming
2010-09-28 8:33 ` Matt Fleming
2010-09-28 8:33 ` Matt Fleming
2010-09-30 1:04 ` Paul Mundt
2010-09-30 1:04 ` Paul Mundt
2010-09-30 1:04 ` Paul Mundt
2010-09-30 8:14 ` Will Deacon
2010-09-30 8:14 ` Will Deacon
2010-09-30 8:14 ` Will Deacon
2010-09-13 7:13 ` [PATCH V3 0/6] Generalise ARM perf-events backend for oprofile Marc Titinger
2010-09-13 7:13 ` Marc Titinger
2010-09-13 7:50 ` Matt Fleming
2010-09-13 7:50 ` Matt Fleming
2010-09-13 7:50 ` Matt Fleming
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 8:51 ` Ingo Molnar
2010-09-13 11:04 ` Matt Fleming
2010-09-13 11:04 ` Matt Fleming
2010-09-13 11:04 ` Matt Fleming
2010-09-13 10:08 ` Will Deacon
2010-09-13 10:08 ` Will Deacon
2010-09-13 10:08 ` Will Deacon
2010-09-13 11:18 ` Matt Fleming
2010-09-13 11:18 ` Matt Fleming
2010-09-13 11:18 ` Matt Fleming
2010-09-16 14:48 ` Robert Richter
2010-09-16 14:48 ` Robert Richter
2010-09-16 14:48 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8DED62.3080208@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.