From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <jaxboe@fusionio.com>,
James Bottomley <James.Bottomley@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: I/O topology fixes for big physical block size
Date: Tue, 28 Sep 2010 14:54:57 -0400 [thread overview]
Message-ID: <20100928185457.GA13438@redhat.com> (raw)
In-Reply-To: <yq1wrq5aels.fsf@sermon.lab.mkp.net>
On Tue, Sep 28 2010 at 2:48pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Jens" == Jens Axboe <jaxboe@fusionio.com> writes:
>
> Jens> With the revised understanding that this is purely the IO hint,
> Jens> then yes I agree we should not clamp it.
>
> Ok, here's an updated sd patch that does not print a warning...
>
>
> sd: Fix overflow with big physical blocks
>
> The hw_sector_size variable could overflow if a device reported huge
> physical blocks. Switch to the more accurate physical_block_size
> terminology and make sure we use an unsigned int to match the range
> permitted by READ CAPACITY(16).
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Mike Snitzer <snitzer@redhat.com>
Thanks Martin.
prev parent reply other threads:[~2010-09-28 18:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 16:41 I/O topology fixes for big physical block size Martin K. Petersen
2010-09-27 16:41 ` [PATCH 1/2] block: Ensure physical block size is unsigned int Martin K. Petersen
2010-09-27 17:40 ` Mike Snitzer
2010-10-08 5:15 ` Martin K. Petersen
2010-10-13 19:12 ` Mike Snitzer
2010-10-13 19:15 ` Jens Axboe
2010-09-27 16:41 ` [PATCH 2/2] sd: Fix overflow with big physical blocks Martin K. Petersen
2010-09-27 17:42 ` Mike Snitzer
2010-09-27 18:13 ` [PATCH] block: eliminate potential for infinite loop in blkdev_issue_discard Mike Snitzer
2010-10-14 21:37 ` Mike Snitzer
2010-10-15 11:05 ` Jens Axboe
2010-09-27 16:54 ` I/O topology fixes for big physical block size Jens Axboe
2010-09-27 17:20 ` Martin K. Petersen
2010-09-27 22:21 ` Jens Axboe
2010-09-27 22:36 ` Martin K. Petersen
2010-09-27 23:15 ` Mike Snitzer
2010-09-28 4:30 ` Jens Axboe
2010-09-28 5:20 ` Eric Sandeen
2010-09-28 14:15 ` Mike Snitzer
2010-09-28 20:57 ` Ted Ts'o
2010-09-28 21:24 ` Martin K. Petersen
2010-09-28 21:24 ` Martin K. Petersen
2010-09-28 21:36 ` Eric Sandeen
2010-09-30 16:30 ` Ted Ts'o
2010-09-30 17:07 ` Eric Sandeen
2010-09-30 17:33 ` Mike Snitzer
2010-10-01 14:24 ` Ted Ts'o
2010-10-01 22:19 ` Martin K. Petersen
2010-10-01 22:19 ` Martin K. Petersen
2010-10-02 2:31 ` Ted Ts'o
2010-10-02 3:03 ` Daniel Taylor
2010-10-04 19:49 ` Martin K. Petersen
2010-10-04 19:49 ` Martin K. Petersen
2010-09-30 17:07 ` Eric Sandeen
2010-09-27 17:23 ` Mike Snitzer
2010-09-27 21:58 ` James Bottomley
2010-09-27 22:03 ` Jens Axboe
2010-09-27 22:14 ` Martin K. Petersen
2010-09-27 22:24 ` Jens Axboe
2010-09-28 18:48 ` Martin K. Petersen
2010-09-28 18:54 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928185457.GA13438@redhat.com \
--to=snitzer@redhat.com \
--cc=James.Bottomley@suse.de \
--cc=jaxboe@fusionio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.