From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
Mike Snitzer <snitzer@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: I/O topology fixes for big physical block size
Date: Mon, 27 Sep 2010 18:14:52 -0400 [thread overview]
Message-ID: <yq1hbhadear.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <4CA114A3.4010202@fusionio.com> (Jens Axboe's message of "Tue, 28 Sep 2010 07:03:15 +0900")
>>>>> "Jens" == Jens Axboe <jaxboe@fusionio.com> writes:
Jens> Yes, from a correctness point of view it doesn't matter, but when
Jens> people go looking up fixes for whatever reason, it's much better
Jens> to include such a fix in the original patch so it's not missed.
I have talked to a few standards people today. They are of the opinion
that the device's usage of the physical block exponent is incorrect. And
that the device must provide the Block Limits and the TP VPD if thin
provisioning is enabled.
However, devices with 8KiB physical blocks are shipping and 16KiB ditto
are right around the corner. Which says to me that it's important to
report the correct thing to userland so we can cause allocators to align
on the right boundaries, etc. If we artificially clamp the physical
block size parameter in the kernel we are losing information. Note that
there are no kernel users of the physical block size parameter at all.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2010-09-27 22:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 16:41 I/O topology fixes for big physical block size Martin K. Petersen
2010-09-27 16:41 ` [PATCH 1/2] block: Ensure physical block size is unsigned int Martin K. Petersen
2010-09-27 17:40 ` Mike Snitzer
2010-10-08 5:15 ` Martin K. Petersen
2010-10-13 19:12 ` Mike Snitzer
2010-10-13 19:15 ` Jens Axboe
2010-09-27 16:41 ` [PATCH 2/2] sd: Fix overflow with big physical blocks Martin K. Petersen
2010-09-27 17:42 ` Mike Snitzer
2010-09-27 18:13 ` [PATCH] block: eliminate potential for infinite loop in blkdev_issue_discard Mike Snitzer
2010-10-14 21:37 ` Mike Snitzer
2010-10-15 11:05 ` Jens Axboe
2010-09-27 16:54 ` I/O topology fixes for big physical block size Jens Axboe
2010-09-27 17:20 ` Martin K. Petersen
2010-09-27 22:21 ` Jens Axboe
2010-09-27 22:36 ` Martin K. Petersen
2010-09-27 23:15 ` Mike Snitzer
2010-09-28 4:30 ` Jens Axboe
2010-09-28 5:20 ` Eric Sandeen
2010-09-28 14:15 ` Mike Snitzer
2010-09-28 20:57 ` Ted Ts'o
2010-09-28 21:24 ` Martin K. Petersen
2010-09-28 21:24 ` Martin K. Petersen
2010-09-28 21:36 ` Eric Sandeen
2010-09-30 16:30 ` Ted Ts'o
2010-09-30 17:07 ` Eric Sandeen
2010-09-30 17:33 ` Mike Snitzer
2010-10-01 14:24 ` Ted Ts'o
2010-10-01 22:19 ` Martin K. Petersen
2010-10-01 22:19 ` Martin K. Petersen
2010-10-02 2:31 ` Ted Ts'o
2010-10-02 3:03 ` Daniel Taylor
2010-10-04 19:49 ` Martin K. Petersen
2010-10-04 19:49 ` Martin K. Petersen
2010-09-30 17:07 ` Eric Sandeen
2010-09-27 17:23 ` Mike Snitzer
2010-09-27 21:58 ` James Bottomley
2010-09-27 22:03 ` Jens Axboe
2010-09-27 22:14 ` Martin K. Petersen [this message]
2010-09-27 22:24 ` Jens Axboe
2010-09-28 18:48 ` Martin K. Petersen
2010-09-28 18:54 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1hbhadear.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=jaxboe@fusionio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.