From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Avi Kivity <avi@redhat.com>, Alexander Graf <agraf@suse.de>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 3/3] Add svm cpuid features
Date: Wed, 6 Oct 2010 15:57:37 -0300 [thread overview]
Message-ID: <20101006185737.GB8237@amt.cnet> (raw)
In-Reply-To: <20100928100520.GL9817@amd.com>
On Tue, Sep 28, 2010 at 12:05:20PM +0200, Roedel, Joerg wrote:
> On Tue, Sep 28, 2010 at 05:37:58AM -0400, Avi Kivity wrote:
> > On 09/28/2010 11:28 AM, Roedel, Joerg wrote:
>
> > > Weird, it worked here as I tested it. I had it on qemu/master and with
> > > all three patches. But patch 1 should not make the difference. I take a
> > > look, have you pushed the failing uq/master?
> >
> > Yes, 8fe6a21c76.
> >
> > > What was your command line?
> >
> > qemu-system-x86_64 -m 2G -cpu kvm64,+svm,+npt -enable-kvm ...
> >
> > Note this is qemu.git, so -enable-kvm is needed.
>
> Ok, I apparently forgot to force the CPUID xlevel to be 0x8000000A when
> SVM is enabled, probably because I only tested CPUID models where xlevel
> already defaults to 0x8000000A. Attached is a fix, thanks for catching
> this.
>
> Joerg
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
Date: Wed, 6 Oct 2010 15:57:37 -0300 [thread overview]
Message-ID: <20101006185737.GB8237@amt.cnet> (raw)
In-Reply-To: <20100928100520.GL9817@amd.com>
On Tue, Sep 28, 2010 at 12:05:20PM +0200, Roedel, Joerg wrote:
> On Tue, Sep 28, 2010 at 05:37:58AM -0400, Avi Kivity wrote:
> > On 09/28/2010 11:28 AM, Roedel, Joerg wrote:
>
> > > Weird, it worked here as I tested it. I had it on qemu/master and with
> > > all three patches. But patch 1 should not make the difference. I take a
> > > look, have you pushed the failing uq/master?
> >
> > Yes, 8fe6a21c76.
> >
> > > What was your command line?
> >
> > qemu-system-x86_64 -m 2G -cpu kvm64,+svm,+npt -enable-kvm ...
> >
> > Note this is qemu.git, so -enable-kvm is needed.
>
> Ok, I apparently forgot to force the CPUID xlevel to be 0x8000000A when
> SVM is enabled, probably because I only tested CPUID models where xlevel
> already defaults to 0x8000000A. Attached is a fix, thanks for catching
> this.
>
> Joerg
Applied, thanks.
next prev parent reply other threads:[~2010-10-06 18:58 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 13:16 [PATCH 0/3] SVM feature support for qemu v3 Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 13:16 ` [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled() Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-10-06 18:53 ` Marcelo Tosatti
2010-10-06 18:53 ` [Qemu-devel] " Marcelo Tosatti
2010-10-06 19:24 ` Anthony Liguori
2010-10-06 19:24 ` [Qemu-devel] " Anthony Liguori
2010-10-07 8:42 ` Roedel, Joerg
2010-10-07 8:42 ` [Qemu-devel] " Roedel, Joerg
2010-10-07 12:48 ` Anthony Liguori
2010-10-07 12:48 ` [Qemu-devel] " Anthony Liguori
2010-10-18 8:22 ` Roedel, Joerg
2010-10-18 8:22 ` [Qemu-devel] " Roedel, Joerg
2010-10-18 14:16 ` Anthony Liguori
2010-10-18 14:16 ` [Qemu-devel] " Anthony Liguori
2010-10-20 15:53 ` Blue Swirl
2010-10-20 15:53 ` Blue Swirl
2010-09-27 13:16 ` [PATCH 2/3] Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 13:16 ` [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 14:58 ` Avi Kivity
2010-09-27 14:58 ` [Qemu-devel] " Avi Kivity
2010-09-27 15:02 ` Avi Kivity
2010-09-27 15:02 ` [Qemu-devel] " Avi Kivity
2010-09-27 15:40 ` Roedel, Joerg
2010-09-27 15:40 ` [Qemu-devel] " Roedel, Joerg
2010-09-27 16:22 ` Avi Kivity
2010-09-27 16:22 ` [Qemu-devel] " Avi Kivity
2010-09-28 9:28 ` Roedel, Joerg
2010-09-28 9:28 ` [Qemu-devel] " Roedel, Joerg
2010-09-28 9:37 ` Avi Kivity
2010-09-28 9:37 ` [Qemu-devel] " Avi Kivity
2010-09-28 10:05 ` Roedel, Joerg
2010-09-28 10:05 ` [Qemu-devel] " Roedel, Joerg
2010-09-28 10:16 ` Avi Kivity
2010-09-28 10:16 ` [Qemu-devel] " Avi Kivity
2010-10-06 18:57 ` Marcelo Tosatti [this message]
2010-10-06 18:57 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 15:52 [PATCH 0/3] SVM feature support for qemu Joerg Roedel
2010-09-14 15:52 ` [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-16 14:06 ` Avi Kivity
2010-09-16 14:12 ` Roedel, Joerg
2010-09-16 14:17 ` Alexander Graf
2010-09-16 14:26 ` Roedel, Joerg
2010-09-16 14:28 ` Alexander Graf
2010-09-16 14:35 ` Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006185737.GB8237@amt.cnet \
--to=mtosatti@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.