All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] Add svm cpuid features
Date: Mon, 27 Sep 2010 17:02:23 +0200	[thread overview]
Message-ID: <4CA0B1FF.8040903@redhat.com> (raw)
In-Reply-To: <4CA0B116.4070107@redhat.com>

  On 09/27/2010 04:58 PM, Avi Kivity wrote:
>  On 09/27/2010 03:16 PM, Joerg Roedel wrote:
>> This patch adds the svm cpuid feature flags to the qemu
>> intialization path. It also adds the svm features available
>> on phenom to its cpu-definition and extends the host cpu
>> type to support all svm features KVM can provide.
>>
>
> This should really be "all svm features" since we'll later mask them 
> with kvm capabilities.  This way, if we later add more capabilities, 
> we automatically gain support in userspace.
>
> (or rather, all svm features that don't need save/restore support in 
> userspace; I don't think any do, beyond svm itself)
>

I applied 2 and 3 (to branch uq/master).  If you want to add more svm 
features, please send a patch.  For patch 1, I'd like a review by 
someone who understands the compat code.

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
Date: Mon, 27 Sep 2010 17:02:23 +0200	[thread overview]
Message-ID: <4CA0B1FF.8040903@redhat.com> (raw)
In-Reply-To: <4CA0B116.4070107@redhat.com>

  On 09/27/2010 04:58 PM, Avi Kivity wrote:
>  On 09/27/2010 03:16 PM, Joerg Roedel wrote:
>> This patch adds the svm cpuid feature flags to the qemu
>> intialization path. It also adds the svm features available
>> on phenom to its cpu-definition and extends the host cpu
>> type to support all svm features KVM can provide.
>>
>
> This should really be "all svm features" since we'll later mask them 
> with kvm capabilities.  This way, if we later add more capabilities, 
> we automatically gain support in userspace.
>
> (or rather, all svm features that don't need save/restore support in 
> userspace; I don't think any do, beyond svm itself)
>

I applied 2 and 3 (to branch uq/master).  If you want to add more svm 
features, please send a patch.  For patch 1, I'd like a review by 
someone who understands the compat code.

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2010-09-27 15:02 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 13:16 [PATCH 0/3] SVM feature support for qemu v3 Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 13:16 ` [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled() Joerg Roedel
2010-09-27 13:16   ` [Qemu-devel] " Joerg Roedel
2010-10-06 18:53   ` Marcelo Tosatti
2010-10-06 18:53     ` [Qemu-devel] " Marcelo Tosatti
2010-10-06 19:24     ` Anthony Liguori
2010-10-06 19:24       ` [Qemu-devel] " Anthony Liguori
2010-10-07  8:42       ` Roedel, Joerg
2010-10-07  8:42         ` [Qemu-devel] " Roedel, Joerg
2010-10-07 12:48         ` Anthony Liguori
2010-10-07 12:48           ` [Qemu-devel] " Anthony Liguori
2010-10-18  8:22           ` Roedel, Joerg
2010-10-18  8:22             ` [Qemu-devel] " Roedel, Joerg
2010-10-18 14:16             ` Anthony Liguori
2010-10-18 14:16               ` [Qemu-devel] " Anthony Liguori
2010-10-20 15:53               ` Blue Swirl
2010-10-20 15:53                 ` Blue Swirl
2010-09-27 13:16 ` [PATCH 2/3] Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-27 13:16   ` [Qemu-devel] " Joerg Roedel
2010-09-27 13:16 ` [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-27 13:16   ` [Qemu-devel] " Joerg Roedel
2010-09-27 14:58   ` Avi Kivity
2010-09-27 14:58     ` [Qemu-devel] " Avi Kivity
2010-09-27 15:02     ` Avi Kivity [this message]
2010-09-27 15:02       ` Avi Kivity
2010-09-27 15:40       ` Roedel, Joerg
2010-09-27 15:40         ` [Qemu-devel] " Roedel, Joerg
2010-09-27 16:22         ` Avi Kivity
2010-09-27 16:22           ` [Qemu-devel] " Avi Kivity
2010-09-28  9:28           ` Roedel, Joerg
2010-09-28  9:28             ` [Qemu-devel] " Roedel, Joerg
2010-09-28  9:37             ` Avi Kivity
2010-09-28  9:37               ` [Qemu-devel] " Avi Kivity
2010-09-28 10:05               ` Roedel, Joerg
2010-09-28 10:05                 ` [Qemu-devel] " Roedel, Joerg
2010-09-28 10:16                 ` Avi Kivity
2010-09-28 10:16                   ` [Qemu-devel] " Avi Kivity
2010-10-06 18:57                 ` Marcelo Tosatti
2010-10-06 18:57                   ` [Qemu-devel] " Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2010-09-14 15:52 [PATCH 0/3] SVM feature support for qemu Joerg Roedel
2010-09-14 15:52 ` [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-16 14:06   ` Avi Kivity
2010-09-16 14:12     ` Roedel, Joerg
2010-09-16 14:17       ` Alexander Graf
2010-09-16 14:26         ` Roedel, Joerg
2010-09-16 14:28           ` Alexander Graf
2010-09-16 14:35             ` Roedel, Joerg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA0B1FF.8040903@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=joerg.roedel@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.