From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Avi Kivity <avi@redhat.com>, Alexander Graf <agraf@suse.de>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()
Date: Thu, 7 Oct 2010 10:42:15 +0200 [thread overview]
Message-ID: <20101007084215.GB1983@amd.com> (raw)
In-Reply-To: <4CACCD0B.5090302@linux.vnet.ibm.com>
On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote:
> >> + qemu_compat_version = machine->compat_version;
> >> +
> >> if (display_type == DT_NOGRAPHIC) {
> >> if (default_parallel)
> >> add_device_config(DEV_PARALLEL, "null");
> >> --
> >> 1.7.0.4
> >>
> > Looks fine to me, given CPUs are not in qdev. Anthony?
> >
>
> The idea is fine, but why not just add the default CPU to the machine
> description?
If I remember correctly the reason was that the machine description was
not accessible in the cpuid initialization path because it is a function
local variable. I could have made it a global variable but considered
the compat_version approach simpler. The qemu_compat_version might also
be useful at other places.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
WARNING: multiple messages have this Message-ID (diff)
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled()
Date: Thu, 7 Oct 2010 10:42:15 +0200 [thread overview]
Message-ID: <20101007084215.GB1983@amd.com> (raw)
In-Reply-To: <4CACCD0B.5090302@linux.vnet.ibm.com>
On Wed, Oct 06, 2010 at 03:24:59PM -0400, Anthony Liguori wrote:
> >> + qemu_compat_version = machine->compat_version;
> >> +
> >> if (display_type == DT_NOGRAPHIC) {
> >> if (default_parallel)
> >> add_device_config(DEV_PARALLEL, "null");
> >> --
> >> 1.7.0.4
> >>
> > Looks fine to me, given CPUs are not in qdev. Anthony?
> >
>
> The idea is fine, but why not just add the default CPU to the machine
> description?
If I remember correctly the reason was that the machine description was
not accessible in the cpuid initialization path because it is a function
local variable. I could have made it a global variable but considered
the compat_version approach simpler. The qemu_compat_version might also
be useful at other places.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-10-07 8:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 13:16 [PATCH 0/3] SVM feature support for qemu v3 Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 13:16 ` [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled() Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-10-06 18:53 ` Marcelo Tosatti
2010-10-06 18:53 ` [Qemu-devel] " Marcelo Tosatti
2010-10-06 19:24 ` Anthony Liguori
2010-10-06 19:24 ` [Qemu-devel] " Anthony Liguori
2010-10-07 8:42 ` Roedel, Joerg [this message]
2010-10-07 8:42 ` Roedel, Joerg
2010-10-07 12:48 ` Anthony Liguori
2010-10-07 12:48 ` [Qemu-devel] " Anthony Liguori
2010-10-18 8:22 ` Roedel, Joerg
2010-10-18 8:22 ` [Qemu-devel] " Roedel, Joerg
2010-10-18 14:16 ` Anthony Liguori
2010-10-18 14:16 ` [Qemu-devel] " Anthony Liguori
2010-10-20 15:53 ` Blue Swirl
2010-10-20 15:53 ` Blue Swirl
2010-09-27 13:16 ` [PATCH 2/3] Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 13:16 ` [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] " Joerg Roedel
2010-09-27 14:58 ` Avi Kivity
2010-09-27 14:58 ` [Qemu-devel] " Avi Kivity
2010-09-27 15:02 ` Avi Kivity
2010-09-27 15:02 ` [Qemu-devel] " Avi Kivity
2010-09-27 15:40 ` Roedel, Joerg
2010-09-27 15:40 ` [Qemu-devel] " Roedel, Joerg
2010-09-27 16:22 ` Avi Kivity
2010-09-27 16:22 ` [Qemu-devel] " Avi Kivity
2010-09-28 9:28 ` Roedel, Joerg
2010-09-28 9:28 ` [Qemu-devel] " Roedel, Joerg
2010-09-28 9:37 ` Avi Kivity
2010-09-28 9:37 ` [Qemu-devel] " Avi Kivity
2010-09-28 10:05 ` Roedel, Joerg
2010-09-28 10:05 ` [Qemu-devel] " Roedel, Joerg
2010-09-28 10:16 ` Avi Kivity
2010-09-28 10:16 ` [Qemu-devel] " Avi Kivity
2010-10-06 18:57 ` Marcelo Tosatti
2010-10-06 18:57 ` [Qemu-devel] " Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 15:52 [PATCH 0/3] SVM feature support for qemu Joerg Roedel
2010-09-14 15:52 ` [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled() Joerg Roedel
2010-09-14 15:58 ` Alexander Graf
2010-09-14 16:21 ` Roedel, Joerg
2010-09-16 14:03 ` Avi Kivity
2010-09-16 14:21 ` Roedel, Joerg
2010-09-16 14:22 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101007084215.GB1983@amd.com \
--to=joerg.roedel@amd.com \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.