From: Dan Carpenter <error27@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Boaz Harrosh <bharrosh@panasas.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
kernel-janitors@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH v2] fs: select: fix information leak to userspace
Date: Tue, 23 Nov 2010 05:12:59 +0000 [thread overview]
Message-ID: <20101123051259.GF1522@bicker> (raw)
In-Reply-To: <20101122163234.5470e33e.akpm@linux-foundation.org>
On Mon, Nov 22, 2010 at 04:32:34PM -0800, Andrew Morton wrote:
> On Tue, 23 Nov 2010 01:20:48 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > Le lundi 22 novembre 2010 __ 15:50 -0800, Andrew Morton a __crit :
> >
> > > Well. We certainly assume in many places that
> > >
> > > struct foo {
> > > int a;
> > > int b;
> > > } f = {
> > > .a = 1,
> > > };
> > >
> > > will initialise b to zero. But I doubt if much code at all assumes
> > > that this initialisation patterm will reliably zero out *holes* in the
> > > struct.
> > >
> >
> > We did such assertions in the past, we were wrong.
Well, that sucks... I know I wrote some code that relied on holes
getting zeroed as well. Is there no option to GCC to make this work?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Boaz Harrosh <bharrosh@panasas.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
kernel-janitors@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH v2] fs: select: fix information leak to userspace
Date: Tue, 23 Nov 2010 08:12:59 +0300 [thread overview]
Message-ID: <20101123051259.GF1522@bicker> (raw)
In-Reply-To: <20101122163234.5470e33e.akpm@linux-foundation.org>
On Mon, Nov 22, 2010 at 04:32:34PM -0800, Andrew Morton wrote:
> On Tue, 23 Nov 2010 01:20:48 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> > Le lundi 22 novembre 2010 __ 15:50 -0800, Andrew Morton a __crit :
> >
> > > Well. We certainly assume in many places that
> > >
> > > struct foo {
> > > int a;
> > > int b;
> > > } f = {
> > > .a = 1,
> > > };
> > >
> > > will initialise b to zero. But I doubt if much code at all assumes
> > > that this initialisation patterm will reliably zero out *holes* in the
> > > struct.
> > >
> >
> > We did such assertions in the past, we were wrong.
Well, that sucks... I know I wrote some code that relied on holes
getting zeroed as well. Is there no option to GCC to make this work?
regards,
dan carpenter
next prev parent reply other threads:[~2010-11-23 5:12 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 20:38 [PATCH] fs: select: fix information leak to userspace Vasiliy Kulikov
2010-11-10 20:38 ` Vasiliy Kulikov
2010-11-12 20:08 ` Andrew Morton
2010-11-12 20:08 ` Andrew Morton
2010-11-13 21:38 ` Andreas Dilger
2010-11-13 21:38 ` Andreas Dilger
2010-11-14 9:25 ` [PATCH v2] " Vasiliy Kulikov
2010-11-14 9:25 ` Vasiliy Kulikov
2010-11-15 2:06 ` Andrew Morton
2010-11-15 2:06 ` Andrew Morton
2010-11-15 19:12 ` Eric Dumazet
2010-11-15 19:12 ` Eric Dumazet
2010-11-15 19:12 ` Eric Dumazet
2010-11-16 11:19 ` Boaz Harrosh
2010-11-16 11:19 ` Boaz Harrosh
2010-11-22 23:50 ` Andrew Morton
2010-11-22 23:50 ` Andrew Morton
2010-11-23 0:20 ` Eric Dumazet
2010-11-23 0:20 ` Eric Dumazet
2010-11-23 0:32 ` Andrew Morton
2010-11-23 0:32 ` Andrew Morton
2010-11-23 5:12 ` Dan Carpenter [this message]
2010-11-23 5:12 ` Dan Carpenter
2010-11-23 6:59 ` Eric Dumazet
2010-11-23 6:59 ` Eric Dumazet
2010-11-23 6:59 ` Eric Dumazet
2010-11-23 13:58 ` Américo Wang
2010-11-23 14:01 ` Américo Wang
2010-11-23 14:01 ` Américo Wang
2010-11-23 14:45 ` walter harms
2010-11-23 14:45 ` walter harms
2010-11-23 14:45 ` walter harms
2010-11-23 15:23 ` Américo Wang
2010-11-23 15:23 ` Américo Wang
2010-11-23 15:23 ` Américo Wang
2010-11-23 18:02 ` Andreas Dilger
2010-11-23 18:02 ` Andreas Dilger
2010-11-23 20:18 ` Andrew Morton
2010-11-23 20:18 ` Andrew Morton
2010-11-23 20:22 ` David Miller
2010-11-23 20:22 ` David Miller
2010-11-24 0:24 ` Andreas Dilger
2010-11-24 0:24 ` Andreas Dilger
2010-11-24 16:06 ` walter harms
2010-11-24 16:06 ` walter harms
2010-11-24 10:44 ` Pádraig Brady
2010-11-24 10:44 ` Pádraig Brady
2010-11-24 10:44 ` Pádraig Brady
2010-11-24 11:05 ` Américo Wang
2010-11-24 11:05 ` Américo Wang
2010-11-24 11:46 ` Pádraig Brady
2010-11-24 12:32 ` Américo Wang
2010-11-24 12:32 ` Américo Wang
2010-12-15 9:49 ` Al Viro
2010-12-15 20:30 ` Andreas Dilger
2010-12-15 20:30 ` Andreas Dilger
2010-12-15 20:33 ` Julia Lawall
2010-12-15 20:33 ` Julia Lawall
2010-12-15 20:52 ` Eric Dumazet
2010-12-15 20:52 ` Eric Dumazet
2010-12-15 20:52 ` Eric Dumazet
2010-12-15 22:19 ` Andreas Dilger
2010-12-15 22:19 ` Andreas Dilger
2010-12-16 9:39 ` Boaz Harrosh
2010-12-16 9:39 ` Boaz Harrosh
2010-12-16 9:39 ` Boaz Harrosh
2010-11-24 17:54 ` Valdis.Kletnieks
2010-11-24 17:54 ` Valdis.Kletnieks
2010-11-16 18:45 ` Vasiliy Kulikov
2010-11-16 18:45 ` Vasiliy Kulikov
2010-11-15 2:05 ` [PATCH] " Andrew Morton
2010-11-15 2:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123051259.GF1522@bicker \
--to=error27@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=eric.dumazet@gmail.com \
--cc=jakub@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.