From: Tony Lindgren <tony@atomide.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>
Subject: Re: [PATCH v2] musb: am35x: fix compile error due to control apis
Date: Mon, 6 Dec 2010 09:54:45 -0800 [thread overview]
Message-ID: <20101206175445.GF8345@atomide.com> (raw)
In-Reply-To: <4CFD19A7.5020902@ru.mvista.com>
* Sergei Shtylyov <sshtylyov@mvista.com> [101206 09:04]:
> Hello.
>
> Gupta, Ajay Kumar wrote:
>
> >>>As the control.h have been moved to new location and it's
> >>>uses are not allowed to drivers directly so moving the phy
> >>>control, interrupt clear and reset functionality to board
> >>>files.
>
> >> I'm not fond of the whole approach. I'm not sure why accesses to the
> >>control registers are such a no-no, taking into account that one needs to
> >>access such regisyter to clear the interrupt...
Because drivers should arch independent and any tinkering of the
platform level registers will lead into pains later on that
I end up having to deal with.
To me it seem you just init to separate out the transceiver,
right?
> >I think Tony is the right person to answer this :)
>
> Yeah, I thought he must be reading linux-omap...
I do yeah.. Might take a while to respond sometimes though :)
Tony
next prev parent reply other threads:[~2010-12-06 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 8:13 [PATCH v2] musb: am35x: fix compile error due to control apis Ajay Kumar Gupta
[not found] ` <1291623211-959-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-12-06 10:37 ` Sergei Shtylyov
[not found] ` <4CFCBCF1.9010902-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-12-06 12:31 ` Gupta, Ajay Kumar
2010-12-06 17:13 ` Sergei Shtylyov
2010-12-06 17:54 ` Tony Lindgren [this message]
[not found] ` <20101206175445.GF8345-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-12-07 13:20 ` Sergei Shtylyov
[not found] ` <4CFE3495.5090204-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-12-15 3:01 ` Paul Walmsley
2011-01-18 19:15 ` Ben Gamari
2011-01-24 15:45 ` Ben Gamari
[not found] ` <87k4hu8fvx.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-01-27 4:48 ` Felipe Balbi
[not found] ` <20110127044810.GJ2429-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-01-27 12:31 ` Ben Gamari
2011-02-01 7:26 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206175445.GF8345@atomide.com \
--to=tony@atomide.com \
--cc=ajay.gupta@ti.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.