Re: [PATCH v2] musb: am35x: fix compile error due to control apis

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 06-12-2010 20:54, Tony Lindgren wrote:

>>>>> As the control.h have been moved to new location and it's
>>>>> uses are not allowed to drivers directly so moving the phy
>>>>> control, interrupt clear and reset functionality to board
>>>>> files.

>>>>     I'm not fond of the whole approach. I'm not sure why accesses to the
>>>> control registers are such a no-no, taking into account that one needs to
>>>> access such regisyter to clear the interrupt...

> Because drivers should arch independent and any tinkering of the
> platform level registers will lead into pains later on that
> I end up having to deal with.

> To me it seem you just init to separate out the transceiver,
> right?

    We also have to install a hook to clear the MUSB level interrupt via the 
control register -- that's a thing that makes me dubious about not allowing 
drivers to access the control registers.

> Tony

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html