Re: [PATCH v2] musb: am35x: fix compile error due to control apis

[Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>]

Hello.

On 06-12-2010 11:13, Ajay Kumar Gupta wrote:

> As the control.h have been moved to new location and it's
> uses are not allowed to drivers directly so moving the phy
> control, interrupt clear and reset functionality to board
> files.

    I'm not fond of the whole approach. I'm not sure why accesses to the 
control registers are such a no-no, taking into account that one needs to 
access such regisyter to clear the interrupt...

> Signed-off-by: Ajay Kumar Gupta<ajay.gupta-l0cyMroinI0@public.gmane.org>
[...]

> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index 7260558..8c1d121 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -30,9 +30,102 @@
>   #include<mach/irqs.h>
>   #include<mach/am35xx.h>
>   #include<plat/usb.h>
> +#include "control.h"
>
>   #ifdef CONFIG_USB_MUSB_SOC
>
> +static void am35x_musb_reset(void)
> +{
> +	u32	regval;
> +
> +	/* Reset the musb interface */
> +	regval = omap_ctrl_readl(AM35XX_CONTROL_IP_SW_RESET);
> +
> +	regval |= AM35XX_USBOTGSS_SW_RST;
> +	omap_ctrl_writel(regval, AM35XX_CONTROL_IP_SW_RESET);
> +
> +	regval&= ~AM35XX_USBOTGSS_SW_RST;
> +	omap_ctrl_writel(regval, AM35XX_CONTROL_IP_SW_RESET);
> +
> +	regval = omap_ctrl_readl(AM35XX_CONTROL_IP_SW_RESET);

    Why read it and ignore the result?

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html