Re: [PATCH v2] musb: am35x: fix compile error due to control apis

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Gupta, Ajay Kumar wrote:

>>> As the control.h have been moved to new location and it's
>>> uses are not allowed to drivers directly so moving the phy
>>> control, interrupt clear and reset functionality to board
>>> files.

>>     I'm not fond of the whole approach. I'm not sure why accesses to the
>> control registers are such a no-no, taking into account that one needs to
>> access such regisyter to clear the interrupt...

> I think Tony is the right person to answer this :)

    Yeah, I thought he must be reading linux-omap...

>>> Signed-off-by: Ajay Kumar Gupta<ajay.gupta@ti.com>
>> [...]

>>> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c

> [...]

>>> +	regval&= ~AM35XX_USBOTGSS_SW_RST;
>>> +	omap_ctrl_writel(regval, AM35XX_CONTROL_IP_SW_RESET);
>>> +
>>> +	regval = omap_ctrl_readl(AM35XX_CONTROL_IP_SW_RESET);
>>     Why read it and ignore the result?

> This is due to recommendation for OMAPs as discussed at below
> Link,
> http://markmail.org/message/s3lp7xlyq7zxnjtc#query:+page:1+mid:kfia4ld4xgzek6kq+state:results

    There is recommendation to read back the interrupt status register, which 
this register isn't. Anyway, a comment wouldn't hurt...

> Thanks,
> Ajay

WBR, Sergei