From: Andrew Morton <akpm@linux-foundation.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Paul Menage" <menage@google.com>,
"David Rientjes" <rientjes@google.com>,
"缪 勰" <miaox@cn.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC()
Date: Thu, 17 Feb 2011 14:46:43 -0800 [thread overview]
Message-ID: <20110217144643.0d60bef4.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D5C7ED1.2070601@cn.fujitsu.com>
On Thu, 17 Feb 2011 09:50:09 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> +/*
> + * In functions that can't propogate errno to users, to avoid declaring a
> + * nodemask_t variable, and avoid using NODEMASK_ALLOC that can return
> + * -ENOMEM, we use this global cpuset_mems.
> + *
> + * It should be used with cgroup_lock held.
I'll do s/should/must/ - that would be a nasty bug.
I'd be more comfortable about the maintainability of this optimisation
if we had
WARN_ON(!cgroup_is_locked());
at each site.
> + */
> +static nodemask_t cpuset_mems;
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Paul Menage" <menage@google.com>,
"David Rientjes" <rientjes@google.com>,
"缪 勰" <miaox@cn.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC()
Date: Thu, 17 Feb 2011 14:46:43 -0800 [thread overview]
Message-ID: <20110217144643.0d60bef4.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D5C7ED1.2070601@cn.fujitsu.com>
On Thu, 17 Feb 2011 09:50:09 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> +/*
> + * In functions that can't propogate errno to users, to avoid declaring a
> + * nodemask_t variable, and avoid using NODEMASK_ALLOC that can return
> + * -ENOMEM, we use this global cpuset_mems.
> + *
> + * It should be used with cgroup_lock held.
I'll do s/should/must/ - that would be a nasty bug.
I'd be more comfortable about the maintainability of this optimisation
if we had
WARN_ON(!cgroup_is_locked());
at each site.
> + */
> +static nodemask_t cpuset_mems;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-17 22:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 1:49 [PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist() Li Zefan
2011-02-17 1:49 ` Li Zefan
2011-02-17 1:49 ` [PATCH 2/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_attch() Li Zefan
2011-02-17 1:49 ` Li Zefan
2011-02-17 23:46 ` Paul Menage
2011-02-17 23:46 ` Paul Menage
2011-02-18 2:37 ` Li Zefan
2011-02-18 2:37 ` Li Zefan
2011-02-20 1:51 ` David Rientjes
2011-02-20 1:51 ` David Rientjes
2011-02-17 1:50 ` [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC() Li Zefan
2011-02-17 1:50 ` Li Zefan
2011-02-17 22:46 ` Andrew Morton [this message]
2011-02-17 22:46 ` Andrew Morton
2011-02-17 23:50 ` Paul Menage
2011-02-17 23:50 ` Paul Menage
2011-02-18 2:47 ` Li Zefan
2011-02-18 2:47 ` Li Zefan
2011-02-19 2:28 ` Paul Menage
2011-02-19 2:28 ` Paul Menage
2011-02-20 1:51 ` David Rientjes
2011-02-20 1:51 ` David Rientjes
2011-02-21 3:20 ` Li Zefan
2011-02-21 3:20 ` Li Zefan
2011-02-21 5:30 ` Li Zefan
2011-02-22 0:25 ` David Rientjes
2011-02-22 0:25 ` David Rientjes
2011-02-22 2:15 ` Li Zefan
2011-02-22 2:15 ` Li Zefan
2011-02-22 20:30 ` David Rientjes
2011-02-22 20:30 ` David Rientjes
2011-02-17 1:50 ` [PATCH 4/4] cpuset: Hold callback_mutex in cpuset_clone() Li Zefan
2011-02-17 1:50 ` Li Zefan
2011-02-17 23:51 ` Paul Menage
2011-02-17 23:51 ` Paul Menage
2011-02-20 1:51 ` David Rientjes
2011-02-20 1:51 ` David Rientjes
2011-02-17 23:35 ` [PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist() Paul Menage
2011-02-17 23:35 ` Paul Menage
2011-02-18 2:22 ` Li Zefan
2011-02-18 2:22 ` Li Zefan
2011-02-20 1:51 ` David Rientjes
2011-02-20 1:51 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217144643.0d60bef4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=miaox@cn.fujitsu.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.