[PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Paul Menage" <menage@google.com>,
	"David Rientjes" <rientjes@google.com>,
	"缪 勰" <miaox@cn.fujitsu.com>,
	linux-mm@kvack.org
Subject: [PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist()
Date: Thu, 17 Feb 2011 09:49:27 +0800	[thread overview]
Message-ID: <4D5C7EA7.1030409@cn.fujitsu.com> (raw)

It's not necessary to copy cpuset->mems_allowed to a buffer
allocated by NODEMASK_ALLOC(). Just pass it to nodelist_scnprintf().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/cpuset.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 10f1835..f13ff2e 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1620,20 +1620,12 @@ static int cpuset_sprintf_cpulist(char *page, struct cpuset *cs)
 
 static int cpuset_sprintf_memlist(char *page, struct cpuset *cs)
 {
-	NODEMASK_ALLOC(nodemask_t, mask, GFP_KERNEL);
 	int retval;
 
-	if (mask == NULL)
-		return -ENOMEM;
-
 	mutex_lock(&callback_mutex);
-	*mask = cs->mems_allowed;
+	retval = nodelist_scnprintf(page, PAGE_SIZE, cs->mems_allowed);
 	mutex_unlock(&callback_mutex);
 
-	retval = nodelist_scnprintf(page, PAGE_SIZE, *mask);
-
-	NODEMASK_FREE(mask);
-
 	return retval;
 }
 
-- 
1.7.3.1

WARNING: multiple messages have this Message-ID (diff)

From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Paul Menage" <menage@google.com>,
	"David Rientjes" <rientjes@google.com>,
	"缪 勰" <miaox@cn.fujitsu.com>,
	linux-mm@kvack.org
Subject: [PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist()
Date: Thu, 17 Feb 2011 09:49:27 +0800	[thread overview]
Message-ID: <4D5C7EA7.1030409@cn.fujitsu.com> (raw)

It's not necessary to copy cpuset->mems_allowed to a buffer
allocated by NODEMASK_ALLOC(). Just pass it to nodelist_scnprintf().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/cpuset.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)

diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 10f1835..f13ff2e 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1620,20 +1620,12 @@ static int cpuset_sprintf_cpulist(char *page, struct cpuset *cs)
 
 static int cpuset_sprintf_memlist(char *page, struct cpuset *cs)
 {
-	NODEMASK_ALLOC(nodemask_t, mask, GFP_KERNEL);
 	int retval;
 
-	if (mask == NULL)
-		return -ENOMEM;
-
 	mutex_lock(&callback_mutex);
-	*mask = cs->mems_allowed;
+	retval = nodelist_scnprintf(page, PAGE_SIZE, cs->mems_allowed);
 	mutex_unlock(&callback_mutex);
 
-	retval = nodelist_scnprintf(page, PAGE_SIZE, *mask);
-
-	NODEMASK_FREE(mask);
-
 	return retval;
 }
 
-- 
1.7.3.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

next             reply	other threads:[~2011-02-17  1:48 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17  1:49 Li Zefan [this message]
2011-02-17  1:49 ` [PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist() Li Zefan
2011-02-17  1:49 ` [PATCH 2/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_attch() Li Zefan
2011-02-17  1:49   ` Li Zefan
2011-02-17 23:46   ` Paul Menage
2011-02-17 23:46     ` Paul Menage
2011-02-18  2:37     ` Li Zefan
2011-02-18  2:37       ` Li Zefan
2011-02-20  1:51   ` David Rientjes
2011-02-20  1:51     ` David Rientjes
2011-02-17  1:50 ` [PATCH 3/4] cpuset: Fix unchecked calls to NODEMASK_ALLOC() Li Zefan
2011-02-17  1:50   ` Li Zefan
2011-02-17 22:46   ` Andrew Morton
2011-02-17 22:46     ` Andrew Morton
2011-02-17 23:50     ` Paul Menage
2011-02-17 23:50       ` Paul Menage
2011-02-18  2:47       ` Li Zefan
2011-02-18  2:47         ` Li Zefan
2011-02-19  2:28         ` Paul Menage
2011-02-19  2:28           ` Paul Menage
2011-02-20  1:51   ` David Rientjes
2011-02-20  1:51     ` David Rientjes
2011-02-21  3:20     ` Li Zefan
2011-02-21  3:20       ` Li Zefan
2011-02-21  5:30       ` Li Zefan
2011-02-22  0:25       ` David Rientjes
2011-02-22  0:25         ` David Rientjes
2011-02-22  2:15         ` Li Zefan
2011-02-22  2:15           ` Li Zefan
2011-02-22 20:30           ` David Rientjes
2011-02-22 20:30             ` David Rientjes
2011-02-17  1:50 ` [PATCH 4/4] cpuset: Hold callback_mutex in cpuset_clone() Li Zefan
2011-02-17  1:50   ` Li Zefan
2011-02-17 23:51   ` Paul Menage
2011-02-17 23:51     ` Paul Menage
2011-02-20  1:51   ` David Rientjes
2011-02-20  1:51     ` David Rientjes
2011-02-17 23:35 ` [PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist() Paul Menage
2011-02-17 23:35   ` Paul Menage
2011-02-18  2:22   ` Li Zefan
2011-02-18  2:22     ` Li Zefan
2011-02-20  1:51 ` David Rientjes
2011-02-20  1:51   ` David Rientjes

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:10f1835 dfblob:f13ff2e dfblob:10f1835 dfblob:f13ff2e )
 OR (
bs:"[PATCH 1/4] cpuset: Remove unneeded NODEMASK_ALLOC() in cpuset_sprintf_memlist()" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5C7EA7.1030409@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=miaox@cn.fujitsu.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.