* [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup
@ 2011-03-04 13:32 ` Rajendra Nayak
0 siblings, 0 replies; 6+ messages in thread
From: Rajendra Nayak @ 2011-03-04 13:32 UTC (permalink / raw)
To: linux-omap
Cc: ben-linux, paul, khilman, santosh.shilimkar, linux-arm-kernel,
linux-i2c, Rajendra Nayak
For the I2C module to be wakeup capable, programming I2C_WE
register (which was skipped for OMAP4430) is needed
even on OMAP4.
This fixes i2c controller timeouts which were seen recently
with the static dependency being cleared between MPU and
L4PER clockdomains.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
Patch is based on 2.6.38-rc7 kernel.
drivers/i2c/busses/i2c-omap.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 829a2a1..58a58c7 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -378,9 +378,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
* REVISIT: Some wkup sources might not be needed.
*/
dev->westate = OMAP_I2C_WE_ALL;
- if (dev->rev < OMAP_I2C_REV_ON_4430)
- omap_i2c_write_reg(dev, OMAP_I2C_WE_REG,
- dev->westate);
+ omap_i2c_write_reg(dev, OMAP_I2C_WE_REG, dev->westate);
}
}
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup
@ 2011-03-04 13:32 ` Rajendra Nayak
0 siblings, 0 replies; 6+ messages in thread
From: Rajendra Nayak @ 2011-03-04 13:32 UTC (permalink / raw)
To: linux-arm-kernel
For the I2C module to be wakeup capable, programming I2C_WE
register (which was skipped for OMAP4430) is needed
even on OMAP4.
This fixes i2c controller timeouts which were seen recently
with the static dependency being cleared between MPU and
L4PER clockdomains.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
Patch is based on 2.6.38-rc7 kernel.
drivers/i2c/busses/i2c-omap.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 829a2a1..58a58c7 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -378,9 +378,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
* REVISIT: Some wkup sources might not be needed.
*/
dev->westate = OMAP_I2C_WE_ALL;
- if (dev->rev < OMAP_I2C_REV_ON_4430)
- omap_i2c_write_reg(dev, OMAP_I2C_WE_REG,
- dev->westate);
+ omap_i2c_write_reg(dev, OMAP_I2C_WE_REG, dev->westate);
}
}
omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup
2011-03-04 13:32 ` Rajendra Nayak
@ 2011-03-04 17:00 ` Kevin Hilman
-1 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2011-03-04 17:00 UTC (permalink / raw)
To: Rajendra Nayak, ben-linux
Cc: paul, linux-omap, santosh.shilimkar, linux-i2c, linux-arm-kernel
Rajendra Nayak <rnayak@ti.com> writes:
> For the I2C module to be wakeup capable, programming I2C_WE
> register (which was skipped for OMAP4430) is needed
> even on OMAP4.
> This fixes i2c controller timeouts which were seen recently
> with the static dependency being cleared between MPU and
> L4PER clockdomains.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> ---
> Patch is based on 2.6.38-rc7 kernel.
Acked-by: Kevin Hilman <khilman@ti.com>
Ben, looks like another fix that should be queued for 2.6.38-rc.
Thanks,
Kevin
>
> drivers/i2c/busses/i2c-omap.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 829a2a1..58a58c7 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -378,9 +378,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
> * REVISIT: Some wkup sources might not be needed.
> */
> dev->westate = OMAP_I2C_WE_ALL;
> - if (dev->rev < OMAP_I2C_REV_ON_4430)
> - omap_i2c_write_reg(dev, OMAP_I2C_WE_REG,
> - dev->westate);
> + omap_i2c_write_reg(dev, OMAP_I2C_WE_REG, dev->westate);
> }
> }
> omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup
@ 2011-03-04 17:00 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2011-03-04 17:00 UTC (permalink / raw)
To: linux-arm-kernel
Rajendra Nayak <rnayak@ti.com> writes:
> For the I2C module to be wakeup capable, programming I2C_WE
> register (which was skipped for OMAP4430) is needed
> even on OMAP4.
> This fixes i2c controller timeouts which were seen recently
> with the static dependency being cleared between MPU and
> L4PER clockdomains.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> ---
> Patch is based on 2.6.38-rc7 kernel.
Acked-by: Kevin Hilman <khilman@ti.com>
Ben, looks like another fix that should be queued for 2.6.38-rc.
Thanks,
Kevin
>
> drivers/i2c/busses/i2c-omap.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 829a2a1..58a58c7 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -378,9 +378,7 @@ static int omap_i2c_init(struct omap_i2c_dev *dev)
> * REVISIT: Some wkup sources might not be needed.
> */
> dev->westate = OMAP_I2C_WE_ALL;
> - if (dev->rev < OMAP_I2C_REV_ON_4430)
> - omap_i2c_write_reg(dev, OMAP_I2C_WE_REG,
> - dev->westate);
> + omap_i2c_write_reg(dev, OMAP_I2C_WE_REG, dev->westate);
> }
> }
> omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, 0);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup
2011-03-04 17:00 ` Kevin Hilman
@ 2011-03-04 17:17 ` Ben Dooks
-1 siblings, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2011-03-04 17:17 UTC (permalink / raw)
To: Kevin Hilman
Cc: Rajendra Nayak, ben-linux-elnMNo+KYs3YtjvyW6yDsg,
linux-omap-u79uwXL29TY76Z2rM5mHXA, paul-DWxLp4Yu+b8AvxtiuMwx3w,
santosh.shilimkar-l0cyMroinI0,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Fri, Mar 04, 2011 at 09:00:00AM -0800, Kevin Hilman wrote:
> Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org> writes:
>
> > For the I2C module to be wakeup capable, programming I2C_WE
> > register (which was skipped for OMAP4430) is needed
> > even on OMAP4.
> > This fixes i2c controller timeouts which were seen recently
> > with the static dependency being cleared between MPU and
> > L4PER clockdomains.
> >
> > Signed-off-by: Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org>
> > ---
> > Patch is based on 2.6.38-rc7 kernel.
>
> Acked-by: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
>
> Ben, looks like another fix that should be queued for 2.6.38-rc.
I'll put together the couple of fixes I've got and send them to Linus
at the end of the weekend.
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup
@ 2011-03-04 17:17 ` Ben Dooks
0 siblings, 0 replies; 6+ messages in thread
From: Ben Dooks @ 2011-03-04 17:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 04, 2011 at 09:00:00AM -0800, Kevin Hilman wrote:
> Rajendra Nayak <rnayak@ti.com> writes:
>
> > For the I2C module to be wakeup capable, programming I2C_WE
> > register (which was skipped for OMAP4430) is needed
> > even on OMAP4.
> > This fixes i2c controller timeouts which were seen recently
> > with the static dependency being cleared between MPU and
> > L4PER clockdomains.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> > ---
> > Patch is based on 2.6.38-rc7 kernel.
>
> Acked-by: Kevin Hilman <khilman@ti.com>
>
> Ben, looks like another fix that should be queued for 2.6.38-rc.
I'll put together the couple of fixes I've got and send them to Linus
at the end of the weekend.
--
Ben Dooks, ben at fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-04 17:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-04 13:32 [PATCH] i2c-omap: Program I2C_WE on OMAP4 to enable i2c wakeup Rajendra Nayak
2011-03-04 13:32 ` Rajendra Nayak
2011-03-04 17:00 ` Kevin Hilman
2011-03-04 17:00 ` Kevin Hilman
[not found] ` <87ei6mizxr.fsf-l0cyMroinI0@public.gmane.org>
2011-03-04 17:17 ` Ben Dooks
2011-03-04 17:17 ` Ben Dooks
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.