From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, Mel Gorman <mel@linux.vnet.ibm.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Wu Fengguang <fengguang.wu@intel.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Itaru Kitayama <kitayama@cl.bb4u.ne.jp>
Cc: Minchan Kim <minchan.kim@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: <linux-fsdevel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [PATCH 6/6] NFS: return -EAGAIN when skipped commit in nfs_commit_unstable_pages()
Date: Tue, 19 Apr 2011 11:00:09 +0800 [thread overview]
Message-ID: <20110419030532.902141228@intel.com> (raw)
In-Reply-To: 20110419030003.108796967@intel.com
[-- Attachment #1: nfs-fix-write_inode-retval.patch --]
[-- Type: text/plain, Size: 701 bytes --]
It's probably not sane to return success while redirtying the inode at
the same time in ->write_inode().
CC: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
fs/nfs/write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next.orig/fs/nfs/write.c 2011-04-19 10:18:16.000000000 +0800
+++ linux-next/fs/nfs/write.c 2011-04-19 10:18:32.000000000 +0800
@@ -1519,7 +1519,7 @@ static int nfs_commit_unstable_pages(str
{
struct nfs_inode *nfsi = NFS_I(inode);
int flags = FLUSH_SYNC;
- int ret = 0;
+ int ret = -EAGAIN;
if (wbc->sync_mode == WB_SYNC_NONE) {
/* Don't commit yet if this is a non-blocking flush and there
WARNING: multiple messages have this Message-ID (diff)
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>, Mel Gorman <mel@linux.vnet.ibm.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Wu Fengguang <fengguang.wu@intel.com>,
Dave Chinner <david@fromorbit.com>,
Itaru Kitayama <kitayama@cl.bb4u.ne.jp>,
Minchan Kim <minchan.kim@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [PATCH 6/6] NFS: return -EAGAIN when skipped commit in nfs_commit_unstable_pages()
Date: Tue, 19 Apr 2011 11:00:09 +0800 [thread overview]
Message-ID: <20110419030532.902141228@intel.com> (raw)
In-Reply-To: 20110419030003.108796967@intel.com
[-- Attachment #1: nfs-fix-write_inode-retval.patch --]
[-- Type: text/plain, Size: 1004 bytes --]
It's probably not sane to return success while redirtying the inode at
the same time in ->write_inode().
CC: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
fs/nfs/write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next.orig/fs/nfs/write.c 2011-04-19 10:18:16.000000000 +0800
+++ linux-next/fs/nfs/write.c 2011-04-19 10:18:32.000000000 +0800
@@ -1519,7 +1519,7 @@ static int nfs_commit_unstable_pages(str
{
struct nfs_inode *nfsi = NFS_I(inode);
int flags = FLUSH_SYNC;
- int ret = 0;
+ int ret = -EAGAIN;
if (wbc->sync_mode == WB_SYNC_NONE) {
/* Don't commit yet if this is a non-blocking flush and there
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-19 3:10 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 3:00 [PATCH 0/6] writeback: moving expire targets for background/kupdate works Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` [PATCH 1/6] writeback: pass writeback_control down to move_expired_inodes() Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` [PATCH 2/6] writeback: the kupdate expire timestamp should be a moving target Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 7:02 ` Dave Chinner
2011-04-19 7:02 ` Dave Chinner
2011-04-19 7:20 ` Wu Fengguang
2011-04-19 7:20 ` Wu Fengguang
2011-04-19 9:31 ` Jan Kara
2011-04-19 9:31 ` Jan Kara
2011-04-19 3:00 ` [PATCH 3/6] writeback: sync expired inodes first in background writeback Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 7:35 ` Dave Chinner
2011-04-19 7:35 ` Dave Chinner
2011-04-19 9:57 ` Jan Kara
2011-04-19 9:57 ` Jan Kara
2011-04-19 12:56 ` Wu Fengguang
2011-04-19 13:46 ` Wu Fengguang
2011-04-19 13:46 ` Wu Fengguang
2011-04-20 1:21 ` Dave Chinner
2011-04-20 1:21 ` Dave Chinner
2011-04-20 2:53 ` Wu Fengguang
2011-04-20 2:53 ` Wu Fengguang
2011-04-21 0:45 ` Dave Chinner
2011-04-21 0:45 ` Dave Chinner
2011-04-21 2:06 ` Wu Fengguang
2011-04-21 2:06 ` Wu Fengguang
2011-04-21 3:01 ` Dave Chinner
2011-04-21 3:01 ` Dave Chinner
2011-04-21 3:59 ` Wu Fengguang
2011-04-21 3:59 ` Wu Fengguang
2011-04-21 4:10 ` Wu Fengguang
2011-04-21 4:10 ` Wu Fengguang
2011-04-21 4:36 ` Christoph Hellwig
2011-04-21 4:36 ` Christoph Hellwig
2011-04-21 6:36 ` Dave Chinner
2011-04-21 6:36 ` Dave Chinner
2011-04-21 16:04 ` Jan Kara
2011-04-21 16:04 ` Jan Kara
2011-04-22 2:24 ` Wu Fengguang
2011-04-22 2:24 ` Wu Fengguang
2011-04-22 21:12 ` Jan Kara
2011-04-22 21:12 ` Jan Kara
2011-04-26 5:37 ` Wu Fengguang
2011-04-26 5:37 ` Wu Fengguang
2011-04-26 14:30 ` Jan Kara
2011-04-26 14:30 ` Jan Kara
2011-04-20 7:38 ` Wu Fengguang
2011-04-20 7:38 ` Wu Fengguang
2011-04-21 1:01 ` Dave Chinner
2011-04-21 1:01 ` Dave Chinner
2011-04-21 1:47 ` Wu Fengguang
2011-04-21 1:47 ` Wu Fengguang
2011-04-19 3:00 ` [PATCH 4/6] writeback: introduce writeback_control.inodes_cleaned Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 9:47 ` Jan Kara
2011-04-19 9:47 ` Jan Kara
2011-04-19 3:00 ` [PATCH 5/6] writeback: try more writeback as long as something was written Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 3:00 ` Wu Fengguang
2011-04-19 10:20 ` Jan Kara
2011-04-19 10:20 ` Jan Kara
2011-04-19 11:16 ` Wu Fengguang
2011-04-19 11:16 ` Wu Fengguang
2011-04-19 21:10 ` Jan Kara
2011-04-19 21:10 ` Jan Kara
2011-04-20 7:50 ` Wu Fengguang
2011-04-20 7:50 ` Wu Fengguang
2011-04-20 15:22 ` Jan Kara
2011-04-20 15:22 ` Jan Kara
2011-04-21 3:33 ` Wu Fengguang
2011-04-21 4:39 ` Christoph Hellwig
2011-04-21 4:39 ` Christoph Hellwig
2011-04-21 6:05 ` Wu Fengguang
2011-04-21 6:05 ` Wu Fengguang
2011-04-21 16:41 ` Jan Kara
2011-04-21 16:41 ` Jan Kara
2011-04-22 2:32 ` Wu Fengguang
2011-04-22 2:32 ` Wu Fengguang
2011-04-22 21:23 ` Jan Kara
2011-04-22 21:23 ` Jan Kara
2011-04-21 7:09 ` Dave Chinner
2011-04-21 7:09 ` Dave Chinner
2011-04-21 7:14 ` Christoph Hellwig
2011-04-21 7:14 ` Christoph Hellwig
2011-04-21 7:52 ` Dave Chinner
2011-04-21 7:52 ` Dave Chinner
2011-04-21 8:00 ` Christoph Hellwig
2011-04-21 8:00 ` Christoph Hellwig
2011-04-19 3:00 ` Wu Fengguang [this message]
2011-04-19 3:00 ` [PATCH 6/6] NFS: return -EAGAIN when skipped commit in nfs_commit_unstable_pages() Wu Fengguang
2011-04-19 3:29 ` Trond Myklebust
2011-04-19 3:29 ` Trond Myklebust
2011-04-19 3:55 ` Wu Fengguang
2011-04-19 3:55 ` Wu Fengguang
2011-04-21 4:40 ` Christoph Hellwig
2011-04-21 4:40 ` Christoph Hellwig
2011-04-19 6:38 ` [PATCH 0/6] writeback: moving expire targets for background/kupdate works Dave Chinner
2011-04-19 6:38 ` Dave Chinner
2011-04-19 8:02 ` Wu Fengguang
2011-04-19 8:02 ` Wu Fengguang
2011-04-21 4:34 ` Christoph Hellwig
2011-04-21 4:34 ` Christoph Hellwig
2011-04-21 5:50 ` Wu Fengguang
2011-04-21 5:50 ` Wu Fengguang
2011-04-21 5:56 ` Christoph Hellwig
2011-04-21 5:56 ` Christoph Hellwig
2011-04-21 6:07 ` Wu Fengguang
2011-04-21 6:07 ` Wu Fengguang
2011-04-21 7:17 ` Christoph Hellwig
2011-04-21 7:17 ` Christoph Hellwig
2011-04-21 10:15 ` Wu Fengguang
2011-04-21 10:15 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419030532.902141228@intel.com \
--to=fengguang.wu@intel.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=mel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.