Re: [PATCH 1/7] ASoC: Fix cards getting stuck in a powered state.

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Apr 28, 2011 at 09:47:12PM +0200, Lars-Peter Clausen wrote:
> On 04/28/2011 09:15 PM, Mark Brown wrote:

> > For CODECs we can easily add some widgets for them based on the DAI, for
> > cards we should just shove a random widget in there with the name of the
> > card, it doesn't need to be wired up to anything.

> For codecs we can use SND_SOC_DAPM_AIF_{IN,OUT} widgets.

Quite, but they do also need to be connected to outputs and inputs so
that they're part of complete paths.

> I don't understand you comment regarding cards though. It does not make sense
> to add a random widget which is not connected anywhere, since it either would
> have no effect or keep the card power up.

It minimises the risk of some other unexpected behaviour being noticed,
hopefully it's not needed but equally well if it's not needed it won't
do any harm and if it is needed it's obviously helpful.

> If we drop that special casing, we can handle widget-less context just fine,
> with the assumption that they don't need to be powered.

That's what's *supposed* to happen, certainly.