Re: [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter

[Lars-Peter Clausen <lars@metafoo.de>]

On 04/29/2011 12:23 AM, Mark Brown wrote:
> On Thu, Apr 28, 2011 at 11:18:00PM +0100, Mark Brown wrote:
>> On Fri, Apr 29, 2011 at 12:04:04AM +0200, Lars-Peter Clausen wrote:
>>> On 04/28/2011 11:48 PM, Mark Brown wrote:
> 
>>>> Moving to the card doesn't seem helpful, while we're currently doing one
>>>> update at once it's not immediately obvious that we want to keep doing
>>>> that indefinitely.
> 
>>> But keeping it in the dapm context would limit us to one update per context
>>> which doesn't seem very sustainable either.
> 
>> Though for global state changes like this that's pretty much irrelevant
>> as we need to walk the entire graph at once.
> 
> BTW, this means that my above comment was too hasty; I can't actually
> see a situation where we'd ever want to have multiple updates in flight.
> Though I also don't immediately see a need to move as the update gets
> applied to a specific context anyway ...

If we'd keep the update in the dapm context we'd have to iterate over all
contexts to find the one context which contains the update.
As you've said we have to walk the whole graph and it does not make a nice
interface if the function takes one specific dapm context while it works on the
whole card.

Currently we get the codec from the widget for which the update is run and not
from the dapm context anyway.

- Lars