From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/7] ASoC: Fix cards getting stuck in a powered state.
Date: Fri, 29 Apr 2011 00:17:29 +0100 [thread overview]
Message-ID: <20110428231728.GA11593@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4DB9F4B8.20602@metafoo.de>
On Fri, Apr 29, 2011 at 01:14:00AM +0200, Lars-Peter Clausen wrote:
> I know this isn't optimal, but would it be accepable to have a
> SND_SOC_DAPM_STREAM(sname) widget, where the power_check function would just
> consider stream's state, so we can get rid of the special casing without having
> to mess with the codec drivers to much?
I was expecting that the core would just autogenerate some widgets for
the streams if it saw a CODEC appearing with no widgets in its context
after probe. No code change to the CODEC drivers at all.
In principle a stream widget is fine, but you'd need ones for capture
and playback paths and they'd need to also function as pins so they can
be joined up with the outside world (which now we have multi-component
is a big reason to push back on things that don't do DAPM; it's not
purely about the annoyance of having to bodge around them).
next prev parent reply other threads:[~2011-04-28 23:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 16:46 [PATCH 1/7] ASoC: Fix cards getting stuck in a powered state Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter Lars-Peter Clausen
2011-04-28 19:40 ` Mark Brown
2011-04-28 20:39 ` Lars-Peter Clausen
2011-04-28 20:58 ` Mark Brown
2011-04-28 21:24 ` Lars-Peter Clausen
2011-04-28 21:48 ` Mark Brown
2011-04-28 22:04 ` Lars-Peter Clausen
2011-04-28 22:18 ` Mark Brown
2011-04-28 22:23 ` Mark Brown
2011-04-28 22:34 ` Lars-Peter Clausen
2011-04-28 22:48 ` Mark Brown
2011-04-28 22:58 ` Lars-Peter Clausen
2011-04-28 22:59 ` Mark Brown
2011-04-28 16:46 ` [PATCH 3/7] ASoC: Drop unused parameter from dapm_seq_run Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 4/7] ASoC: Pass snd_soc_card instead of snd_soc_dapm_context were appropriate Lars-Peter Clausen
2011-04-28 19:47 ` Mark Brown
2011-04-28 20:13 ` Mark Brown
2011-04-28 16:46 ` [PATCH 5/7] ASoC: Move DAPM debugfs directory creation to snd_soc_dapm_debugfs_init Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 6/7] ASoC: Move DAPM widget debugfs entry creation to snd_soc_dapm_new_widgets Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 7/7] ASoC: Instantiate all DAPM widgets at once Lars-Peter Clausen
2011-04-28 20:07 ` Mark Brown
2011-04-28 20:25 ` Lars-Peter Clausen
2011-04-28 21:18 ` Mark Brown
2011-04-28 19:15 ` [PATCH 1/7] ASoC: Fix cards getting stuck in a powered state Mark Brown
2011-04-28 19:47 ` Lars-Peter Clausen
2011-04-28 19:52 ` Mark Brown
2011-04-28 23:14 ` Lars-Peter Clausen
2011-04-28 23:17 ` Mark Brown [this message]
2011-04-28 23:40 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428231728.GA11593@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.