From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter
Date: Thu, 28 Apr 2011 23:48:17 +0100 [thread overview]
Message-ID: <20110428224817.GA11103@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4DB9EB63.5020007@metafoo.de>
On Fri, Apr 29, 2011 at 12:34:11AM +0200, Lars-Peter Clausen wrote:
> If we'd keep the update in the dapm context we'd have to iterate over all
> contexts to find the one context which contains the update.
> As you've said we have to walk the whole graph and it does not make a nice
> interface if the function takes one specific dapm context while it works on the
> whole card.
So that's part of a separate refactoring and only applies if we're not
running DAPM in a particular context and should be something along the
lines of "now we pass the card in it's much more sensible to..."; I'm
writing this while looking at current code.
> Currently we get the codec from the widget for which the update is run and not
> from the dapm context anyway.
That's just a redundancy in the data structure; the codec and context
are just two different ways of getting to the same thing.
next prev parent reply other threads:[~2011-04-28 22:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 16:46 [PATCH 1/7] ASoC: Fix cards getting stuck in a powered state Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 2/7] ASoC: DAPM: Pass snd_dapm_soc_update as parameter Lars-Peter Clausen
2011-04-28 19:40 ` Mark Brown
2011-04-28 20:39 ` Lars-Peter Clausen
2011-04-28 20:58 ` Mark Brown
2011-04-28 21:24 ` Lars-Peter Clausen
2011-04-28 21:48 ` Mark Brown
2011-04-28 22:04 ` Lars-Peter Clausen
2011-04-28 22:18 ` Mark Brown
2011-04-28 22:23 ` Mark Brown
2011-04-28 22:34 ` Lars-Peter Clausen
2011-04-28 22:48 ` Mark Brown [this message]
2011-04-28 22:58 ` Lars-Peter Clausen
2011-04-28 22:59 ` Mark Brown
2011-04-28 16:46 ` [PATCH 3/7] ASoC: Drop unused parameter from dapm_seq_run Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 4/7] ASoC: Pass snd_soc_card instead of snd_soc_dapm_context were appropriate Lars-Peter Clausen
2011-04-28 19:47 ` Mark Brown
2011-04-28 20:13 ` Mark Brown
2011-04-28 16:46 ` [PATCH 5/7] ASoC: Move DAPM debugfs directory creation to snd_soc_dapm_debugfs_init Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 6/7] ASoC: Move DAPM widget debugfs entry creation to snd_soc_dapm_new_widgets Lars-Peter Clausen
2011-04-28 16:46 ` [PATCH 7/7] ASoC: Instantiate all DAPM widgets at once Lars-Peter Clausen
2011-04-28 20:07 ` Mark Brown
2011-04-28 20:25 ` Lars-Peter Clausen
2011-04-28 21:18 ` Mark Brown
2011-04-28 19:15 ` [PATCH 1/7] ASoC: Fix cards getting stuck in a powered state Mark Brown
2011-04-28 19:47 ` Lars-Peter Clausen
2011-04-28 19:52 ` Mark Brown
2011-04-28 23:14 ` Lars-Peter Clausen
2011-04-28 23:17 ` Mark Brown
2011-04-28 23:40 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110428224817.GA11103@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.