From: Joel Becker <jlbec@evilplan.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Allison Henderson <achender@linux.vnet.ibm.com>,
xfs-oss <xfs@oss.sgi.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Eric Sandeen <sandeen@redhat.com>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
Date: Wed, 18 May 2011 18:41:51 -0700 [thread overview]
Message-ID: <20110519014149.GA11278@noexit.corp.google.com> (raw)
In-Reply-To: <20110519013144.GF32466@dastard>
On Thu, May 19, 2011 at 11:31:44AM +1000, Dave Chinner wrote:
> > +#
> > +# This test is successful when the following conditions are met:
> > +# - ls shows that the number of blocks occupied by the file
> > +# has decreased by the number of blocks punched out.
>
> There's no guarantee that a filesystem will punch the number of
> blocks you expect.
Cluster allocated filesystems like ocfs2 are certainly going to
punch some multiple of clusters, not exact blocks. Eg if the hole is
punched in the middle of a cluster.
Joel
--
Life's Little Instruction Book #464
"Don't miss the magic of the moment by focusing on what's
to come."
http://www.jlbec.org/
jlbec@evilplan.org
WARNING: multiple messages have this Message-ID (diff)
From: Joel Becker <jlbec@evilplan.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>, Eric Sandeen <sandeen@redhat.com>,
Allison Henderson <achender@linux.vnet.ibm.com>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
Date: Wed, 18 May 2011 18:41:51 -0700 [thread overview]
Message-ID: <20110519014149.GA11278@noexit.corp.google.com> (raw)
In-Reply-To: <20110519013144.GF32466@dastard>
On Thu, May 19, 2011 at 11:31:44AM +1000, Dave Chinner wrote:
> > +#
> > +# This test is successful when the following conditions are met:
> > +# - ls shows that the number of blocks occupied by the file
> > +# has decreased by the number of blocks punched out.
>
> There's no guarantee that a filesystem will punch the number of
> blocks you expect.
Cluster allocated filesystems like ocfs2 are certainly going to
punch some multiple of clusters, not exact blocks. Eg if the hole is
punched in the middle of a cluster.
Joel
--
Life's Little Instruction Book #464
"Don't miss the magic of the moment by focusing on what's
to come."
http://www.jlbec.org/
jlbec@evilplan.org
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-05-19 1:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 20:58 [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines Allison Henderson
2011-05-18 20:58 ` Allison Henderson
2011-05-19 1:31 ` Dave Chinner
2011-05-19 1:31 ` Dave Chinner
2011-05-19 1:41 ` Joel Becker [this message]
2011-05-19 1:41 ` Joel Becker
2011-05-19 18:26 ` Allison Henderson
2011-05-19 18:26 ` Allison Henderson
2011-05-19 23:36 ` Sunil Mushran
2011-05-19 23:36 ` Sunil Mushran
2011-05-19 23:56 ` Dave Chinner
2011-05-19 23:56 ` Dave Chinner
2011-05-20 1:22 ` Allison Henderson
2011-05-20 1:22 ` Allison Henderson
2011-05-21 0:46 ` Allison Henderson
2011-05-21 0:46 ` Allison Henderson
2011-05-21 3:57 ` Dave Chinner
2011-05-21 3:57 ` Dave Chinner
2011-05-21 4:55 ` Allison Henderson
2011-05-21 4:55 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519014149.GA11278@noexit.corp.google.com \
--to=jlbec@evilplan.org \
--cc=achender@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.