All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Eric Sandeen <sandeen@redhat.com>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
Date: Sat, 21 May 2011 13:57:04 +1000	[thread overview]
Message-ID: <20110521035704.GW32466@dastard> (raw)
In-Reply-To: <4DD70B5B.6090400@linux.vnet.ibm.com>

On Fri, May 20, 2011 at 05:46:19PM -0700, Allison Henderson wrote:
> On 5/19/2011 6:22 PM, Allison Henderson wrote:
> >Also, there was one more test that I meant to be a part of this
> >collection, but I was not finished with it at the time I submitted the
> >patch for feedback. Basically it checks to see if a hole can still be
> >punched out when the disk is full. In ext4 this is allowable because
> >reserved space is used to allow the operation to proceed where it would
> >have otherwise failed. I'm not sure if this is also ext4 specific
> >though. Would this be another candidate for adding to 252? Thx!
> 
> I just didnt want this question to get washed away in the traffic.
> I am working on an updated patch set, should I include the extra
> test case?  Thx!

Yes, though probably not in the _generic_test_punch function. And
extra case specific to 252 that does something like:

	umount SCRATCH_DEV
	make a small filesystem
	scratch_mount
	prealloc to ENOSPC
	punch


Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Eric Sandeen <sandeen@redhat.com>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	xfs-oss <xfs@oss.sgi.com>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
Date: Sat, 21 May 2011 13:57:04 +1000	[thread overview]
Message-ID: <20110521035704.GW32466@dastard> (raw)
In-Reply-To: <4DD70B5B.6090400@linux.vnet.ibm.com>

On Fri, May 20, 2011 at 05:46:19PM -0700, Allison Henderson wrote:
> On 5/19/2011 6:22 PM, Allison Henderson wrote:
> >Also, there was one more test that I meant to be a part of this
> >collection, but I was not finished with it at the time I submitted the
> >patch for feedback. Basically it checks to see if a hole can still be
> >punched out when the disk is full. In ext4 this is allowable because
> >reserved space is used to allow the operation to proceed where it would
> >have otherwise failed. I'm not sure if this is also ext4 specific
> >though. Would this be another candidate for adding to 252? Thx!
> 
> I just didnt want this question to get washed away in the traffic.
> I am working on an updated patch set, should I include the extra
> test case?  Thx!

Yes, though probably not in the _generic_test_punch function. And
extra case specific to 252 that does something like:

	umount SCRATCH_DEV
	make a small filesystem
	scratch_mount
	prealloc to ENOSPC
	punch


Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-05-21  3:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 20:58 [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines Allison Henderson
2011-05-18 20:58 ` Allison Henderson
2011-05-19  1:31 ` Dave Chinner
2011-05-19  1:31   ` Dave Chinner
2011-05-19  1:41   ` Joel Becker
2011-05-19  1:41     ` Joel Becker
2011-05-19 18:26   ` Allison Henderson
2011-05-19 18:26     ` Allison Henderson
2011-05-19 23:36     ` Sunil Mushran
2011-05-19 23:36       ` Sunil Mushran
2011-05-19 23:56     ` Dave Chinner
2011-05-19 23:56       ` Dave Chinner
2011-05-20  1:22       ` Allison Henderson
2011-05-20  1:22         ` Allison Henderson
2011-05-21  0:46         ` Allison Henderson
2011-05-21  0:46           ` Allison Henderson
2011-05-21  3:57           ` Dave Chinner [this message]
2011-05-21  3:57             ` Dave Chinner
2011-05-21  4:55             ` Allison Henderson
2011-05-21  4:55               ` Allison Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110521035704.GW32466@dastard \
    --to=david@fromorbit.com \
    --cc=achender@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.