From: Sunil Mushran <sunil.mushran@oracle.com>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: Dave Chinner <david@fromorbit.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Eric Sandeen <sandeen@redhat.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>, Mark Fasheh <mfasheh@suse.com>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
Date: Thu, 19 May 2011 16:36:34 -0700 [thread overview]
Message-ID: <4DD5A982.9090907@oracle.com> (raw)
In-Reply-To: <4DD560CF.3040706@linux.vnet.ibm.com>
On 05/19/2011 11:26 AM, Allison Henderson wrote:
> Thx for the all the reviewing on this one. Im not quite sure I agree that the tests are analogous though. I did some poking around in xfsprogs which I believe is what test 252 is using to do perform most of its operations. I found the code where the hole gets punched, but I didnt find any code that does any kind of analyzing to verify that the hole was punched correctly. Maybe I over looked it? It kinda looks like the hole gets punched and it just checks the return code (fpunch_f in io/prealloc.c right?).
>
Mark Fasheh wrote a test for the same for ocfs2 that might help. Check it out.
http://oss.oracle.com/git/?p=ocfs2-test.git;a=tree;f=programs/fill_verify_holes;h=0df38895e7ff6e66a9a558f35407699ebb40f790;hb=HEAD
WARNING: multiple messages have this Message-ID (diff)
From: Sunil Mushran <sunil.mushran@oracle.com>
To: Allison Henderson <achender@linux.vnet.ibm.com>
Cc: Eric Sandeen <sandeen@redhat.com>, Mark Fasheh <mfasheh@suse.com>,
xfs-oss <xfs@oss.sgi.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
Date: Thu, 19 May 2011 16:36:34 -0700 [thread overview]
Message-ID: <4DD5A982.9090907@oracle.com> (raw)
In-Reply-To: <4DD560CF.3040706@linux.vnet.ibm.com>
On 05/19/2011 11:26 AM, Allison Henderson wrote:
> Thx for the all the reviewing on this one. Im not quite sure I agree that the tests are analogous though. I did some poking around in xfsprogs which I believe is what test 252 is using to do perform most of its operations. I found the code where the hole gets punched, but I didnt find any code that does any kind of analyzing to verify that the hole was punched correctly. Maybe I over looked it? It kinda looks like the hole gets punched and it just checks the return code (fpunch_f in io/prealloc.c right?).
>
Mark Fasheh wrote a test for the same for ocfs2 that might help. Check it out.
http://oss.oracle.com/git/?p=ocfs2-test.git;a=tree;f=programs/fill_verify_holes;h=0df38895e7ff6e66a9a558f35407699ebb40f790;hb=HEAD
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-05-19 23:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 20:58 [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines Allison Henderson
2011-05-18 20:58 ` Allison Henderson
2011-05-19 1:31 ` Dave Chinner
2011-05-19 1:31 ` Dave Chinner
2011-05-19 1:41 ` Joel Becker
2011-05-19 1:41 ` Joel Becker
2011-05-19 18:26 ` Allison Henderson
2011-05-19 18:26 ` Allison Henderson
2011-05-19 23:36 ` Sunil Mushran [this message]
2011-05-19 23:36 ` Sunil Mushran
2011-05-19 23:56 ` Dave Chinner
2011-05-19 23:56 ` Dave Chinner
2011-05-20 1:22 ` Allison Henderson
2011-05-20 1:22 ` Allison Henderson
2011-05-21 0:46 ` Allison Henderson
2011-05-21 0:46 ` Allison Henderson
2011-05-21 3:57 ` Dave Chinner
2011-05-21 3:57 ` Dave Chinner
2011-05-21 4:55 ` Allison Henderson
2011-05-21 4:55 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD5A982.9090907@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=achender@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.