* [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-12 8:45 ` Maarten Lankhorst 0 siblings, 0 replies; 14+ messages in thread From: Maarten Lankhorst @ 2011-06-12 8:45 UTC (permalink / raw) To: Peter Jones; +Cc: linux-fbdev, linux-kernel, Maarten Lankhorst Seems like driver_unregister must be called instead of device_unregister. Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..d8717a6 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_driver_unregister(&efifb_driver); return ret; } -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-12 8:45 ` Maarten Lankhorst 0 siblings, 0 replies; 14+ messages in thread From: Maarten Lankhorst @ 2011-06-12 8:45 UTC (permalink / raw) To: Peter Jones; +Cc: linux-fbdev, linux-kernel, Maarten Lankhorst Seems like driver_unregister must be called instead of device_unregister. Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..d8717a6 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_driver_unregister(&efifb_driver); return ret; } -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* re:[PATCH] efifb: Fix call to wrong unregister function @ 2011-06-12 10:52 ` wanlong.gao 0 siblings, 0 replies; 14+ messages in thread From: wanlong.gao @ 2011-06-12 10:52 UTC (permalink / raw) To: linux-kernel, linux-fbdev; +Cc: Maarten Lankhorst <snip> Hi Maarten: It registered efifb_device but try to unregistered efifb_driver, so I think you should fix it like this? Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com> --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..784139a 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_device_unregister(&efifb_device); return ret; } -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* re:[PATCH] efifb: Fix call to wrong unregister function @ 2011-06-12 10:52 ` wanlong.gao 0 siblings, 0 replies; 14+ messages in thread From: wanlong.gao @ 2011-06-12 10:52 UTC (permalink / raw) To: linux-kernel, linux-fbdev Cc: Maarten Lankhorst, Maarten Lankhorst, Peter Jones <snip> Hi Maarten: It registered efifb_device but try to unregistered efifb_driver, so I think you should fix it like this? Signed-off-by: Wanlong Gao <wanlong.gao@gmail.com> --- drivers/video/efifb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c index 69c49df..784139a 100644 --- a/drivers/video/efifb.c +++ b/drivers/video/efifb.c @@ -541,7 +541,7 @@ static int __init efifb_init(void) */ ret = platform_driver_probe(&efifb_driver, efifb_probe); if (ret) { - platform_device_unregister(&efifb_driver); + platform_device_unregister(&efifb_device); return ret; } -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function 2011-06-12 10:52 ` wanlong.gao @ 2011-06-12 17:48 ` Maarten Lankhorst -1 siblings, 0 replies; 14+ messages in thread From: Maarten Lankhorst @ 2011-06-12 17:48 UTC (permalink / raw) To: wanlong.gao; +Cc: linux-kernel, linux-fbdev, Peter Jones Hey, 2011/6/12 wanlong.gao <wanlong.gao@gmail.com>: > <snip> > > Hi Maarten: > It registered efifb_device but try to unregistered efifb_driver, > so I think you should fix it like this? Ah yes, that seems to be the correct one, platform_driver_register was removed. Not 100% sure if acked by or signed-off-by is appropriate here. Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> ~Maarten ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-12 17:48 ` Maarten Lankhorst 0 siblings, 0 replies; 14+ messages in thread From: Maarten Lankhorst @ 2011-06-12 17:48 UTC (permalink / raw) To: wanlong.gao; +Cc: linux-kernel, linux-fbdev, Peter Jones Hey, 2011/6/12 wanlong.gao <wanlong.gao@gmail.com>: > <snip> > > Hi Maarten: > It registered efifb_device but try to unregistered efifb_driver, > so I think you should fix it like this? Ah yes, that seems to be the correct one, platform_driver_register was removed. Not 100% sure if acked by or signed-off-by is appropriate here. Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> ~Maarten ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function 2011-06-12 17:48 ` Maarten Lankhorst @ 2011-06-12 23:36 ` Wanlong Gao -1 siblings, 0 replies; 14+ messages in thread From: Wanlong Gao @ 2011-06-12 23:36 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: linux-kernel, linux-fbdev, Peter Jones On æ—¥, 2011-06-12 at 19:48 +0200, Maarten Lankhorst wrote: > Hey, > > 2011/6/12 wanlong.gao <wanlong.gao@gmail.com>: > > <snip> > > > > Hi Maarten: > > It registered efifb_device but try to unregistered efifb_driver, > > so I think you should fix it like this? > Ah yes, that seems to be the correct one, platform_driver_register was > removed. Not 100% sure if acked by or signed-off-by is appropriate > here. I think signed-off-by is OK. > > Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> > > ~Maarten ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-12 23:36 ` Wanlong Gao 0 siblings, 0 replies; 14+ messages in thread From: Wanlong Gao @ 2011-06-12 23:36 UTC (permalink / raw) To: Maarten Lankhorst; +Cc: linux-kernel, linux-fbdev, Peter Jones On 日, 2011-06-12 at 19:48 +0200, Maarten Lankhorst wrote: > Hey, > > 2011/6/12 wanlong.gao <wanlong.gao@gmail.com>: > > <snip> > > > > Hi Maarten: > > It registered efifb_device but try to unregistered efifb_driver, > > so I think you should fix it like this? > Ah yes, that seems to be the correct one, platform_driver_register was > removed. Not 100% sure if acked by or signed-off-by is appropriate > here. I think signed-off-by is OK. > > Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com> > > ~Maarten ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function 2011-06-12 10:52 ` wanlong.gao @ 2011-06-13 2:55 ` Andy Lutomirski -1 siblings, 0 replies; 14+ messages in thread From: Andy Lutomirski @ 2011-06-13 2:55 UTC (permalink / raw) To: wanlong.gao; +Cc: linux-kernel, linux-fbdev, Maarten Lankhorst, Peter Jones On 06/12/2011 06:52 AM, wanlong.gao wrote: > <snip> > > Hi Maarten: > It registered efifb_device but try to unregistered efifb_driver, > so I think you should fix it like this? > > Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> > --- > drivers/video/efifb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > index 69c49df..784139a 100644 > --- a/drivers/video/efifb.c > +++ b/drivers/video/efifb.c > @@ -541,7 +541,7 @@ static int __init efifb_init(void) > */ > ret = platform_driver_probe(&efifb_driver, efifb_probe); > if (ret) { > - platform_device_unregister(&efifb_driver); > + platform_device_unregister(&efifb_device); > return ret; > } > Acked-by: Andy Lutomirski <luto@mit.edu> That's my bug. Sorry. I'm not sure why it compiled, though. --Andy ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-13 2:55 ` Andy Lutomirski 0 siblings, 0 replies; 14+ messages in thread From: Andy Lutomirski @ 2011-06-13 2:55 UTC (permalink / raw) To: wanlong.gao; +Cc: linux-kernel, linux-fbdev, Maarten Lankhorst, Peter Jones On 06/12/2011 06:52 AM, wanlong.gao wrote: > <snip> > > Hi Maarten: > It registered efifb_device but try to unregistered efifb_driver, > so I think you should fix it like this? > > Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> > --- > drivers/video/efifb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > index 69c49df..784139a 100644 > --- a/drivers/video/efifb.c > +++ b/drivers/video/efifb.c > @@ -541,7 +541,7 @@ static int __init efifb_init(void) > */ > ret = platform_driver_probe(&efifb_driver, efifb_probe); > if (ret) { > - platform_device_unregister(&efifb_driver); > + platform_device_unregister(&efifb_device); > return ret; > } > Acked-by: Andy Lutomirski <luto@mit.edu> That's my bug. Sorry. I'm not sure why it compiled, though. --Andy ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function 2011-06-13 2:55 ` Andy Lutomirski @ 2011-06-13 7:51 ` Maarten Lankhorst -1 siblings, 0 replies; 14+ messages in thread From: Maarten Lankhorst @ 2011-06-13 7:51 UTC (permalink / raw) To: Andy Lutomirski; +Cc: wanlong.gao, linux-kernel, linux-fbdev, Peter Jones Hi Andy, 2011/6/13 Andy Lutomirski <luto@mit.edu>: > On 06/12/2011 06:52 AM, wanlong.gao wrote: >> >> <snip> >> >> Hi Maarten: >> It registered efifb_device but try to unregistered efifb_driver, >> so I think you should fix it like this? >> >> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> >> --- >> drivers/video/efifb.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c >> index 69c49df..784139a 100644 >> --- a/drivers/video/efifb.c >> +++ b/drivers/video/efifb.c >> @@ -541,7 +541,7 @@ static int __init efifb_init(void) >> */ >> ret = platform_driver_probe(&efifb_driver, efifb_probe); >> if (ret) { >> - platform_device_unregister(&efifb_driver); >> + platform_device_unregister(&efifb_device); >> return ret; >> } >> > > Acked-by: Andy Lutomirski <luto@mit.edu> > > That's my bug. Sorry. I'm not sure why it compiled, though. It compiled, but threw a warning. :) ~Maarten ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-13 7:51 ` Maarten Lankhorst 0 siblings, 0 replies; 14+ messages in thread From: Maarten Lankhorst @ 2011-06-13 7:51 UTC (permalink / raw) To: Andy Lutomirski; +Cc: wanlong.gao, linux-kernel, linux-fbdev, Peter Jones Hi Andy, 2011/6/13 Andy Lutomirski <luto@mit.edu>: > On 06/12/2011 06:52 AM, wanlong.gao wrote: >> >> <snip> >> >> Hi Maarten: >> It registered efifb_device but try to unregistered efifb_driver, >> so I think you should fix it like this? >> >> Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> >> --- >> drivers/video/efifb.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c >> index 69c49df..784139a 100644 >> --- a/drivers/video/efifb.c >> +++ b/drivers/video/efifb.c >> @@ -541,7 +541,7 @@ static int __init efifb_init(void) >> */ >> ret = platform_driver_probe(&efifb_driver, efifb_probe); >> if (ret) { >> - platform_device_unregister(&efifb_driver); >> + platform_device_unregister(&efifb_device); >> return ret; >> } >> > > Acked-by: Andy Lutomirski <luto@mit.edu> > > That's my bug. Sorry. I'm not sure why it compiled, though. It compiled, but threw a warning. :) ~Maarten ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function 2011-06-13 2:55 ` Andy Lutomirski @ 2011-06-14 7:33 ` Paul Mundt -1 siblings, 0 replies; 14+ messages in thread From: Paul Mundt @ 2011-06-14 7:33 UTC (permalink / raw) To: Andy Lutomirski Cc: wanlong.gao, linux-kernel, linux-fbdev, Maarten Lankhorst, Peter Jones On Sun, Jun 12, 2011 at 10:55:37PM -0400, Andy Lutomirski wrote: > On 06/12/2011 06:52 AM, wanlong.gao wrote: > ><snip> > > > >Hi Maarten: > >It registered efifb_device but try to unregistered efifb_driver, > >so I think you should fix it like this? > > > >Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> > >--- > > drivers/video/efifb.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > >index 69c49df..784139a 100644 > >--- a/drivers/video/efifb.c > >+++ b/drivers/video/efifb.c > >@@ -541,7 +541,7 @@ static int __init efifb_init(void) > > */ > > ret = platform_driver_probe(&efifb_driver, efifb_probe); > > if (ret) { > >- platform_device_unregister(&efifb_driver); > >+ platform_device_unregister(&efifb_device); > > return ret; > > } > > > > Acked-by: Andy Lutomirski <luto@mit.edu> > Updated version applied, thanks. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] efifb: Fix call to wrong unregister function @ 2011-06-14 7:33 ` Paul Mundt 0 siblings, 0 replies; 14+ messages in thread From: Paul Mundt @ 2011-06-14 7:33 UTC (permalink / raw) To: Andy Lutomirski Cc: wanlong.gao, linux-kernel, linux-fbdev, Maarten Lankhorst, Peter Jones On Sun, Jun 12, 2011 at 10:55:37PM -0400, Andy Lutomirski wrote: > On 06/12/2011 06:52 AM, wanlong.gao wrote: > ><snip> > > > >Hi Maarten: > >It registered efifb_device but try to unregistered efifb_driver, > >so I think you should fix it like this? > > > >Signed-off-by: Wanlong Gao<wanlong.gao@gmail.com> > >--- > > drivers/video/efifb.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c > >index 69c49df..784139a 100644 > >--- a/drivers/video/efifb.c > >+++ b/drivers/video/efifb.c > >@@ -541,7 +541,7 @@ static int __init efifb_init(void) > > */ > > ret = platform_driver_probe(&efifb_driver, efifb_probe); > > if (ret) { > >- platform_device_unregister(&efifb_driver); > >+ platform_device_unregister(&efifb_device); > > return ret; > > } > > > > Acked-by: Andy Lutomirski <luto@mit.edu> > Updated version applied, thanks. ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-06-14 7:33 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-06-12 8:45 [PATCH] efifb: Fix call to wrong unregister function Maarten Lankhorst 2011-06-12 8:45 ` Maarten Lankhorst 2011-06-12 10:52 ` wanlong.gao 2011-06-12 10:52 ` wanlong.gao 2011-06-12 17:48 ` [PATCH] " Maarten Lankhorst 2011-06-12 17:48 ` Maarten Lankhorst 2011-06-12 23:36 ` Wanlong Gao 2011-06-12 23:36 ` Wanlong Gao 2011-06-13 2:55 ` Andy Lutomirski 2011-06-13 2:55 ` Andy Lutomirski 2011-06-13 7:51 ` Maarten Lankhorst 2011-06-13 7:51 ` Maarten Lankhorst 2011-06-14 7:33 ` Paul Mundt 2011-06-14 7:33 ` Paul Mundt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.