From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC
Date: Mon, 20 Jun 2011 11:31:25 +0100 [thread overview]
Message-ID: <20110620103124.GD31864@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTin6hSaNSDd+dEZdkk3F5O5nDYf9yQ@mail.gmail.com>
On Mon, Jun 20, 2011 at 04:58:09PM +0900, MyungJoo Ham wrote:
> However, the MAX8997 driver uses platform_data's entry (variables
> defined in "static struct max8997_platform_data __initdata
> nuri_max8997_pdata)
> in its normal functions other than its probe function, which are often
> called after boot.
That's bad practice on its part.
> I just can't sure whether I should let probe function copy
> platform-data used by non-probe functions to its own local data
This is the best fix.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: myungjoo.ham@gmail.com
Cc: linux-arm-kernel@lists.infradead.org,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, dg77.kim@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC
Date: Mon, 20 Jun 2011 11:31:25 +0100 [thread overview]
Message-ID: <20110620103124.GD31864@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTin6hSaNSDd+dEZdkk3F5O5nDYf9yQ@mail.gmail.com>
On Mon, Jun 20, 2011 at 04:58:09PM +0900, MyungJoo Ham wrote:
> However, the MAX8997 driver uses platform_data's entry (variables
> defined in "static struct max8997_platform_data __initdata
> nuri_max8997_pdata)
> in its normal functions other than its probe function, which are often
> called after boot.
That's bad practice on its part.
> I just can't sure whether I should let probe function copy
> platform-data used by non-probe functions to its own local data
This is the best fix.
next prev parent reply other threads:[~2011-06-20 10:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 9:09 [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC MyungJoo Ham
2011-06-16 9:09 ` MyungJoo Ham
2011-06-16 9:09 ` [PATCH 2/2] Exynos4 NURI: add MAX17042 fuel gauge MyungJoo Ham
2011-06-16 9:09 ` MyungJoo Ham
2011-06-18 15:12 ` [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC Mark Brown
2011-06-18 15:12 ` Mark Brown
2011-06-20 6:26 ` MyungJoo Ham
2011-06-20 6:26 ` MyungJoo Ham
2011-06-20 10:27 ` Mark Brown
2011-06-20 10:27 ` Mark Brown
2011-06-20 7:58 ` MyungJoo Ham
2011-06-20 7:58 ` MyungJoo Ham
2011-06-20 10:31 ` Mark Brown [this message]
2011-06-20 10:31 ` Mark Brown
2011-06-21 2:07 ` [PATCH v2 0/4] ARM: Exynos4: NURI Board Configuration Udpate MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 5:33 ` Tushar Behera
2011-06-21 5:33 ` Tushar Behera
2011-06-21 11:10 ` Mark Brown
2011-06-21 11:10 ` Mark Brown
2011-06-21 11:49 ` Tushar Behera
2011-06-21 11:49 ` Tushar Behera
2011-06-21 11:56 ` Mark Brown
2011-06-21 11:56 ` Mark Brown
2011-06-22 2:37 ` MyungJoo Ham
2011-06-22 2:37 ` MyungJoo Ham
2011-06-22 2:31 ` MyungJoo Ham
2011-06-22 2:31 ` MyungJoo Ham
2011-06-22 3:43 ` Tushar Behera
2011-06-22 3:43 ` Tushar Behera
2011-06-22 9:17 ` Kukjin Kim
2011-06-22 9:17 ` Kukjin Kim
2011-06-21 11:07 ` Mark Brown
2011-06-21 11:07 ` Mark Brown
2011-06-21 2:07 ` [PATCH v2 2/4] Exynos4 NURI: configure MAX17042 fuel gauge MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` [PATCH v2 3/4] Exynos4 NURI: configure ADC MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` [PATCH v2 4/4] Exynos4 NURI: support for NTC thermistor MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 10:50 ` Mark Brown
2011-06-21 10:50 ` Mark Brown
2011-06-22 5:00 ` MyungJoo Ham
2011-06-22 5:00 ` MyungJoo Ham
2011-06-22 11:08 ` Mark Brown
2011-06-22 11:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620103124.GD31864@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.