From: Tushar Behera <tushar.behera@linaro.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
myungjoo.ham@gmail.com, dg77.kim@samsung.com
Subject: Re: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC
Date: Tue, 21 Jun 2011 11:03:12 +0530 [thread overview]
Message-ID: <4E002D18.2080401@linaro.org> (raw)
In-Reply-To: <1308622033-2521-2-git-send-email-myungjoo.ham@samsung.com>
On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote:
> Signed-off-by: MyungJoo Ham<myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>
> --
> Changes from v1. Thanks so much for your valuable comments, Mark.
> - Removed unnecessary initialization data
> - Add __initdata where necessary
> - Corrected a regulator name for ADC
> ---
> arch/arm/mach-exynos4/mach-nuri.c | 622 ++++++++++++++++++++++++++++++++++++-
> 1 files changed, 621 insertions(+), 1 deletions(-)
>
Will it be possible to move PMIC specific defines to a common file and
make appropriate calls in the board-specific file?
In that way, we can re-use this PMIC code on some other boards (e.g.
Insignal low-cost board Origen featuring Exynos4210 also features MAX8997).
--
Tushar Behera
WARNING: multiple messages have this Message-ID (diff)
From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC
Date: Tue, 21 Jun 2011 11:03:12 +0530 [thread overview]
Message-ID: <4E002D18.2080401@linaro.org> (raw)
In-Reply-To: <1308622033-2521-2-git-send-email-myungjoo.ham@samsung.com>
On Tuesday 21 June 2011 07:37 AM, MyungJoo Ham wrote:
> Signed-off-by: MyungJoo Ham<myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>
> --
> Changes from v1. Thanks so much for your valuable comments, Mark.
> - Removed unnecessary initialization data
> - Add __initdata where necessary
> - Corrected a regulator name for ADC
> ---
> arch/arm/mach-exynos4/mach-nuri.c | 622 ++++++++++++++++++++++++++++++++++++-
> 1 files changed, 621 insertions(+), 1 deletions(-)
>
Will it be possible to move PMIC specific defines to a common file and
make appropriate calls in the board-specific file?
In that way, we can re-use this PMIC code on some other boards (e.g.
Insignal low-cost board Origen featuring Exynos4210 also features MAX8997).
--
Tushar Behera
next prev parent reply other threads:[~2011-06-21 5:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 9:09 [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC MyungJoo Ham
2011-06-16 9:09 ` MyungJoo Ham
2011-06-16 9:09 ` [PATCH 2/2] Exynos4 NURI: add MAX17042 fuel gauge MyungJoo Ham
2011-06-16 9:09 ` MyungJoo Ham
2011-06-18 15:12 ` [PATCH 1/2] Exynos4 NURI: configure regulators and PMIC Mark Brown
2011-06-18 15:12 ` Mark Brown
2011-06-20 6:26 ` MyungJoo Ham
2011-06-20 6:26 ` MyungJoo Ham
2011-06-20 10:27 ` Mark Brown
2011-06-20 10:27 ` Mark Brown
2011-06-20 7:58 ` MyungJoo Ham
2011-06-20 7:58 ` MyungJoo Ham
2011-06-20 10:31 ` Mark Brown
2011-06-20 10:31 ` Mark Brown
2011-06-21 2:07 ` [PATCH v2 0/4] ARM: Exynos4: NURI Board Configuration Udpate MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` [PATCH v2 1/4] Exynos4 NURI: configure regulators and PMIC MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 5:33 ` Tushar Behera [this message]
2011-06-21 5:33 ` Tushar Behera
2011-06-21 11:10 ` Mark Brown
2011-06-21 11:10 ` Mark Brown
2011-06-21 11:49 ` Tushar Behera
2011-06-21 11:49 ` Tushar Behera
2011-06-21 11:56 ` Mark Brown
2011-06-21 11:56 ` Mark Brown
2011-06-22 2:37 ` MyungJoo Ham
2011-06-22 2:37 ` MyungJoo Ham
2011-06-22 2:31 ` MyungJoo Ham
2011-06-22 2:31 ` MyungJoo Ham
2011-06-22 3:43 ` Tushar Behera
2011-06-22 3:43 ` Tushar Behera
2011-06-22 9:17 ` Kukjin Kim
2011-06-22 9:17 ` Kukjin Kim
2011-06-21 11:07 ` Mark Brown
2011-06-21 11:07 ` Mark Brown
2011-06-21 2:07 ` [PATCH v2 2/4] Exynos4 NURI: configure MAX17042 fuel gauge MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` [PATCH v2 3/4] Exynos4 NURI: configure ADC MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` [PATCH v2 4/4] Exynos4 NURI: support for NTC thermistor MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 2:07 ` MyungJoo Ham
2011-06-21 10:50 ` Mark Brown
2011-06-21 10:50 ` Mark Brown
2011-06-22 5:00 ` MyungJoo Ham
2011-06-22 5:00 ` MyungJoo Ham
2011-06-22 11:08 ` Mark Brown
2011-06-22 11:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E002D18.2080401@linaro.org \
--to=tushar.behera@linaro.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dg77.kim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.