From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver
Date: Fri, 16 Sep 2011 17:26:31 +0100 [thread overview]
Message-ID: <20110916162630.GB23727@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4E736F9B.6080206@freescale.com>
On Fri, Sep 16, 2011 at 10:47:39AM -0500, Timur Tabi wrote:
> Yes, I was concerned about that. So should I be calling one of the
> snd_pcm_hw_constraint_xxx functions in the codec's .startup function? That
> would require ASoC to call the machine driver's .startup function *before*
> calling the codec driver's .startup function, since the machine driver's
> .startup function is where I call the codec to tell it what the mclk frequency is.
This isn't good for systems which can dynamically configure the clocks
based on the sample rate, they will wish to reconfigure things after the
user selected the sample rate in hw_params(). I've said several times
that this is the reason we don't actually advertise rates based on the
current rates.
Machine drivers are currently best placed to set constraints if the
clocking is limited.
next prev parent reply other threads:[~2011-09-16 16:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 14:16 [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver Timur Tabi
2011-09-16 15:37 ` Takashi Iwai
2011-09-16 15:47 ` Timur Tabi
2011-09-16 16:26 ` Mark Brown [this message]
2011-09-16 16:33 ` Timur Tabi
2011-09-16 16:47 ` Mark Brown
2011-09-16 16:54 ` Timur Tabi
2011-09-16 16:27 ` Lars-Peter Clausen
2011-09-16 16:28 ` Mark Brown
2011-09-16 16:34 ` Timur Tabi
2011-09-16 17:46 ` Lars-Peter Clausen
2011-09-16 18:19 ` Timur Tabi
2011-09-17 13:27 ` Mark Brown
2011-09-16 16:44 ` Mark Brown
2011-09-16 16:47 ` Timur Tabi
2011-09-16 16:48 ` Mark Brown
2011-09-16 16:56 ` Timur Tabi
2011-09-16 17:13 ` Mark Brown
2011-09-16 18:25 ` Timur Tabi
2011-09-17 12:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110916162630.GB23727@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@ti.com \
--cc=timur@freescale.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.