All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver
Date: Fri, 16 Sep 2011 13:25:08 -0500	[thread overview]
Message-ID: <4E739484.4000604@freescale.com> (raw)
In-Reply-To: <20110916171259.GG23727@opensource.wolfsonmicro.com>

Mark Brown wrote:

>> "Although the WM8776 driver includes a .set_sysclk function, it was also
>> hard-coding the list of supported sample rates."
> 
> Right, but the two things aren't connected.  As I've *repeatedly* said
> the list of supported sample rates in the DAI should be the full set
> that the device can support, unrelated to any clock setup.

But I could hook up any frequency to audmclk and dacmclk.  What if I want
40000Hz as a sample rate?  I could then then set mclk to 15.36MHz.

I don't see how the codec driver can know what sample rates it supports until
*after* set_sysclk() is called (i.e. when the driver is told the value of mclk).

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-09-16 18:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 14:16 [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver Timur Tabi
2011-09-16 15:37 ` Takashi Iwai
2011-09-16 15:47   ` Timur Tabi
2011-09-16 16:26     ` Mark Brown
2011-09-16 16:33       ` Timur Tabi
2011-09-16 16:47         ` Mark Brown
2011-09-16 16:54           ` Timur Tabi
2011-09-16 16:27     ` Lars-Peter Clausen
2011-09-16 16:28       ` Mark Brown
2011-09-16 16:34       ` Timur Tabi
2011-09-16 17:46         ` Lars-Peter Clausen
2011-09-16 18:19           ` Timur Tabi
2011-09-17 13:27           ` Mark Brown
2011-09-16 16:44 ` Mark Brown
2011-09-16 16:47   ` Timur Tabi
2011-09-16 16:48     ` Mark Brown
2011-09-16 16:56       ` Timur Tabi
2011-09-16 17:13         ` Mark Brown
2011-09-16 18:25           ` Timur Tabi [this message]
2011-09-17 12:58             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E739484.4000604@freescale.com \
    --to=timur@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.