All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Timur Tabi <timur@freescale.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	lrg@ti.com
Subject: Re: [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver
Date: Fri, 16 Sep 2011 18:27:14 +0200	[thread overview]
Message-ID: <4E7378E2.9050200@metafoo.de> (raw)
In-Reply-To: <4E736F9B.6080206@freescale.com>

On 09/16/2011 05:47 PM, Timur Tabi wrote:
> Takashi Iwai wrote:
> 
>> It's not optimal from some aspects.  Basically this should be resolved
>> in hw_constraints, not in hw_params, so that the configurator can find
>> the possible rates.  Otherwise you have no idea what rate would be
>> accepted.
> 
> Yes, I was concerned about that.  So should I be calling one of the
> snd_pcm_hw_constraint_xxx functions in the codec's .startup function?  That
> would require ASoC to call the machine driver's .startup function *before*
> calling the codec driver's .startup function, since the machine driver's
> .startup function is where I call the codec to tell it what the mclk frequency is.
> 

You mentioned in an earlyer mail that you can switch the sysclk rate at
runtime. So setting the constraints based on the current sysclk rate won't
really work. I think you need some mechanism to specify the supported rates on
a per machine driver basis.

  parent reply	other threads:[~2011-09-16 16:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 14:16 [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver Timur Tabi
2011-09-16 15:37 ` Takashi Iwai
2011-09-16 15:47   ` Timur Tabi
2011-09-16 16:26     ` Mark Brown
2011-09-16 16:33       ` Timur Tabi
2011-09-16 16:47         ` Mark Brown
2011-09-16 16:54           ` Timur Tabi
2011-09-16 16:27     ` Lars-Peter Clausen [this message]
2011-09-16 16:28       ` Mark Brown
2011-09-16 16:34       ` Timur Tabi
2011-09-16 17:46         ` Lars-Peter Clausen
2011-09-16 18:19           ` Timur Tabi
2011-09-17 13:27           ` Mark Brown
2011-09-16 16:44 ` Mark Brown
2011-09-16 16:47   ` Timur Tabi
2011-09-16 16:48     ` Mark Brown
2011-09-16 16:56       ` Timur Tabi
2011-09-16 17:13         ` Mark Brown
2011-09-16 18:25           ` Timur Tabi
2011-09-17 12:58             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E7378E2.9050200@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=timur@freescale.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.