All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, lrg@ti.com
Subject: Re: [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver
Date: Fri, 16 Sep 2011 11:54:02 -0500	[thread overview]
Message-ID: <4E737F2A.9040804@freescale.com> (raw)
In-Reply-To: <20110916164753.GE23727@opensource.wolfsonmicro.com>

Mark Brown wrote:
>> > But how is the machine driver supposed to know what those sample rates
>> > are?  It would need to know how which dividers that codec uses.  That
>> > would mean that the machine driver has to be hard-codec with
>> > information on the internals of the codec.

> You'd have to look at the CODEC datasheet and figure out what it's
> capable of given the clocks you're able to give it.  Depending on the
> flexibility you've got and power you're willing to spend there may be no
> need to do anything as you may be able to generate any clocks the device
> may need (for example with devices that have FLLs).

Well, my point was that this introduces a lot of information that's specific to
the internals of the codec into the machine driver.  Today, the only thing the
machine driver needs to know is the name of the DAIs:

	mdata->dai[0].codec_dai_name = "wm8776-hifi-playback";
	mdata->dai[1].codec_dai_name = "wm8776-hifi-capture";

and it might even be possible to avoid this.

-- 
Timur Tabi
Linux kernel developer at Freescale

  reply	other threads:[~2011-09-16 16:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 14:16 [PATCH] [v2] ASoC: support all possible sample rates in the WM8776 driver Timur Tabi
2011-09-16 15:37 ` Takashi Iwai
2011-09-16 15:47   ` Timur Tabi
2011-09-16 16:26     ` Mark Brown
2011-09-16 16:33       ` Timur Tabi
2011-09-16 16:47         ` Mark Brown
2011-09-16 16:54           ` Timur Tabi [this message]
2011-09-16 16:27     ` Lars-Peter Clausen
2011-09-16 16:28       ` Mark Brown
2011-09-16 16:34       ` Timur Tabi
2011-09-16 17:46         ` Lars-Peter Clausen
2011-09-16 18:19           ` Timur Tabi
2011-09-17 13:27           ` Mark Brown
2011-09-16 16:44 ` Mark Brown
2011-09-16 16:47   ` Timur Tabi
2011-09-16 16:48     ` Mark Brown
2011-09-16 16:56       ` Timur Tabi
2011-09-16 17:13         ` Mark Brown
2011-09-16 18:25           ` Timur Tabi
2011-09-17 12:58             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E737F2A.9040804@freescale.com \
    --to=timur@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.