All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Krishna Kumar <krkumar2@in.ibm.com>,
	kvm@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Wang Sheng-Hui <shhuiw@gmail.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Amit Shah <amit.shah@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH RFC] virtio-pci: flexible configuration layout
Date: Thu, 3 Nov 2011 15:53:17 +0200	[thread overview]
Message-ID: <20111103135316.GN18296@redhat.com> (raw)
In-Reply-To: <4EB29926.9030509@redhat.com>

On Thu, Nov 03, 2011 at 03:37:42PM +0200, Avi Kivity wrote:
> On 11/03/2011 02:11 PM, Michael S. Tsirkin wrote:
> > On Thu, Nov 03, 2011 at 12:37:04PM +0200, Avi Kivity wrote:
> > > On 11/03/2011 01:31 AM, Michael S. Tsirkin wrote:
> > > > Add a flexible mechanism to specify virtio configuration layout, using
> > > > pci vendor-specific capability.  A separate capability is used for each
> > > > of common, device specific and data-path accesses.
> > > >
> > > >
> > > 
> > > How about posting the spec change instead of patches?
> >
> > We need both of course but I typically start with patches.
> > Easier to see whether it's even possible to implement the
> > spec without overhauling all of the code.
> 
> Patches are okay for someone familiar with the code.  For others, they
> require more effort.

Yes. It's just that I needed to convince myself that the approach is good,
and that meant writing the supporting code. Since I had the code
I didn't see a reason not to send it :)

> -- 
> error compiling committee.c: too many arguments to function

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Sasha Levin <levinsasha928@gmail.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	Amit Shah <amit.shah@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Krishna Kumar <krkumar2@in.ibm.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Wang Sheng-Hui <shhuiw@gmail.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] virtio-pci: flexible configuration layout
Date: Thu, 3 Nov 2011 15:53:17 +0200	[thread overview]
Message-ID: <20111103135316.GN18296@redhat.com> (raw)
In-Reply-To: <4EB29926.9030509@redhat.com>

On Thu, Nov 03, 2011 at 03:37:42PM +0200, Avi Kivity wrote:
> On 11/03/2011 02:11 PM, Michael S. Tsirkin wrote:
> > On Thu, Nov 03, 2011 at 12:37:04PM +0200, Avi Kivity wrote:
> > > On 11/03/2011 01:31 AM, Michael S. Tsirkin wrote:
> > > > Add a flexible mechanism to specify virtio configuration layout, using
> > > > pci vendor-specific capability.  A separate capability is used for each
> > > > of common, device specific and data-path accesses.
> > > >
> > > >
> > > 
> > > How about posting the spec change instead of patches?
> >
> > We need both of course but I typically start with patches.
> > Easier to see whether it's even possible to implement the
> > spec without overhauling all of the code.
> 
> Patches are okay for someone familiar with the code.  For others, they
> require more effort.

Yes. It's just that I needed to convince myself that the approach is good,
and that meant writing the supporting code. Since I had the code
I didn't see a reason not to send it :)

> -- 
> error compiling committee.c: too many arguments to function

  reply	other threads:[~2011-11-03 13:53 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wrbkvh3v.fsf@rustcorp.com.au>
2011-11-01 11:45 ` [PULL] virtio Michael S. Tsirkin
2011-11-01 11:45   ` Michael S. Tsirkin
2011-11-01 12:33   ` Sasha Levin
2011-11-01 12:33     ` Sasha Levin
2011-11-01 12:42     ` Michael S. Tsirkin
2011-11-01 12:42       ` Michael S. Tsirkin
2011-11-01 12:45       ` Sasha Levin
2011-11-01 12:45         ` Sasha Levin
2011-11-02  1:09       ` Rusty Russell
2011-11-02  4:52         ` Sasha Levin
2011-11-02  4:52           ` Sasha Levin
2011-11-02 22:07           ` Rusty Russell
2011-11-02 22:07           ` Rusty Russell
2011-11-02 23:31         ` [PATCH RFC] virtio-pci: flexible configuration layout Michael S. Tsirkin
2011-11-02 23:31           ` Michael S. Tsirkin
2011-11-03  0:19           ` Sasha Levin
2011-11-03  0:19             ` Sasha Levin
2011-11-03 10:33             ` Michael S. Tsirkin
2011-11-03 10:33               ` Michael S. Tsirkin
2011-11-03 11:09               ` Sasha Levin
2011-11-03 11:09                 ` Sasha Levin
2011-11-03 11:36                 ` Michael S. Tsirkin
2011-11-03 11:36                   ` Michael S. Tsirkin
2011-11-03 13:30                 ` Michael S. Tsirkin
2011-11-03 13:30                   ` Michael S. Tsirkin
2011-11-03 10:37           ` Avi Kivity
2011-11-03 10:37             ` Avi Kivity
2011-11-03 12:11             ` Michael S. Tsirkin
2011-11-03 12:11               ` Michael S. Tsirkin
2011-11-03 13:37               ` Avi Kivity
2011-11-03 13:37                 ` Avi Kivity
2011-11-03 13:53                 ` Michael S. Tsirkin [this message]
2011-11-03 13:53                   ` Michael S. Tsirkin
2011-11-03 14:59           ` Jesse Barnes
2011-11-03 14:59             ` Jesse Barnes
2011-11-08 21:40           ` [PATCH RFC] virtio-spec: " Michael S. Tsirkin
2011-11-08 21:40             ` Michael S. Tsirkin
2011-11-08 21:41             ` Michael S. Tsirkin
2011-11-09 10:21               ` Avi Kivity
2011-11-09  8:46             ` Sasha Levin
2011-11-09  8:46             ` Sasha Levin
2011-11-09 10:13               ` Michael S. Tsirkin
2011-11-09 10:13                 ` Michael S. Tsirkin
2011-11-09 10:26                 ` Sasha Levin
2011-11-09 10:26                   ` Sasha Levin
2011-11-09 10:49                   ` Michael S. Tsirkin
2011-11-09 10:49                     ` Michael S. Tsirkin
2011-11-09 12:25                 ` Pekka Enberg
2011-11-09 12:25                 ` Pekka Enberg
2011-11-09 12:28                   ` Sasha Levin
2011-11-09 12:28                     ` Sasha Levin
2011-11-09 12:36                     ` Pekka Enberg
2011-11-09 15:33                       ` Michael S. Tsirkin
2011-11-09 15:33                       ` Michael S. Tsirkin
2012-06-18 11:54                       ` Michael S. Tsirkin
2012-06-18 11:54                         ` Michael S. Tsirkin
2012-06-18 12:05                         ` Sasha Levin
2012-06-18 12:05                         ` Sasha Levin
2012-06-18 12:07                           ` Michael S. Tsirkin
2012-06-18 12:07                             ` Michael S. Tsirkin
2011-11-09 12:36                     ` Pekka Enberg
2011-11-09 12:38               ` Avi Kivity
2011-11-09 12:38                 ` Avi Kivity
2011-11-09 12:48                 ` Sasha Levin
2011-11-09 12:48                   ` Sasha Levin
2011-11-09 15:19                   ` Michael S. Tsirkin
2011-11-13 14:07                     ` Ronen Hod
2011-11-13 14:07                       ` Ronen Hod
2011-11-09 15:19                   ` Michael S. Tsirkin
2011-11-09 15:51                   ` Michael S. Tsirkin
2011-11-09 15:51                   ` Michael S. Tsirkin
2011-11-13 20:40                 ` Vadim Rozenfeld
2011-11-13 20:40                   ` Vadim Rozenfeld
2011-11-09  9:55             ` Sasha Levin
2011-11-09 10:18               ` Michael S. Tsirkin
2011-11-09 10:18                 ` Michael S. Tsirkin
2011-11-09 10:20                 ` Sasha Levin
2011-11-09 10:20                   ` Sasha Levin
2011-11-09 10:20                   ` Sasha Levin
2011-11-09 10:47                   ` Pawel Moll
2011-11-09 10:47                   ` Pawel Moll
2011-11-09 10:55                     ` Sasha Levin
2011-11-09 10:55                       ` Sasha Levin
2011-11-09 11:06                       ` Pawel Moll
2011-11-09 11:06                       ` Pawel Moll
2011-11-09 11:39                         ` Peter Maydell
2011-11-09 11:39                         ` Peter Maydell
2011-11-09 12:07                         ` Sasha Levin
2011-11-09 12:07                           ` Sasha Levin
2011-11-09  9:55             ` Sasha Levin
2011-11-09 19:59             ` [PATCHv2 " Michael S. Tsirkin
2011-11-09 19:59               ` Michael S. Tsirkin
2011-11-09 20:00               ` Michael S. Tsirkin
2011-11-09 20:24               ` Sasha Levin
2011-11-09 20:24                 ` Sasha Levin
2011-11-09 20:52                 ` Michael S. Tsirkin
2011-11-09 20:52                   ` Michael S. Tsirkin
2011-11-09 20:57                   ` Sasha Levin
2011-11-09 20:57                     ` Sasha Levin
2011-11-09 21:14                     ` Michael S. Tsirkin
2011-11-09 21:14                       ` Michael S. Tsirkin
2011-11-09 21:13                       ` Sasha Levin
2011-11-09 21:13                         ` Sasha Levin
2011-11-10  8:55                         ` Michael S. Tsirkin
2011-11-10  8:55                           ` Michael S. Tsirkin
2011-11-11  4:24                     ` Rusty Russell
2011-11-11  4:24                     ` Rusty Russell
2011-11-11  7:39                       ` Sasha Levin
2011-11-11  7:39                         ` Sasha Levin
2011-11-11 12:59                         ` Michael S. Tsirkin
2011-11-11 12:59                           ` Michael S. Tsirkin
2011-11-11 13:06                           ` Pawel Moll
2011-11-11 13:06                           ` Pawel Moll
2011-11-15 23:58                         ` Rusty Russell
2011-11-15 23:58                           ` Rusty Russell
2011-11-16  7:21                           ` Michael S. Tsirkin
2011-11-16  7:21                             ` Michael S. Tsirkin
2011-11-16  8:17                             ` Sasha Levin
2011-11-16  8:17                               ` Sasha Levin
2011-11-16  9:09                               ` Michael S. Tsirkin
2011-11-16  9:09                                 ` Michael S. Tsirkin
2011-11-11 13:03                       ` Michael S. Tsirkin
2011-11-11 13:03                         ` Michael S. Tsirkin
2011-11-13 15:14                       ` Michael S. Tsirkin
2011-11-13 15:14                         ` Michael S. Tsirkin
2011-11-14  6:59                         ` Michael S. Tsirkin
2011-11-14  6:59                           ` Michael S. Tsirkin
2011-11-15 23:58                         ` Rusty Russell
2011-11-15 23:58                           ` Rusty Russell
2011-11-16  7:03                           ` Michael S. Tsirkin
2011-11-16  7:03                             ` Michael S. Tsirkin
2011-11-10 12:24               ` [PATCHv3 " Michael S. Tsirkin
2011-11-10 12:24                 ` Michael S. Tsirkin
2011-11-02  1:09       ` [PULL] virtio Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111103135316.GN18296@redhat.com \
    --to=mst@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=amit.shah@redhat.com \
    --cc=avi@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=krkumar2@in.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawel.moll@arm.com \
    --cc=shhuiw@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.