From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Cc: KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Balbir Singh
<bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge()
Date: Thu, 24 Nov 2011 12:58:16 +0100 [thread overview]
Message-ID: <20111124115816.GA1225@cmpxchg.org> (raw)
In-Reply-To: <20111124103049.GG26036-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
On Thu, Nov 24, 2011 at 11:30:49AM +0100, Michal Hocko wrote:
> On Thu 24-11-11 10:04:09, Johannes Weiner wrote:
> > From: Johannes Weiner <jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > Subject: mm: memcg: remove unneeded checks from newpage_charge() fix
> >
> > Document page state assumptions and catch if they are violated in
> > newpage_charge().
> >
> > Signed-off-by: Johannes Weiner <jweiner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> I assume you are going to fold it into the previous one.
> Acked-by: Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>
Thanks.
I'm under the assumption that incremental patches are better for
Andrew, but I forgot why.
But yes, this should be folded before going upstream.
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <bsingharora@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge()
Date: Thu, 24 Nov 2011 12:58:16 +0100 [thread overview]
Message-ID: <20111124115816.GA1225@cmpxchg.org> (raw)
In-Reply-To: <20111124103049.GG26036@tiehlicka.suse.cz>
On Thu, Nov 24, 2011 at 11:30:49AM +0100, Michal Hocko wrote:
> On Thu 24-11-11 10:04:09, Johannes Weiner wrote:
> > From: Johannes Weiner <jweiner@redhat.com>
> > Subject: mm: memcg: remove unneeded checks from newpage_charge() fix
> >
> > Document page state assumptions and catch if they are violated in
> > newpage_charge().
> >
> > Signed-off-by: Johannes Weiner <jweiner@redhat.com>
>
> I assume you are going to fold it into the previous one.
> Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks.
I'm under the assumption that incremental patches are better for
Andrew, but I forgot why.
But yes, this should be folded before going upstream.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <bsingharora@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge()
Date: Thu, 24 Nov 2011 12:58:16 +0100 [thread overview]
Message-ID: <20111124115816.GA1225@cmpxchg.org> (raw)
In-Reply-To: <20111124103049.GG26036@tiehlicka.suse.cz>
On Thu, Nov 24, 2011 at 11:30:49AM +0100, Michal Hocko wrote:
> On Thu 24-11-11 10:04:09, Johannes Weiner wrote:
> > From: Johannes Weiner <jweiner@redhat.com>
> > Subject: mm: memcg: remove unneeded checks from newpage_charge() fix
> >
> > Document page state assumptions and catch if they are violated in
> > newpage_charge().
> >
> > Signed-off-by: Johannes Weiner <jweiner@redhat.com>
>
> I assume you are going to fold it into the previous one.
> Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks.
I'm under the assumption that incremental patches are better for
Andrew, but I forgot why.
But yes, this should be folded before going upstream.
next prev parent reply other threads:[~2011-11-24 11:58 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 15:42 [patch 0/8] mm: memcg fixlets for 3.3 Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
2011-11-23 15:42 ` [patch 1/8] mm: oom_kill: remove memcg argument from oom_kill_task() Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
2011-11-24 9:07 ` Michal Hocko
2011-11-24 9:07 ` Michal Hocko
[not found] ` <1322062951-1756-2-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-23 22:35 ` David Rientjes
2011-11-23 22:35 ` David Rientjes
2011-11-23 22:35 ` David Rientjes
2011-11-23 23:57 ` KAMEZAWA Hiroyuki
2011-11-23 23:57 ` KAMEZAWA Hiroyuki
2011-11-23 23:57 ` KAMEZAWA Hiroyuki
2011-11-28 0:37 ` Balbir Singh
2011-11-28 0:37 ` Balbir Singh
2011-11-28 0:37 ` Balbir Singh
2011-11-23 15:42 ` [patch 2/8] mm: unify remaining mem_cont, mem, etc. variable names to memcg Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-3-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-23 22:40 ` David Rientjes
2011-11-23 22:40 ` David Rientjes
2011-11-23 22:40 ` David Rientjes
2011-11-23 23:58 ` KAMEZAWA Hiroyuki
2011-11-23 23:58 ` KAMEZAWA Hiroyuki
2011-11-23 23:58 ` KAMEZAWA Hiroyuki
2011-11-24 9:17 ` Michal Hocko
2011-11-24 9:17 ` Michal Hocko
2011-11-28 0:42 ` Balbir Singh
2011-11-28 0:42 ` Balbir Singh
2011-11-23 15:42 ` [patch 3/8] mm: memcg: clean up fault accounting Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-4-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 0:00 ` KAMEZAWA Hiroyuki
2011-11-24 0:00 ` KAMEZAWA Hiroyuki
2011-11-24 0:00 ` KAMEZAWA Hiroyuki
2011-11-24 9:33 ` Michal Hocko
2011-11-24 9:33 ` Michal Hocko
2011-11-24 9:51 ` Johannes Weiner
2011-11-24 9:51 ` Johannes Weiner
2011-11-28 0:45 ` Balbir Singh
2011-11-28 0:45 ` Balbir Singh
2011-11-23 15:42 ` [patch 4/8] mm: memcg: lookup_page_cgroup (almost) never returns NULL Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-5-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 0:01 ` KAMEZAWA Hiroyuki
2011-11-24 0:01 ` KAMEZAWA Hiroyuki
2011-11-24 0:01 ` KAMEZAWA Hiroyuki
2011-11-24 9:52 ` Michal Hocko
2011-11-24 9:52 ` Michal Hocko
2011-11-24 9:52 ` Michal Hocko
[not found] ` <20111124095251.GD26036-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-11-24 10:05 ` Johannes Weiner
2011-11-24 10:05 ` Johannes Weiner
2011-11-24 10:05 ` Johannes Weiner
[not found] ` <20111124100549.GH6843-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 10:26 ` Michal Hocko
2011-11-24 10:26 ` Michal Hocko
2011-11-24 10:26 ` Michal Hocko
2011-11-28 9:15 ` Johannes Weiner
2011-11-28 9:15 ` Johannes Weiner
[not found] ` <20111128091518.GA9356-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-28 9:34 ` Johannes Weiner
2011-11-28 9:34 ` Johannes Weiner
2011-11-28 9:34 ` Johannes Weiner
[not found] ` <20111128093435.GC9356-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-28 10:12 ` Michal Hocko
2011-11-28 10:12 ` Michal Hocko
2011-11-28 10:12 ` Michal Hocko
2011-11-28 7:03 ` Balbir Singh
2011-11-28 7:03 ` Balbir Singh
2011-11-28 7:03 ` Balbir Singh
[not found] ` <CAKTCnz=CObdw0z4Qf36=afwwApuTer5C4Jp21QUko-H__q-+aA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-28 9:17 ` Johannes Weiner
2011-11-28 9:17 ` Johannes Weiner
2011-11-28 9:17 ` Johannes Weiner
2011-11-23 15:42 ` [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge() Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-6-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 0:04 ` KAMEZAWA Hiroyuki
2011-11-24 0:04 ` KAMEZAWA Hiroyuki
2011-11-24 0:04 ` KAMEZAWA Hiroyuki
[not found] ` <20111124090443.d3f720c5.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-11-24 9:04 ` Johannes Weiner
2011-11-24 9:04 ` Johannes Weiner
2011-11-24 9:04 ` Johannes Weiner
[not found] ` <20111124090409.GC6843-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 10:30 ` Michal Hocko
2011-11-24 10:30 ` Michal Hocko
2011-11-24 10:30 ` Michal Hocko
[not found] ` <20111124103049.GG26036-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2011-11-24 11:58 ` Johannes Weiner [this message]
2011-11-24 11:58 ` Johannes Weiner
2011-11-24 11:58 ` Johannes Weiner
2011-11-23 15:42 ` [patch 6/8] mm: memcg: remove unneeded checks from uncharge_page() Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-7-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 0:06 ` KAMEZAWA Hiroyuki
2011-11-24 0:06 ` KAMEZAWA Hiroyuki
2011-11-24 0:06 ` KAMEZAWA Hiroyuki
[not found] ` <20111124090619.895988e7.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-11-24 9:06 ` Johannes Weiner
2011-11-24 9:06 ` Johannes Weiner
2011-11-24 9:06 ` Johannes Weiner
2011-11-24 10:34 ` Michal Hocko
2011-11-24 10:34 ` Michal Hocko
2011-11-23 15:42 ` [patch 7/8] mm: memcg: modify PageCgroupAcctLRU non-atomically Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-8-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-23 18:52 ` Hugh Dickins
2011-11-23 18:52 ` Hugh Dickins
2011-11-23 18:52 ` Hugh Dickins
[not found] ` <alpine.LSU.2.00.1111231039390.2175-T/S/X05ZC3jbmfIwyoSfiQ@public.gmane.org>
2011-11-24 8:53 ` Johannes Weiner
2011-11-24 8:53 ` Johannes Weiner
2011-11-24 8:53 ` Johannes Weiner
2011-11-24 0:09 ` KAMEZAWA Hiroyuki
2011-11-24 0:09 ` KAMEZAWA Hiroyuki
2011-11-24 0:09 ` KAMEZAWA Hiroyuki
[not found] ` <20111124090915.2f6e2e2c.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-11-24 8:55 ` Johannes Weiner
2011-11-24 8:55 ` Johannes Weiner
2011-11-24 8:55 ` Johannes Weiner
2011-11-23 15:42 ` [patch 8/8] mm: memcg: modify PageCgroupCache non-atomically Johannes Weiner
2011-11-23 15:42 ` Johannes Weiner
[not found] ` <1322062951-1756-9-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 0:13 ` KAMEZAWA Hiroyuki
2011-11-24 0:13 ` KAMEZAWA Hiroyuki
2011-11-24 0:13 ` KAMEZAWA Hiroyuki
[not found] ` <20111124091328.d28d9f55.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2011-11-24 9:13 ` Johannes Weiner
2011-11-24 9:13 ` Johannes Weiner
2011-11-24 9:13 ` Johannes Weiner
[not found] ` <1322062951-1756-1-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2011-11-24 6:09 ` [patch 0/8] mm: memcg fixlets for 3.3 Balbir Singh
2011-11-24 6:09 ` Balbir Singh
2011-11-24 6:09 ` Balbir Singh
[not found] ` <CAKTCnzk0Jzq+o1Qv9hOO5ssO7U_xe1ZqUaWDhWEeJAQQPjPudg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-24 9:45 ` Johannes Weiner
2011-11-24 9:45 ` Johannes Weiner
2011-11-24 9:45 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124115816.GA1225@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bsingharora-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.