All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] ARM: OMAP1: Fix dpll1 reprogramming not actually allowed
Date: Mon, 28 Nov 2011 09:46:16 -0800	[thread overview]
Message-ID: <20111128174616.GP31337@atomide.com> (raw)
In-Reply-To: <1322364751-29980-4-git-send-email-jkrzyszt@tis.icnet.pl>

* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [111126 19:06]:
> DPLL1 reprogramming to a different rate is actually blocked inside
> omap1_select_table_rate(), resulting in the defalut rate of 60 MHz
> always used instead of the one selected in .config. Fix it.
> 
> Created against linux-3.2-rc2, tested on Amstrad Delta on top of
> linux-omap/fixes.

This too first requires something for boards to pass the supported
rates.

Tony
 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> ---
>  arch/arm/mach-omap1/clock.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> index 3899176..962adbc 100644
> --- a/arch/arm/mach-omap1/clock.c
> +++ b/arch/arm/mach-omap1/clock.c
> @@ -200,10 +200,6 @@ int omap1_select_table_rate(struct clk *clk, unsigned long rate)
>  		if (ptr->xtal != ref_rate)
>  			continue;
>  
> -		/* DPLL1 cannot be reprogrammed without risking system crash */
> -		if (likely(dpll1_rate != 0) && ptr->pll_rate != dpll1_rate)
> -			continue;
> -
>  		/* Can check only after xtal frequency check */
>  		if (ptr->rate <= rate)
>  			break;
> -- 
> 1.7.3.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: OMAP1: Fix dpll1 reprogramming not actually allowed
Date: Mon, 28 Nov 2011 09:46:16 -0800	[thread overview]
Message-ID: <20111128174616.GP31337@atomide.com> (raw)
In-Reply-To: <1322364751-29980-4-git-send-email-jkrzyszt@tis.icnet.pl>

* Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> [111126 19:06]:
> DPLL1 reprogramming to a different rate is actually blocked inside
> omap1_select_table_rate(), resulting in the defalut rate of 60 MHz
> always used instead of the one selected in .config. Fix it.
> 
> Created against linux-3.2-rc2, tested on Amstrad Delta on top of
> linux-omap/fixes.

This too first requires something for boards to pass the supported
rates.

Tony
 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> ---
>  arch/arm/mach-omap1/clock.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-omap1/clock.c b/arch/arm/mach-omap1/clock.c
> index 3899176..962adbc 100644
> --- a/arch/arm/mach-omap1/clock.c
> +++ b/arch/arm/mach-omap1/clock.c
> @@ -200,10 +200,6 @@ int omap1_select_table_rate(struct clk *clk, unsigned long rate)
>  		if (ptr->xtal != ref_rate)
>  			continue;
>  
> -		/* DPLL1 cannot be reprogrammed without risking system crash */
> -		if (likely(dpll1_rate != 0) && ptr->pll_rate != dpll1_rate)
> -			continue;
> -
>  		/* Can check only after xtal frequency check */
>  		if (ptr->rate <= rate)
>  			break;
> -- 
> 1.7.3.4
> 

  reply	other threads:[~2011-11-28 17:46 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27  3:32 [PATCH 0/5] ARM: OMAP1: Fix dpll1 reprogramming related issues Janusz Krzysztofik
2011-11-27  3:32 ` Janusz Krzysztofik
2011-11-27  3:32 ` Janusz Krzysztofik
2011-11-27  3:32 ` [PATCH 1/5] ARM: OMAP1: Fix dpll1 default rate reprogramming method Janusz Krzysztofik
2011-11-27  3:32   ` Janusz Krzysztofik
2011-11-28 17:45   ` Tony Lindgren
2011-11-28 17:45     ` Tony Lindgren
2011-11-28 22:00     ` [PATCH 2a/5] Remove unsafe clock values from omap1_defconfig Janusz Krzysztofik
2011-11-28 22:00       ` Janusz Krzysztofik
2011-11-30 22:32       ` Tony Lindgren
2011-11-30 22:32         ` Tony Lindgren
2011-11-30 20:57     ` [PATCH 2a/5 v2] ARM: OMAP1: select clock rate by CPU type Janusz Krzysztofik
2011-11-30 20:57       ` Janusz Krzysztofik
2011-11-30 22:28       ` Tony Lindgren
2011-11-30 22:28         ` Tony Lindgren
2011-12-01 10:10         ` Janusz Krzysztofik
2011-12-01 10:10           ` Janusz Krzysztofik
2011-12-01 18:22           ` Tony Lindgren
2011-12-01 18:22             ` Tony Lindgren
2011-12-01 18:54             ` Janusz Krzysztofik
2011-12-01 18:54               ` Janusz Krzysztofik
2011-12-01 19:06               ` Tony Lindgren
2011-12-01 19:06                 ` Tony Lindgren
2011-12-04 12:17         ` [PATCH] ARM: OMAP1: Move dpll1 rates selection from config to runtime Janusz Krzysztofik
2011-12-04 12:17           ` Janusz Krzysztofik
2011-12-08 23:13           ` Janusz Krzysztofik
2011-12-08 23:13             ` Janusz Krzysztofik
2011-12-09  1:51             ` [PATCH v2] " Janusz Krzysztofik
2011-12-09  1:51               ` Janusz Krzysztofik
2011-12-09  2:09               ` Tony Lindgren
2011-12-09  2:09                 ` Tony Lindgren
2011-12-09  2:31                 ` Janusz Krzysztofik
2011-12-09  2:31                   ` Janusz Krzysztofik
2011-12-09  1:51       ` [PATCH] ARM: OMAP1: Set the omap1623 sram size to 16K Tony Lindgren
2011-12-09  1:51         ` Tony Lindgren
     [not found]     ` <201112010310.43890.jkrzyszt@tis.icnet.pl>
     [not found]       ` <20111201022750.GY13928@atomide.com>
2011-12-01  9:54         ` [PATCH 2a/5] Remove unsafe clock values from omap1_defconfig Janusz Krzysztofik
2011-12-01  9:54           ` Janusz Krzysztofik
2011-12-01 10:21           ` Janusz Krzysztofik
2011-12-01 10:21             ` Janusz Krzysztofik
2011-12-01 17:17           ` Tony Lindgren
2011-12-01 17:17             ` Tony Lindgren
2011-12-01 18:38             ` Janusz Krzysztofik
2011-12-01 18:38               ` Janusz Krzysztofik
2011-12-01 19:04               ` Tony Lindgren
2011-12-01 19:04                 ` Tony Lindgren
2011-12-01 19:23                 ` Janusz Krzysztofik
2011-12-01 19:23                   ` Janusz Krzysztofik
2011-12-01 19:46                   ` Tony Lindgren
2011-12-01 19:46                     ` Tony Lindgren
2011-12-01 20:30                     ` [PATCH] ARM: OMAP1: " Janusz Krzysztofik
2011-12-01 20:30                       ` Janusz Krzysztofik
2011-12-01 20:13                   ` [PATCH 0/2 v2] ARM: OMAP1: Fix dpll1 reprogramming related issues Janusz Krzysztofik
2011-12-01 20:13                     ` Janusz Krzysztofik
2011-12-01 21:16                     ` [PATCH v2] ARM: OMAP1: Update dpll1 default rate reprogramming method Janusz Krzysztofik
2011-12-01 21:16                       ` Janusz Krzysztofik
2011-12-02  2:09                     ` [PATCH 0/2 v2] ARM: OMAP1: Fix dpll1 reprogramming related issues Tony Lindgren
2011-12-02  2:09                       ` Tony Lindgren
2011-12-02 17:02                       ` Janusz Krzysztofik
2011-12-02 17:02                         ` Janusz Krzysztofik
2011-12-01 20:13                   ` [PATCH 1/2 v2] ARM: OMAP1: Fix ckctl value used for dpll1 defualt rate Janusz Krzysztofik
2011-12-01 20:13                     ` Janusz Krzysztofik
2011-12-01 20:13                   ` [PATCH 2/2 v2] ARM: OMAP1: recalculate loops per jiffy after dpll1 reprogram Janusz Krzysztofik
2011-12-01 20:13                     ` Janusz Krzysztofik
2011-12-04 15:07                 ` [PATCH] ARM: OMAP1: Always reprogramme dpll1 rate at boot Janusz Krzysztofik
2011-12-04 15:07                   ` Janusz Krzysztofik
2011-11-27  3:32 ` [PATCH 2/5] ARM: OMAP1: Fix ckctl value used for dpll1 defualt rate Janusz Krzysztofik
2011-11-27  3:32   ` Janusz Krzysztofik
2011-11-27  3:32 ` [PATCH 3/5] ARM: OMAP1: Fix dpll1 reprogramming not actually allowed Janusz Krzysztofik
2011-11-27  3:32   ` Janusz Krzysztofik
2011-11-28 17:46   ` Tony Lindgren [this message]
2011-11-28 17:46     ` Tony Lindgren
2011-11-27  3:32 ` [PATCH 4/5] init/calibrate.c: allow for recalibration of loops per jiffy Janusz Krzysztofik
2011-11-27  3:32   ` Janusz Krzysztofik
2011-11-28 15:39   ` Russell King - ARM Linux
2011-11-28 15:39     ` Russell King - ARM Linux
2011-11-28 22:30     ` Janusz Krzysztofik
2011-11-28 22:30       ` Janusz Krzysztofik
2011-11-27  3:32 ` [PATCH 5/5] ARM: OMAP1: recalibrate loops per jiffy after dpll1 reprogram Janusz Krzysztofik
2011-11-27  3:32   ` Janusz Krzysztofik
2011-11-29  0:25   ` [PATCH 5/5 v2] ARM: OMAP1: recalculate " Janusz Krzysztofik
2011-11-29  0:25     ` Janusz Krzysztofik
2011-12-09  8:42     ` Russell King - ARM Linux
2011-12-09  8:42       ` Russell King - ARM Linux
2011-12-09 10:00       ` Janusz Krzysztofik
2011-12-09 10:00         ` Janusz Krzysztofik
2011-12-09 10:09         ` Janusz Krzysztofik
2011-12-09 10:09           ` Janusz Krzysztofik
2011-12-10  0:25         ` Russell King - ARM Linux
2011-12-10  0:25           ` Russell King - ARM Linux
2011-12-10 12:04           ` Janusz Krzysztofik
2011-12-10 12:04             ` Janusz Krzysztofik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128174616.GP31337@atomide.com \
    --to=tony@atomide.com \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.