* [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board @ 2011-12-21 2:20 Wu Fengguang 2011-12-21 6:46 ` Takashi Iwai 0 siblings, 1 reply; 8+ messages in thread From: Wu Fengguang @ 2011-12-21 2:20 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> --- sound/pci/hda/alc882_quirks.c | 1 + 1 file changed, 1 insertion(+) --- linux.orig/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:51.880000058 +0800 +++ linux/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:58.740000115 +0800 @@ -2955,6 +2955,7 @@ static const struct snd_pci_quirk alc882 SND_PCI_QUIRK(0x8086, 0x0002, "DG33FBC", ALC883_3ST_6ch_INTEL), SND_PCI_QUIRK(0x8086, 0x2503, "82801H", ALC883_MITAC), SND_PCI_QUIRK(0x8086, 0x0022, "DX58SO", ALC889_INTEL), + SND_PCI_QUIRK(0x8086, 0x7270, "Intel Los Lunas 2", ALC889_INTEL), SND_PCI_QUIRK(0x8086, 0x0021, "Intel IbexPeak", ALC889A_INTEL), SND_PCI_QUIRK(0x8086, 0x3b56, "Intel IbexPeak", ALC889A_INTEL), SND_PCI_QUIRK(0x8086, 0xd601, "D102GGC", ALC882_6ST_DIG), ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 2:20 [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board Wu Fengguang @ 2011-12-21 6:46 ` Takashi Iwai 2011-12-21 7:23 ` Wu Fengguang 2011-12-21 7:38 ` Wu Fengguang 0 siblings, 2 replies; 8+ messages in thread From: Takashi Iwai @ 2011-12-21 6:46 UTC (permalink / raw) To: Wu Fengguang; +Cc: alsa-devel At Wed, 21 Dec 2011 10:20:20 +0800, Wu Fengguang wrote: > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Do you really need this? I'm in the process removing all these model quirks. Basically if the BIOS provides the right pin-config, it should work with the auto-parser. If not, you can still provide the pin-config either statically or dynamically. thanks, Takashi > --- > sound/pci/hda/alc882_quirks.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux.orig/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:51.880000058 +0800 > +++ linux/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:58.740000115 +0800 > @@ -2955,6 +2955,7 @@ static const struct snd_pci_quirk alc882 > SND_PCI_QUIRK(0x8086, 0x0002, "DG33FBC", ALC883_3ST_6ch_INTEL), > SND_PCI_QUIRK(0x8086, 0x2503, "82801H", ALC883_MITAC), > SND_PCI_QUIRK(0x8086, 0x0022, "DX58SO", ALC889_INTEL), > + SND_PCI_QUIRK(0x8086, 0x7270, "Intel Los Lunas 2", ALC889_INTEL), > SND_PCI_QUIRK(0x8086, 0x0021, "Intel IbexPeak", ALC889A_INTEL), > SND_PCI_QUIRK(0x8086, 0x3b56, "Intel IbexPeak", ALC889A_INTEL), > SND_PCI_QUIRK(0x8086, 0xd601, "D102GGC", ALC882_6ST_DIG), > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 6:46 ` Takashi Iwai @ 2011-12-21 7:23 ` Wu Fengguang 2011-12-21 7:34 ` Takashi Iwai 2011-12-21 8:09 ` David Henningsson 2011-12-21 7:38 ` Wu Fengguang 1 sibling, 2 replies; 8+ messages in thread From: Wu Fengguang @ 2011-12-21 7:23 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel@alsa-project.org On Wed, Dec 21, 2011 at 02:46:32PM +0800, Takashi Iwai wrote: > At Wed, 21 Dec 2011 10:20:20 +0800, > Wu Fengguang wrote: > > > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> > > Do you really need this? Yeah, the problem (now and future) is, our early hardware often have broken BIOS that does not get the pin-config right. However I understand that it's not sane to continue expanding the quick code. > I'm in the process removing all these model quirks. Doesn't that risk introducing many regressions? What would be the problem if we switch to the generic HDA driver for *new* boards and leave the old working quicks/models untouched? > Basically if the BIOS provides the right pin-config, it should work > with the auto-parser. If not, you can still provide the pin-config > either statically or dynamically. OK. Do you expect me to follow the example given by commit 2996bdbaa ("ALSA: hda - Remove ALC662 eeepc-p701 and ecs models")? Thanks, Fengguang > > --- > > sound/pci/hda/alc882_quirks.c | 1 + > > 1 file changed, 1 insertion(+) > > > > --- linux.orig/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:51.880000058 +0800 > > +++ linux/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:58.740000115 +0800 > > @@ -2955,6 +2955,7 @@ static const struct snd_pci_quirk alc882 > > SND_PCI_QUIRK(0x8086, 0x0002, "DG33FBC", ALC883_3ST_6ch_INTEL), > > SND_PCI_QUIRK(0x8086, 0x2503, "82801H", ALC883_MITAC), > > SND_PCI_QUIRK(0x8086, 0x0022, "DX58SO", ALC889_INTEL), > > + SND_PCI_QUIRK(0x8086, 0x7270, "Intel Los Lunas 2", ALC889_INTEL), > > SND_PCI_QUIRK(0x8086, 0x0021, "Intel IbexPeak", ALC889A_INTEL), > > SND_PCI_QUIRK(0x8086, 0x3b56, "Intel IbexPeak", ALC889A_INTEL), > > SND_PCI_QUIRK(0x8086, 0xd601, "D102GGC", ALC882_6ST_DIG), > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 7:23 ` Wu Fengguang @ 2011-12-21 7:34 ` Takashi Iwai 2011-12-21 8:09 ` David Henningsson 1 sibling, 0 replies; 8+ messages in thread From: Takashi Iwai @ 2011-12-21 7:34 UTC (permalink / raw) To: Wu Fengguang; +Cc: alsa-devel@alsa-project.org At Wed, 21 Dec 2011 15:23:14 +0800, Wu Fengguang wrote: > > On Wed, Dec 21, 2011 at 02:46:32PM +0800, Takashi Iwai wrote: > > At Wed, 21 Dec 2011 10:20:20 +0800, > > Wu Fengguang wrote: > > > > > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> > > > > Do you really need this? > > Yeah, the problem (now and future) is, our early hardware often have > broken BIOS that does not get the pin-config right. However I > understand that it's not sane to continue expanding the quick code. > > > I'm in the process removing all these model quirks. > > Doesn't that risk introducing many regressions? What would be the > problem if we switch to the generic HDA driver for *new* boards and > leave the old working quicks/models untouched? I've checked (manually) with hda-emu whether the new code works with the old static quirks before them. (It's also a part of the reasons why ALC880 and ALC882 model quirks still remain -- it takes time to verify all these old models.) > > Basically if the BIOS provides the right pin-config, it should work > > with the auto-parser. If not, you can still provide the pin-config > > either statically or dynamically. > > OK. Do you expect me to follow the example given by commit 2996bdbaa > ("ALSA: hda - Remove ALC662 eeepc-p701 and ecs models")? Yes, just add an entry with a static pin-config table for your device. thanks, Takashi > > Thanks, > Fengguang > > > > --- > > > sound/pci/hda/alc882_quirks.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > --- linux.orig/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:51.880000058 +0800 > > > +++ linux/sound/pci/hda/alc882_quirks.c 2011-12-20 14:16:58.740000115 +0800 > > > @@ -2955,6 +2955,7 @@ static const struct snd_pci_quirk alc882 > > > SND_PCI_QUIRK(0x8086, 0x0002, "DG33FBC", ALC883_3ST_6ch_INTEL), > > > SND_PCI_QUIRK(0x8086, 0x2503, "82801H", ALC883_MITAC), > > > SND_PCI_QUIRK(0x8086, 0x0022, "DX58SO", ALC889_INTEL), > > > + SND_PCI_QUIRK(0x8086, 0x7270, "Intel Los Lunas 2", ALC889_INTEL), > > > SND_PCI_QUIRK(0x8086, 0x0021, "Intel IbexPeak", ALC889A_INTEL), > > > SND_PCI_QUIRK(0x8086, 0x3b56, "Intel IbexPeak", ALC889A_INTEL), > > > SND_PCI_QUIRK(0x8086, 0xd601, "D102GGC", ALC882_6ST_DIG), > > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 7:23 ` Wu Fengguang 2011-12-21 7:34 ` Takashi Iwai @ 2011-12-21 8:09 ` David Henningsson 2011-12-21 8:24 ` Wu Fengguang 1 sibling, 1 reply; 8+ messages in thread From: David Henningsson @ 2011-12-21 8:09 UTC (permalink / raw) To: Wu Fengguang; +Cc: Takashi Iwai, alsa-devel@alsa-project.org On 12/21/2011 08:23 AM, Wu Fengguang wrote: > On Wed, Dec 21, 2011 at 02:46:32PM +0800, Takashi Iwai wrote: >> I'm in the process removing all these model quirks. > > Doesn't that risk introducing many regressions? What would be the > problem if we switch to the generic HDA driver for *new* boards and > leave the old working quicks/models untouched? For me, it's the other way around. Whenever we try to improve the generic behaviour of the codec driver, e g by adding configurable auto-mute, jack detection notification etc, these old models get left behind because the new stuff depends on information we get out of the autoparser(s). By removing the model quirks, these machines can benefit from the new functionality as well. -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 8:09 ` David Henningsson @ 2011-12-21 8:24 ` Wu Fengguang 0 siblings, 0 replies; 8+ messages in thread From: Wu Fengguang @ 2011-12-21 8:24 UTC (permalink / raw) To: David Henningsson; +Cc: Takashi Iwai, alsa-devel@alsa-project.org On Wed, Dec 21, 2011 at 04:09:36PM +0800, David Henningsson wrote: > On 12/21/2011 08:23 AM, Wu Fengguang wrote: > > On Wed, Dec 21, 2011 at 02:46:32PM +0800, Takashi Iwai wrote: > >> I'm in the process removing all these model quirks. > > > > Doesn't that risk introducing many regressions? What would be the > > problem if we switch to the generic HDA driver for *new* boards and > > leave the old working quicks/models untouched? > > For me, it's the other way around. Whenever we try to improve the > generic behaviour of the codec driver, e g by adding configurable > auto-mute, jack detection notification etc, these old models get left > behind because the new stuff depends on information we get out of the > autoparser(s). > > By removing the model quirks, these machines can benefit from the new > functionality as well. Yeah that's a good point of view! I cannot agree it any more. Thanks, Fengguang ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 6:46 ` Takashi Iwai 2011-12-21 7:23 ` Wu Fengguang @ 2011-12-21 7:38 ` Wu Fengguang 2011-12-21 7:42 ` Takashi Iwai 1 sibling, 1 reply; 8+ messages in thread From: Wu Fengguang @ 2011-12-21 7:38 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel@alsa-project.org Takashi, With the anticipation we'll be adding lots of pincfg numbers in future: + [ALC662_FIXUP_ECS] = { + .type = ALC_FIXUP_PINS, + .v.pins = (const struct alc_pincfg[]) { + { 0x14, 0x99130110 }, /* speaker */ + { 0x18, 0x01a19820 }, /* mic */ These numbers are anything but intuitive. Do you mind me introduce some macros to make them easier to compose and read? Thanks, Fengguang ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board 2011-12-21 7:38 ` Wu Fengguang @ 2011-12-21 7:42 ` Takashi Iwai 0 siblings, 0 replies; 8+ messages in thread From: Takashi Iwai @ 2011-12-21 7:42 UTC (permalink / raw) To: Wu Fengguang; +Cc: alsa-devel@alsa-project.org At Wed, 21 Dec 2011 15:38:31 +0800, Wu Fengguang wrote: > > Takashi, > > With the anticipation we'll be adding lots of pincfg numbers in future: > > + [ALC662_FIXUP_ECS] = { > + .type = ALC_FIXUP_PINS, > + .v.pins = (const struct alc_pincfg[]) { > + { 0x14, 0x99130110 }, /* speaker */ > + { 0x18, 0x01a19820 }, /* mic */ > > These numbers are anything but intuitive. Do you mind me > introduce some macros to make them easier to compose and read? No, please go ahead. It'll be good to have such macros. I was too lazy to write macros, since I understand these raw numbers nowadays ;) Takashi ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-12-21 8:24 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-12-21 2:20 [PATCH] hda - add ALC889 quick id for Intel Los Lunas 2 desktop reference board Wu Fengguang 2011-12-21 6:46 ` Takashi Iwai 2011-12-21 7:23 ` Wu Fengguang 2011-12-21 7:34 ` Takashi Iwai 2011-12-21 8:09 ` David Henningsson 2011-12-21 8:24 ` Wu Fengguang 2011-12-21 7:38 ` Wu Fengguang 2011-12-21 7:42 ` Takashi Iwai
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.