From: Marek Vasut <marek.vasut@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Huang Shijie <b32955@freescale.com>, linux-mtd@lists.infradead.org
Subject: Re: GPMI-NAND: Wrong ECC size in driver
Date: Wed, 4 Jan 2012 22:32:26 +0100 [thread overview]
Message-ID: <201201042232.26781.marek.vasut@gmail.com> (raw)
In-Reply-To: <4F048C99.2010302@freescale.com>
> On 01/03/2012 11:58 PM, Huang Shijie wrote:
> > Hi Marek:
> >> Hi,
> >>
> >> the gpmi-nand.c driver apparently has misconfigured ecc.size field:
> >>
> >> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:
> >> ---------->8 ----------
> >> 1493 chip->ecc.mode = NAND_ECC_HW;
> >> 1494 chip->ecc.size = 1;
> >> 1495 chip->ecc.layout =&gpmi_hw_ecclayout;
> >> ---------- 8< ----------
>
> [snip]
>
> > The gpmi driver does not support the subpage read/write.
> > I will be happy if the driver works only by setting the
> > NAND_NO_SUBPAGE_WRITE, without setting the ecc.size.
>
> Can we just get rid of NAND_CHIPOPTIONS_MSK and trust that drivers won't
> set options that aren't appropriate? Possibly replace it with
> documentation about which options are for chips, which are for drivers,
> and which (such as NAND_NO_SUBPAGE_WRITE) can be set by either.
Rather let's just adjust the mask?
M
>
> -Scott
next prev parent reply other threads:[~2012-01-04 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 0:48 GPMI-NAND: Wrong ECC size in driver Marek Vasut
2012-01-04 5:58 ` Huang Shijie
2012-01-04 17:30 ` Scott Wood
2012-01-04 21:32 ` Marek Vasut [this message]
2012-01-04 21:48 ` Scott Wood
2012-01-04 23:38 ` Marek Vasut
2012-01-04 23:48 ` Scott Wood
2012-01-31 11:33 ` Marek Vasut
2012-01-31 17:30 ` Brian Norris
2012-01-31 19:09 ` Scott Wood
2012-02-03 2:43 ` Brian Norris
2012-02-03 3:16 ` Brian Norris
2012-01-04 21:33 ` Marek Vasut
2012-01-05 2:08 ` Huang Shijie
2012-01-05 9:07 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201042232.26781.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=b32955@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.