Re: GPMI-NAND: Wrong ECC size in driver

[Scott Wood <scottwood@freescale.com>]

On 01/04/2012 05:38 PM, Marek Vasut wrote:
> Scott Wood wrote:
>> On 01/04/2012 03:32 PM, Marek Vasut wrote:
>>> Scott Wood wrote:
>>>> Can we just get rid of NAND_CHIPOPTIONS_MSK and trust that drivers won't
>>>> set options that aren't appropriate?  Possibly replace it with
>>>> documentation about which options are for chips, which are for drivers,
>>>> and which (such as NAND_NO_SUBPAGE_WRITE) can be set by either.
>>>
>>> Rather let's just adjust the mask?
>>
>> The way the mask is used means that any given option can only be chip or
>> driver, not both.  Though, I don't see anywhere this option is set by a
>> chip -- maybe we can just renumber it to be in the controller half.
> 
> I suspect this was meant to allow controllers where one chip can do subpage-
> write and the other can not.

What I mean is I don't see any place where this is actually used --
gpmi-nand is the only place I see this flag being set (though it belongs
on at least elbc as well).

>> I still don't see a whole lot of value in the mask, though -- seems to
>> be just causing problems, especially given that bits set by the "wrong"
>> component are silently discarded.
> 
> Yes. Patch is welcome to remove it and separate these two ;-)

Do they need to be separated?  Just OR them with no mask.  If either the
controller or the chip set the flag, then it's set, and subpage writes
are disallowed.  Obviously you can only do this for certain types of
options -- for others, just don't set the flag in an inappropriate context.

-Scott