From: Marek Vasut <marek.vasut@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>, linux-mtd@lists.infradead.org
Subject: Re: GPMI-NAND: Wrong ECC size in driver
Date: Thu, 5 Jan 2012 10:07:54 +0100 [thread overview]
Message-ID: <201201051007.54725.marek.vasut@gmail.com> (raw)
In-Reply-To: <4F050635.1020103@freescale.com>
> Hi,
>
> >> I will be happy if the driver works only by setting the
> >>
> >> > NAND_NO_SUBPAGE_WRITE, without setting the ecc.size.
> >
> > So you intentionally set the ecc.size to 1 to work around the issue?
>
> yes.
> I read the code, and it seemed setting the ecc.size to 1 is the right
> solution.
>
> Best Regards
> Huang Shijie
It's definitelly wrong because it relies on undefined behaviour! The right
solution here is to fix NAND_NO_SUBPAGE_WRITE pass-through as Scott and I
proposed.
M
prev parent reply other threads:[~2012-01-05 9:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 0:48 GPMI-NAND: Wrong ECC size in driver Marek Vasut
2012-01-04 5:58 ` Huang Shijie
2012-01-04 17:30 ` Scott Wood
2012-01-04 21:32 ` Marek Vasut
2012-01-04 21:48 ` Scott Wood
2012-01-04 23:38 ` Marek Vasut
2012-01-04 23:48 ` Scott Wood
2012-01-31 11:33 ` Marek Vasut
2012-01-31 17:30 ` Brian Norris
2012-01-31 19:09 ` Scott Wood
2012-02-03 2:43 ` Brian Norris
2012-02-03 3:16 ` Brian Norris
2012-01-04 21:33 ` Marek Vasut
2012-01-05 2:08 ` Huang Shijie
2012-01-05 9:07 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201051007.54725.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=b32955@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.