All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kai Bankett <chaosman@ontika.net>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]QNX6 filesystem (RO) driver
Date: Wed, 15 Feb 2012 07:11:19 +0000	[thread overview]
Message-ID: <20120215071119.GF23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120215064728.GE23916@ZenIV.linux.org.uk>

On Wed, Feb 15, 2012 at 06:47:28AM +0000, Al Viro wrote:
> On Wed, Feb 15, 2012 at 06:10:12AM +0000, Al Viro wrote:
> 
> [snip]
> 
> OK, I've dumped something that compiles in #qnx6 in vfs.git; I don't promise
> anything beyond that - consider that as slightly more elaborate variant of
> the previous mail.  At that stage I would definitely prefer to see fixes,
> etc. *folded* into the patch before it gets merged, so do not treat that
> branch as anything other than convenient (for me) way to post a series of
> incrementals.
> 
> Oh, and the final result will obviously need s-o-b by Kai + sane commit
> message, etc.

If you prefer to test on top of -stable, just copy d_make_root() from
current mainline into fs/dcache.c and export it - that's the only dependency
on the stuff from the last merge window.  Or just open-code the sucker
into your fill_super...

One more thing - unless I'm misreading the code it looks like your ->sb becomes
a dangling pointer once fill_super finishes and ->statfs() is dereferencing
it...

  reply	other threads:[~2012-02-15  7:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 20:41 [PATCH]QNX6 filesystem (RO) driver Kai Bankett
2012-02-12  4:56 ` Al Viro
2012-02-12 22:14   ` Kai Bankett
2012-02-12 22:43     ` Al Viro
2012-02-15  2:52       ` Kai Bankett
2012-02-15  6:10         ` Al Viro
2012-02-15  6:14           ` Al Viro
2012-02-15  6:47           ` Al Viro
2012-02-15  7:11             ` Al Viro [this message]
2012-02-15  7:57               ` Al Viro
2012-02-15 14:40                 ` Al Viro
2012-02-15 16:27                   ` Kai Bankett
2012-02-15 21:35                     ` Al Viro
2012-02-16 10:00                   ` Al Viro
2012-02-17 15:06                     ` Kai Bankett
2012-02-17 16:20                       ` Al Viro
2012-02-17 17:53                         ` Kai Bankett
2012-02-17 18:35                           ` Al Viro
2012-02-17 18:53                             ` Al Viro
2012-02-17 21:38                               ` Kai Bankett
2012-02-21 22:04                                 ` Al Viro
2012-02-21 22:09                                   ` Al Viro
2012-02-22 11:58                                     ` Kai Bankett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120215071119.GF23916@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=chaosman@ontika.net \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.