From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kai Bankett <chaosman@ontika.net>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]QNX6 filesystem (RO) driver
Date: Tue, 21 Feb 2012 22:09:49 +0000 [thread overview]
Message-ID: <20120221220949.GU23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120221220455.GT23916@ZenIV.linux.org.uk>
On Tue, Feb 21, 2012 at 10:04:55PM +0000, Al Viro wrote:
> What we need to do is either
> * silently return 0 on thislen > QNX6_LONG_NAME_MAX, or
> * return 0 and yell about corrupt /longfiles, or
> * have qnx6_lookup() check that len <= QNX6_LONG_NAME_MAX and
> return ERR_PTR(-ENAMETOOLONG) if it isn't. And lose the thislen check
> completely.
>
> I'd probably go for the last variant; it's consistent with what other
> filesystems are doing and it would avoid mess if we ever try to do
> r/w variant.
Oh, wait - you already are doing that in ->lookup()? Then it's definitely
"let's lose thislen checks in qnx6_long_match() and qnx6_match()". Dead
code is dead code...
Pushed with that correction.
next prev parent reply other threads:[~2012-02-21 22:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 20:41 [PATCH]QNX6 filesystem (RO) driver Kai Bankett
2012-02-12 4:56 ` Al Viro
2012-02-12 22:14 ` Kai Bankett
2012-02-12 22:43 ` Al Viro
2012-02-15 2:52 ` Kai Bankett
2012-02-15 6:10 ` Al Viro
2012-02-15 6:14 ` Al Viro
2012-02-15 6:47 ` Al Viro
2012-02-15 7:11 ` Al Viro
2012-02-15 7:57 ` Al Viro
2012-02-15 14:40 ` Al Viro
2012-02-15 16:27 ` Kai Bankett
2012-02-15 21:35 ` Al Viro
2012-02-16 10:00 ` Al Viro
2012-02-17 15:06 ` Kai Bankett
2012-02-17 16:20 ` Al Viro
2012-02-17 17:53 ` Kai Bankett
2012-02-17 18:35 ` Al Viro
2012-02-17 18:53 ` Al Viro
2012-02-17 21:38 ` Kai Bankett
2012-02-21 22:04 ` Al Viro
2012-02-21 22:09 ` Al Viro [this message]
2012-02-22 11:58 ` Kai Bankett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221220949.GU23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chaosman@ontika.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.