Re: [PATCH]QNX6 filesystem (RO) driver

[Al Viro <viro@ZenIV.linux.org.uk>]

On Wed, Feb 15, 2012 at 02:40:37PM +0000, Al Viro wrote:

> Other than that... this stuff could use some tidying up, but that's not
> a big deal.  I really wonder if these config options are worthwhile -
> might be better to stick endianness and mmi to y unconditionally.  And
> of course all those incrementals are completely untested and might very
> well br broken.

FWIW, having looked at that code again, I'm definitely in favour of dumping
the ENDIANNESS and MMI config options; the latter is not time-critical at all
(of anything even remotely hot it only affects the checksum verification
for longnames on readdir *and* its only effect is possible short-circuiting
a relatively long calculation - I've just spotted and fixed a braino in
that ifdef from hell, BTW).  And the former... I would be _very_ surprised
if disabling it would be a visible win on any workloads.

BTW, reporting non-options in ->show_options() is probably a bad idea;
sure, you end up ignoring options in your ->mount(), so it won't confuse
any userland scripts too badly, but...