From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kai Bankett <chaosman@ontika.net>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]QNX6 filesystem (RO) driver
Date: Fri, 17 Feb 2012 16:20:06 +0000 [thread overview]
Message-ID: <20120217162006.GO23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <2977b399b903a3b7bff1ffe93e8d3dd9.squirrel@www.ontika.net>
On Fri, Feb 17, 2012 at 04:06:19PM +0100, Kai Bankett wrote:
> - fixed broken mmi superblock handling, broken by the switch to pagemap,
> root_node etc. stuff ;)
+ bh1 = sb_bread(s, s->s_blocksize);
in there looks rather fishy...
qnx6_lfile_checksum() doesn't use superblock argument anymore (used to
be used for conversion, but since you are passing length from the
caller...)
qnx6_longname() - since you are passing superblock anyway, sbi is
redundant...
+ inode->i_blocks = (inode->i_size >> sb->s_blocksize_bits)
+ << (sb->s_blocksize_bits - 9);
looks too convoluted and if you really want to be pedantic, not 100%
correct - you end up rounding it down, not up.
FWIW, I would probably simply do (inode->i_size + 511) >> 9 and devil
take the rounding effects on big block sizes; it's an approximation
anyway, since you are not counting indirect blocks...
Other than that (and assuming it survives your testing), I'm fine with
that variant.
next prev parent reply other threads:[~2012-02-17 16:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 20:41 [PATCH]QNX6 filesystem (RO) driver Kai Bankett
2012-02-12 4:56 ` Al Viro
2012-02-12 22:14 ` Kai Bankett
2012-02-12 22:43 ` Al Viro
2012-02-15 2:52 ` Kai Bankett
2012-02-15 6:10 ` Al Viro
2012-02-15 6:14 ` Al Viro
2012-02-15 6:47 ` Al Viro
2012-02-15 7:11 ` Al Viro
2012-02-15 7:57 ` Al Viro
2012-02-15 14:40 ` Al Viro
2012-02-15 16:27 ` Kai Bankett
2012-02-15 21:35 ` Al Viro
2012-02-16 10:00 ` Al Viro
2012-02-17 15:06 ` Kai Bankett
2012-02-17 16:20 ` Al Viro [this message]
2012-02-17 17:53 ` Kai Bankett
2012-02-17 18:35 ` Al Viro
2012-02-17 18:53 ` Al Viro
2012-02-17 21:38 ` Kai Bankett
2012-02-21 22:04 ` Al Viro
2012-02-21 22:09 ` Al Viro
2012-02-22 11:58 ` Kai Bankett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217162006.GO23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chaosman@ontika.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.