From: Arnd Bergmann <arnd@arndb.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: Per Forlin <per.forlin@stericsson.com>,
linux-arm-kernel@lists.infradead.org, cjb@laptop.org,
niklas.hernaeus@linaro.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree
Date: Thu, 15 Mar 2012 15:32:44 +0000 [thread overview]
Message-ID: <201203151532.44363.arnd@arndb.de> (raw)
In-Reply-To: <4F6209DA.1080809@linaro.org>
On Thursday 15 March 2012, Lee Jones wrote:
> > I would like to see what the minimal required change is to support DT
> > for mmci without factorization.
> > 1. Minimal change in mmci.
> > 2. Add mmci_dt.c which contains the DT-populate code.
> >
> > The factorization could be done as step 2 I think.
> >
> > What do you say?
>
> I'm wondering what the difference is as the work has already been done.
>
> It was Arnd's suggestion to separate out the two types of variants, and
> I'm quite fond of the new (fully featured) layout.
Right, I usually prefer cleanups or other refactoring to be done first, and
then features added on top.
You could in theory add have just patches 3/4/5 all applied without
the refactoring, but that I would be worried that this causes dependencies
between the mmci driver and ux500 specific functionality like the
stedma40_filter function.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree
Date: Thu, 15 Mar 2012 15:32:44 +0000 [thread overview]
Message-ID: <201203151532.44363.arnd@arndb.de> (raw)
In-Reply-To: <4F6209DA.1080809@linaro.org>
On Thursday 15 March 2012, Lee Jones wrote:
> > I would like to see what the minimal required change is to support DT
> > for mmci without factorization.
> > 1. Minimal change in mmci.
> > 2. Add mmci_dt.c which contains the DT-populate code.
> >
> > The factorization could be done as step 2 I think.
> >
> > What do you say?
>
> I'm wondering what the difference is as the work has already been done.
>
> It was Arnd's suggestion to separate out the two types of variants, and
> I'm quite fond of the new (fully featured) layout.
Right, I usually prefer cleanups or other refactoring to be done first, and
then features added on top.
You could in theory add have just patches 3/4/5 all applied without
the refactoring, but that I would be worried that this causes dependencies
between the mmci driver and ux500 specific functionality like the
stedma40_filter function.
Arnd
next prev parent reply other threads:[~2012-03-15 15:33 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 14:19 [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree Lee Jones
2012-03-14 14:19 ` Lee Jones
2012-03-14 14:19 ` [PATCH 1/5] MMC: mmci: Seperate ux500 variants from generic code Lee Jones
2012-03-14 14:19 ` Lee Jones
2012-03-14 14:20 ` [PATCH 2/5] MMC: mmci: Seperate ARM " Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-15 17:32 ` Russell King - ARM Linux
2012-03-15 17:32 ` Russell King - ARM Linux
2012-03-15 17:36 ` Lee Jones
2012-03-15 17:36 ` Lee Jones
2012-03-15 17:37 ` Russell King - ARM Linux
2012-03-15 17:37 ` Russell King - ARM Linux
2012-03-15 17:46 ` Arnd Bergmann
2012-03-15 17:46 ` Arnd Bergmann
2012-03-15 17:54 ` Russell King - ARM Linux
2012-03-15 17:54 ` Russell King - ARM Linux
2012-03-15 18:23 ` Arnd Bergmann
2012-03-15 18:23 ` Arnd Bergmann
2012-03-15 20:30 ` Russell King - ARM Linux
2012-03-15 20:30 ` Russell King - ARM Linux
2012-03-16 12:48 ` Arnd Bergmann
2012-03-16 12:48 ` Arnd Bergmann
2012-03-17 21:30 ` Mark Brown
2012-03-17 21:30 ` Mark Brown
2012-03-15 17:38 ` Lee Jones
2012-03-15 17:38 ` Lee Jones
2012-03-14 14:20 ` [PATCH 3/5] MMC: mmci: Add generic Device Tree bindings to mmci core code Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-15 15:12 ` Per Forlin
2012-03-15 15:12 ` Per Forlin
2012-03-15 15:25 ` Lee Jones
2012-03-15 15:25 ` Lee Jones
2012-03-14 14:20 ` [PATCH 4/5] MMC: mmci: Enable Device Tree support for ux500 variants Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-14 14:20 ` [PATCH 5/5] MMC: mmci: Add required documentation for Device Tree bindings Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-15 17:35 ` Russell King - ARM Linux
2012-03-15 17:35 ` Russell King - ARM Linux
2012-03-15 17:49 ` Arnd Bergmann
2012-03-15 17:49 ` Arnd Bergmann
2012-03-15 17:58 ` Russell King - ARM Linux
2012-03-15 17:58 ` Russell King - ARM Linux
2012-03-15 17:53 ` Arnd Bergmann
2012-03-15 17:53 ` Arnd Bergmann
2012-03-15 17:59 ` Russell King - ARM Linux
2012-03-15 17:59 ` Russell King - ARM Linux
2012-03-15 15:06 ` [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree Per Forlin
2012-03-15 15:06 ` Per Forlin
2012-03-15 15:25 ` Lee Jones
2012-03-15 15:25 ` Lee Jones
2012-03-15 15:32 ` Arnd Bergmann [this message]
2012-03-15 15:32 ` Arnd Bergmann
2012-03-15 15:44 ` Lee Jones
2012-03-15 15:44 ` Lee Jones
2012-03-15 19:12 ` Per Forlin
2012-03-15 19:12 ` Per Forlin
2012-03-15 20:36 ` Russell King - ARM Linux
2012-03-15 20:36 ` Russell King - ARM Linux
2012-03-15 20:58 ` Arnd Bergmann
2012-03-15 20:58 ` Arnd Bergmann
2012-03-16 9:01 ` Linus Walleij
2012-03-16 9:01 ` Linus Walleij
2012-03-16 12:36 ` Arnd Bergmann
2012-03-16 12:36 ` Arnd Bergmann
2012-03-17 21:26 ` Mark Brown
2012-03-17 21:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203151532.44363.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=niklas.hernaeus@linaro.org \
--cc=per.forlin@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.