From: Lee Jones <lee.jones@linaro.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, niklas.hernaeus@linaro.org,
cjb@laptop.org, linux-mmc@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH 2/5] MMC: mmci: Seperate ARM variants from generic code
Date: Thu, 15 Mar 2012 17:36:04 +0000 [thread overview]
Message-ID: <4F622884.6060807@linaro.org> (raw)
In-Reply-To: <20120315173256.GD15988@n2100.arm.linux.org.uk>
On 15/03/12 17:32, Russell King - ARM Linux wrote:
> On Wed, Mar 14, 2012 at 02:20:00PM +0000, Lee Jones wrote:
>> This is a step in the right direction for future Device
>> Tree support. It will allow variant specific attributes
>> to be collected from a Device Tree without overloading
>> the MMCI core. It will also provide additional future
>> variants a cleaner way to add support.
>
> NAK. You can't have two driver structures with the same name. The names
> are sysfs object names.
Well spotted.
I've already changed this in v2. :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] MMC: mmci: Seperate ARM variants from generic code
Date: Thu, 15 Mar 2012 17:36:04 +0000 [thread overview]
Message-ID: <4F622884.6060807@linaro.org> (raw)
In-Reply-To: <20120315173256.GD15988@n2100.arm.linux.org.uk>
On 15/03/12 17:32, Russell King - ARM Linux wrote:
> On Wed, Mar 14, 2012 at 02:20:00PM +0000, Lee Jones wrote:
>> This is a step in the right direction for future Device
>> Tree support. It will allow variant specific attributes
>> to be collected from a Device Tree without overloading
>> the MMCI core. It will also provide additional future
>> variants a cleaner way to add support.
>
> NAK. You can't have two driver structures with the same name. The names
> are sysfs object names.
Well spotted.
I've already changed this in v2. :)
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2012-03-15 17:36 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 14:19 [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree Lee Jones
2012-03-14 14:19 ` Lee Jones
2012-03-14 14:19 ` [PATCH 1/5] MMC: mmci: Seperate ux500 variants from generic code Lee Jones
2012-03-14 14:19 ` Lee Jones
2012-03-14 14:20 ` [PATCH 2/5] MMC: mmci: Seperate ARM " Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-15 17:32 ` Russell King - ARM Linux
2012-03-15 17:32 ` Russell King - ARM Linux
2012-03-15 17:36 ` Lee Jones [this message]
2012-03-15 17:36 ` Lee Jones
2012-03-15 17:37 ` Russell King - ARM Linux
2012-03-15 17:37 ` Russell King - ARM Linux
2012-03-15 17:46 ` Arnd Bergmann
2012-03-15 17:46 ` Arnd Bergmann
2012-03-15 17:54 ` Russell King - ARM Linux
2012-03-15 17:54 ` Russell King - ARM Linux
2012-03-15 18:23 ` Arnd Bergmann
2012-03-15 18:23 ` Arnd Bergmann
2012-03-15 20:30 ` Russell King - ARM Linux
2012-03-15 20:30 ` Russell King - ARM Linux
2012-03-16 12:48 ` Arnd Bergmann
2012-03-16 12:48 ` Arnd Bergmann
2012-03-17 21:30 ` Mark Brown
2012-03-17 21:30 ` Mark Brown
2012-03-15 17:38 ` Lee Jones
2012-03-15 17:38 ` Lee Jones
2012-03-14 14:20 ` [PATCH 3/5] MMC: mmci: Add generic Device Tree bindings to mmci core code Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-15 15:12 ` Per Forlin
2012-03-15 15:12 ` Per Forlin
2012-03-15 15:25 ` Lee Jones
2012-03-15 15:25 ` Lee Jones
2012-03-14 14:20 ` [PATCH 4/5] MMC: mmci: Enable Device Tree support for ux500 variants Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-14 14:20 ` [PATCH 5/5] MMC: mmci: Add required documentation for Device Tree bindings Lee Jones
2012-03-14 14:20 ` Lee Jones
2012-03-15 17:35 ` Russell King - ARM Linux
2012-03-15 17:35 ` Russell King - ARM Linux
2012-03-15 17:49 ` Arnd Bergmann
2012-03-15 17:49 ` Arnd Bergmann
2012-03-15 17:58 ` Russell King - ARM Linux
2012-03-15 17:58 ` Russell King - ARM Linux
2012-03-15 17:53 ` Arnd Bergmann
2012-03-15 17:53 ` Arnd Bergmann
2012-03-15 17:59 ` Russell King - ARM Linux
2012-03-15 17:59 ` Russell King - ARM Linux
2012-03-15 15:06 ` [PATCH 0/5] MMC: mmci: Provide bindings for Device Tree Per Forlin
2012-03-15 15:06 ` Per Forlin
2012-03-15 15:25 ` Lee Jones
2012-03-15 15:25 ` Lee Jones
2012-03-15 15:32 ` Arnd Bergmann
2012-03-15 15:32 ` Arnd Bergmann
2012-03-15 15:44 ` Lee Jones
2012-03-15 15:44 ` Lee Jones
2012-03-15 19:12 ` Per Forlin
2012-03-15 19:12 ` Per Forlin
2012-03-15 20:36 ` Russell King - ARM Linux
2012-03-15 20:36 ` Russell King - ARM Linux
2012-03-15 20:58 ` Arnd Bergmann
2012-03-15 20:58 ` Arnd Bergmann
2012-03-16 9:01 ` Linus Walleij
2012-03-16 9:01 ` Linus Walleij
2012-03-16 12:36 ` Arnd Bergmann
2012-03-16 12:36 ` Arnd Bergmann
2012-03-17 21:26 ` Mark Brown
2012-03-17 21:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F622884.6060807@linaro.org \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=niklas.hernaeus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.