From: "Michael S. Tsirkin" <mst@redhat.com>
To: netdev@vger.kernel.org
Cc: Amit Shah <amit.shah@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Wed, 4 Apr 2012 12:19:55 +0300 [thread overview]
Message-ID: <20120404091954.GA3776@redhat.com> (raw)
disable_cb is just an optimization: it
can not guarantee that there are no callbacks.
I didn't yet figure out whether a callback
in freeze will trigger a bug, but disable_cb
won't address it in any case. So let's remove
the useless calls as a first step.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/net/virtio_net.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 019da01..971931e5 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1182,11 +1182,6 @@ static int virtnet_freeze(struct virtio_device *vdev)
{
struct virtnet_info *vi = vdev->priv;
- virtqueue_disable_cb(vi->rvq);
- virtqueue_disable_cb(vi->svq);
- if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ))
- virtqueue_disable_cb(vi->cvq);
-
netif_device_detach(vi->dev);
cancel_delayed_work_sync(&vi->refill);
--
1.7.9.111.gf3fb0
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: netdev@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Amit Shah <amit.shah@redhat.com>,
kvm@vger.kernel.org
Subject: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Wed, 4 Apr 2012 12:19:55 +0300 [thread overview]
Message-ID: <20120404091954.GA3776@redhat.com> (raw)
disable_cb is just an optimization: it
can not guarantee that there are no callbacks.
I didn't yet figure out whether a callback
in freeze will trigger a bug, but disable_cb
won't address it in any case. So let's remove
the useless calls as a first step.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/net/virtio_net.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 019da01..971931e5 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1182,11 +1182,6 @@ static int virtnet_freeze(struct virtio_device *vdev)
{
struct virtnet_info *vi = vdev->priv;
- virtqueue_disable_cb(vi->rvq);
- virtqueue_disable_cb(vi->svq);
- if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ))
- virtqueue_disable_cb(vi->cvq);
-
netif_device_detach(vi->dev);
cancel_delayed_work_sync(&vi->refill);
--
1.7.9.111.gf3fb0
next reply other threads:[~2012-04-04 9:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 9:19 Michael S. Tsirkin [this message]
2012-04-04 9:19 ` [PATCH RFC] virtio-net: remove useless disable on freeze Michael S. Tsirkin
2012-05-03 10:59 ` Amit Shah
2012-05-03 10:59 ` Amit Shah
2012-05-03 11:08 ` Michael S. Tsirkin
2012-05-03 11:08 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-30 10:11 ` Rusty Russell
2012-05-30 10:11 ` Rusty Russell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404091954.GA3776@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.