From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Thu, 3 May 2012 14:08:45 +0300 [thread overview]
Message-ID: <20120503110845.GA25569@redhat.com> (raw)
In-Reply-To: <20120503105959.GM13421@amit.redhat.com>
On Thu, May 03, 2012 at 04:29:59PM +0530, Amit Shah wrote:
> On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote:
> > disable_cb is just an optimization: it
> > can not guarantee that there are no callbacks.
>
> Even then, what's the harm in keeping it? If indeed there's an
> attempt to raise an interrupt after the host has been notified, it
> will be suppressed.
It won't. It's not a guarantee, e.g. with event index on
it does nothing at all.
> Also, disable_cb seems to be used elsewhere in the virtio_net.c file,
> to suit similar purposes.
>
> Amit
Where?
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: netdev@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] virtio-net: remove useless disable on freeze
Date: Thu, 3 May 2012 14:08:45 +0300 [thread overview]
Message-ID: <20120503110845.GA25569@redhat.com> (raw)
In-Reply-To: <20120503105959.GM13421@amit.redhat.com>
On Thu, May 03, 2012 at 04:29:59PM +0530, Amit Shah wrote:
> On (Wed) 04 Apr 2012 [12:19:55], Michael S. Tsirkin wrote:
> > disable_cb is just an optimization: it
> > can not guarantee that there are no callbacks.
>
> Even then, what's the harm in keeping it? If indeed there's an
> attempt to raise an interrupt after the host has been notified, it
> will be suppressed.
It won't. It's not a guarantee, e.g. with event index on
it does nothing at all.
> Also, disable_cb seems to be used elsewhere in the virtio_net.c file,
> to suit similar purposes.
>
> Amit
Where?
next prev parent reply other threads:[~2012-05-03 11:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 9:19 [PATCH RFC] virtio-net: remove useless disable on freeze Michael S. Tsirkin
2012-04-04 9:19 ` Michael S. Tsirkin
2012-05-03 10:59 ` Amit Shah
2012-05-03 10:59 ` Amit Shah
2012-05-03 11:08 ` Michael S. Tsirkin [this message]
2012-05-03 11:08 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-28 12:53 ` Michael S. Tsirkin
2012-05-30 10:11 ` Rusty Russell
2012-05-30 10:11 ` Rusty Russell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:35 ` Stephen Rothwell
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 8:47 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
2012-05-31 9:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120503110845.GA25569@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.